Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant dump_enabled check #89893

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Remove redundant dump_enabled check #89893

merged 2 commits into from
Oct 22, 2021

Conversation

camsteffen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2021
@camsteffen
Copy link
Contributor Author

r? @matthewjasper since this is split from #89636

@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 21, 2021
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 21, 2021

📌 Commit 7166df4 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2021
@jackh726
Copy link
Member

@bors rollup=never potential perf

@bors
Copy link
Contributor

bors commented Oct 22, 2021

⌛ Testing commit 7166df4 with merge b034b3bf74c67db8d554bfa919a66d2b721d308a...

@camsteffen
Copy link
Contributor Author

@bors ping

@bors
Copy link
Contributor

bors commented Oct 22, 2021

😪 I'm awake I'm awake

@camsteffen
Copy link
Contributor Author

@bors retry

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@camsteffen
Copy link
Contributor Author

@bors retry

@bors
Copy link
Contributor

bors commented Oct 22, 2021

⌛ Testing commit 7166df4 with merge 0119879...

@bors
Copy link
Contributor

bors commented Oct 22, 2021

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing 0119879 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 22, 2021
@bors bors merged commit 0119879 into rust-lang:master Oct 22, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 22, 2021
@camsteffen camsteffen deleted the redundant-dump-enabled branch October 22, 2021 22:04
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0119879): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@camsteffen camsteffen mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
10 participants
@camsteffen @rust-highfive @matthewjasper @bors @jackh726 @rust-log-analyzer @rust-timer @michaelwoerister @apiraino @rustbot