-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf experiment for "Get piece unchecked in write" #89521
Conversation
@rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
@bors try |
⌛ Trying commit 669f6ec with merge f89bef1216fa28f8a8774452b0419ad8fbb0ed6f... |
☀️ Try build successful - checks-actions |
Queued f89bef1216fa28f8a8774452b0419ad8fbb0ed6f with parent a479766, future comparison URL. |
Finished benchmarking commit (f89bef1216fa28f8a8774452b0419ad8fbb0ed6f): comparison url. Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Measuring the true cost of #83302 by reverting it and #89139
r? @ghost