Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf experiment for "Get piece unchecked in write" #89521

Closed
wants to merge 9 commits into from

Conversation

camsteffen
Copy link
Contributor

Measuring the true cost of #83302 by reverting it and #89139

r? @ghost

@camsteffen
Copy link
Contributor Author

@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 4, 2021
@camsteffen
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 4, 2021

⌛ Trying commit 669f6ec with merge f89bef1216fa28f8a8774452b0419ad8fbb0ed6f...

@bors
Copy link
Contributor

bors commented Oct 4, 2021

☀️ Try build successful - checks-actions
Build commit: f89bef1216fa28f8a8774452b0419ad8fbb0ed6f (f89bef1216fa28f8a8774452b0419ad8fbb0ed6f)

@rust-timer
Copy link
Collaborator

Queued f89bef1216fa28f8a8774452b0419ad8fbb0ed6f with parent a479766, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f89bef1216fa28f8a8774452b0419ad8fbb0ed6f): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.7% on full builds of deeply-nested-closures)
  • Moderate regression in instruction counts (up to 0.7% on incr-patched: b9b3e592dd cherry picked builds of style-servo)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 4, 2021
@camsteffen camsteffen closed this Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants