Add `#[repr(i8)]` to `Ordering` #89507

lopopolo · 2021-10-04T04:03:41Z

Followup to #89491 to allow Ordering to auto-derive AsRepr once the proposal to add AsRepr (#81642) lands.

cc @joshtriplett

Followup to #89491 to allow `Ordering` to auto-derive `AsRepr` once the proposal to add `AsRepr` (#81642) lands.

rust-highfive · 2021-10-04T04:03:44Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

joshtriplett · 2021-10-04T04:19:18Z

This seems reasonable to me, and I think we should make this part of the ABI of Ordering.

@rfcbot merge

rfcbot · 2021-10-04T04:19:19Z

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

joshtriplett · 2021-10-04T04:19:54Z

Note that I think this change makes sense no matter what happens with #81642; I don't think this needs to wait on #81642.

joshtriplett · 2021-10-04T04:20:17Z

r? @joshtriplett

rfcbot · 2021-10-06T03:53:12Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2021-10-16T03:53:25Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

joshtriplett · 2021-10-16T05:52:42Z

@bors r+

bors · 2021-10-16T05:52:43Z

📌 Commit e41bb97 has been approved by joshtriplett

… r=joshtriplett Add `#[repr(i8)]` to `Ordering` Followup to rust-lang#89491 to allow `Ordering` to auto-derive `AsRepr` once the proposal to add `AsRepr` (rust-lang#81642) lands. cc `@joshtriplett`

Rollup of 7 pull requests Successful merges: - rust-lang#89507 (Add `#[repr(i8)]` to `Ordering`) - rust-lang#89849 (CI: Selecting the Xcode version no longer needed with the macos-11 runners.) - rust-lang#89886 (Update the wasi-libc built with the wasm32-wasi target) - rust-lang#89907 (Remove FIXME since there is nothing to be fixed) - rust-lang#89943 (clippy::complexity fixes) - rust-lang#89953 (Make Option::as_mut const) - rust-lang#89958 (Correct small typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

joshtriplett · 2021-10-17T12:42:58Z

Snippet for release notes:

The Ordering enum is now guaranteed to use an i8 representation, with the values -1, 0, and 1. This makes it easier to implement other cmp-style APIs.

Pkgsrc changes: * Adapt a couple of patches Upstream changes: Version 1.57.0 (2021-12-02) ========================== Language -------- - [Macro attributes may follow `#[derive]` and will see the original (pre-`cfg`) input.][87220] - [Accept curly-brace macros in expressions, like `m!{ .. }.method()` and `m!{ .. }?`.][88690] - [Allow panicking in constant evaluation.][89508] Compiler -------- - [Create more accurate debuginfo for vtables.][89597] - [Add `armv6k-nintendo-3ds` at Tier 3\*.][88529] - [Add `armv7-unknown-linux-uclibceabihf` at Tier 3\*.][88952] - [Add `m68k-unknown-linux-gnu` at Tier 3\*.][88321] - [Add SOLID targets at Tier 3\*:][86191] `aarch64-kmc-solid_asp3`, `armv7a-kmc-solid_asp3-eabi`, `armv7a-kmc-solid_asp3-eabihf` \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Avoid allocations and copying in `Vec::leak`][89337] - [Add `#[repr(i8)]` to `Ordering`][89507] - [Optimize `File::read_to_end` and `read_to_string`][89582] - [Update to Unicode 14.0][89614] - [Many more functions are marked `#[must_use]`][89692], producing a warning when ignoring their return value. This helps catch mistakes such as expecting a function to mutate a value in place rather than return a new value. Stabilised APIs --------------- - [`[T; N]::as_mut_slice`][`array::as_mut_slice`] - [`[T; N]::as_slice`][`array::as_slice`] - [`collections::TryReserveError`] - [`HashMap::try_reserve`] - [`HashSet::try_reserve`] - [`String::try_reserve`] - [`String::try_reserve_exact`] - [`Vec::try_reserve`] - [`Vec::try_reserve_exact`] - [`VecDeque::try_reserve`] - [`VecDeque::try_reserve_exact`] - [`Iterator::map_while`] - [`iter::MapWhile`] - [`proc_macro::is_available`] - [`Command::get_program`] - [`Command::get_args`] - [`Command::get_envs`] - [`Command::get_current_dir`] - [`CommandArgs`] - [`CommandEnvs`] These APIs are now usable in const contexts: - [`hint::unreachable_unchecked`] Cargo ----- - [Stabilize custom profiles][cargo/9943] Compatibility notes ------------------- Internal changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Added an experimental backend for codegen with `libgccjit`.][87260] [86191]: rust-lang/rust#86191 [87220]: rust-lang/rust#87220 [87260]: rust-lang/rust#87260 [88243]: rust-lang/rust#88243 [88321]: rust-lang/rust#88321 [88529]: rust-lang/rust#88529 [88690]: rust-lang/rust#88690 [88952]: rust-lang/rust#88952 [89337]: rust-lang/rust#89337 [89507]: rust-lang/rust#89507 [89508]: rust-lang/rust#89508 [89582]: rust-lang/rust#89582 [89597]: rust-lang/rust#89597 [89614]: rust-lang/rust#89614 [89692]: rust-lang/rust#89692 [cargo/9943]: rust-lang/cargo#9943 [`array::as_mut_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_mut_slice [`array::as_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_slice [`collections::TryReserveError`]: https://doc.rust-lang.org/std/collections/struct.TryReserveError.html [`HashMap::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.try_reserve [`HashSet::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_set/struct.HashSet.html#method.try_reserve [`String::try_reserve`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve [`String::try_reserve_exact`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve_exact [`Vec::try_reserve`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve [`Vec::try_reserve_exact`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve_exact [`VecDeque::try_reserve`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve [`VecDeque::try_reserve_exact`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve_exact [`Iterator::map_while`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.map_while [`iter::MapWhile`]: https://doc.rust-lang.org/std/iter/struct.MapWhile.html [`proc_macro::is_available`]: https://doc.rust-lang.org/proc_macro/fn.is_available.html [`Command::get_program`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_program [`Command::get_args`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_args [`Command::get_envs`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_envs [`Command::get_current_dir`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_current_dir [`CommandArgs`]: https://doc.rust-lang.org/std/process/struct.CommandArgs.html [`CommandEnvs`]: https://doc.rust-lang.org/std/process/struct.CommandEnvs.html

Pkgsrc changes: * Adjust line numbers in a number of patches * remove the --disable-dist-src option, so that we produce the rust-src rust component, which we upload to LOCALSRC to allow the rust-src package to build, which is needed for rust-analyzer. * Cargo checksum for vendor/cc no longer needs patching; checksum for vendor/libc updated Upstream changes: Version 1.57.0 (2021-12-02) ========================== Language -------- - [Macro attributes may follow `#[derive]` and will see the original (pre-`cfg`) input.][87220] - [Accept curly-brace macros in expressions, like `m!{ .. }.method()` and `m!{ .. }?`.][88690] - [Allow panicking in constant evaluation.][89508] Compiler -------- - [Create more accurate debuginfo for vtables.][89597] - [Add `armv6k-nintendo-3ds` at Tier 3\*.][88529] - [Add `armv7-unknown-linux-uclibceabihf` at Tier 3\*.][88952] - [Add `m68k-unknown-linux-gnu` at Tier 3\*.][88321] - [Add SOLID targets at Tier 3\*:][86191] `aarch64-kmc-solid_asp3`, `armv7a-kmc-solid_asp3-eabi`, `armv7a-kmc-solid_asp3-eabihf` \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Avoid allocations and copying in `Vec::leak`][89337] - [Add `#[repr(i8)]` to `Ordering`][89507] - [Optimize `File::read_to_end` and `read_to_string`][89582] - [Update to Unicode 14.0][89614] - [Many more functions are marked `#[must_use]`][89692], producing a warning when ignoring their return value. This helps catch mistakes such as expecting a function to mutate a value in place rather than return a new value. Stabilised APIs --------------- - [`[T; N]::as_mut_slice`][`array::as_mut_slice`] - [`[T; N]::as_slice`][`array::as_slice`] - [`collections::TryReserveError`] - [`HashMap::try_reserve`] - [`HashSet::try_reserve`] - [`String::try_reserve`] - [`String::try_reserve_exact`] - [`Vec::try_reserve`] - [`Vec::try_reserve_exact`] - [`VecDeque::try_reserve`] - [`VecDeque::try_reserve_exact`] - [`Iterator::map_while`] - [`iter::MapWhile`] - [`proc_macro::is_available`] - [`Command::get_program`] - [`Command::get_args`] - [`Command::get_envs`] - [`Command::get_current_dir`] - [`CommandArgs`] - [`CommandEnvs`] These APIs are now usable in const contexts: - [`hint::unreachable_unchecked`] Cargo ----- - [Stabilize custom profiles][cargo/9943] Compatibility notes ------------------- Internal changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Added an experimental backend for codegen with `libgccjit`.][87260] [86191]: rust-lang/rust#86191 [87220]: rust-lang/rust#87220 [87260]: rust-lang/rust#87260 [88243]: rust-lang/rust#88243 [88321]: rust-lang/rust#88321 [88529]: rust-lang/rust#88529 [88690]: rust-lang/rust#88690 [88952]: rust-lang/rust#88952 [89337]: rust-lang/rust#89337 [89507]: rust-lang/rust#89507 [89508]: rust-lang/rust#89508 [89582]: rust-lang/rust#89582 [89597]: rust-lang/rust#89597 [89614]: rust-lang/rust#89614 [89692]: rust-lang/rust#89692 [cargo/9943]: rust-lang/cargo#9943 [`array::as_mut_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_mut_slice [`array::as_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_slice [`collections::TryReserveError`]: https://doc.rust-lang.org/std/collections/struct.TryReserveError.html [`HashMap::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.try_reserve [`HashSet::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_set/struct.HashSet.html#method.try_reserve [`String::try_reserve`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve [`String::try_reserve_exact`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve_exact [`Vec::try_reserve`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve [`Vec::try_reserve_exact`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve_exact [`VecDeque::try_reserve`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve [`VecDeque::try_reserve_exact`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve_exact [`Iterator::map_while`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.map_while [`iter::MapWhile`]: https://doc.rust-lang.org/std/iter/struct.MapWhile.html [`proc_macro::is_available`]: https://doc.rust-lang.org/proc_macro/fn.is_available.html [`Command::get_program`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_program [`Command::get_args`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_args [`Command::get_envs`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_envs [`Command::get_current_dir`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_current_dir [`CommandArgs`]: https://doc.rust-lang.org/std/process/struct.CommandArgs.html [`CommandEnvs`]: https://doc.rust-lang.org/std/process/struct.CommandEnvs.html

JanBeh · 2022-03-28T08:28:38Z

The Ordering enum is now guaranteed to use an i8 representation, with the values -1, 0, and 1. This makes it easier to implement other cmp-style APIs.

@joshtriplett Maybe that guarantee should explicitly be added to the documentation of std::cmp::Ordering as well? See also this discussion on URLO.

Add #[repr(i8)] to Ordering

e41bb97

Followup to #89491 to allow `Ordering` to auto-derive `AsRepr` once the proposal to add `AsRepr` (#81642) lands.

rust-highfive assigned Mark-Simulacrum Oct 4, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2021

lopopolo mentioned this pull request Oct 4, 2021

Add impl From<Ordering> for i32 #89491

Closed

joshtriplett added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 4, 2021

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 4, 2021

joshtriplett added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021

rust-highfive assigned joshtriplett and unassigned Mark-Simulacrum Oct 4, 2021

nagisa mentioned this pull request Oct 4, 2021

"Automatically" implemented traits do not display implementors (or as implemented traits) in rustdoc #89533

Open

illicitonion mentioned this pull request Oct 5, 2021

Automatically implement AsRepr and allow deriving FromRepr for fieldless enums #81642

Closed

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 6, 2021

rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Oct 16, 2021

rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 16, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 16, 2021

GuillaumeGomez mentioned this pull request Oct 16, 2021

Rollup of 7 pull requests #89959

Closed

JohnTitor mentioned this pull request Oct 16, 2021

Rollup of 7 pull requests #89968

Merged

bors merged commit 9614da2 into rust-lang:master Oct 17, 2021

rustbot added this to the 1.57.0 milestone Oct 17, 2021

joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 17, 2021

apiraino removed the to-announce Announce this issue on triage meeting label Oct 21, 2021

lopopolo deleted the lopopolo/ordering-repr-i8 branch October 9, 2022 00:20

scottmcm mentioned this pull request Mar 25, 2024

Add Ord::cmp for primitives as a BinOp in MIR #118310

Merged

kennytm mentioned this pull request Apr 10, 2024

Add an expression for direct access to an enum's discriminant rust-lang/rfcs#3607

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `#[repr(i8)]` to `Ordering` #89507

Add `#[repr(i8)]` to `Ordering` #89507

lopopolo commented Oct 4, 2021

rust-highfive commented Oct 4, 2021

joshtriplett commented Oct 4, 2021

rfcbot commented Oct 4, 2021 •

edited by m-ou-se

Loading

joshtriplett commented Oct 4, 2021

joshtriplett commented Oct 4, 2021

rfcbot commented Oct 6, 2021

rfcbot commented Oct 16, 2021

joshtriplett commented Oct 16, 2021

bors commented Oct 16, 2021

joshtriplett commented Oct 17, 2021

JanBeh commented Mar 28, 2022

Add #[repr(i8)] to Ordering #89507

Add #[repr(i8)] to Ordering #89507

Conversation

lopopolo commented Oct 4, 2021

rust-highfive commented Oct 4, 2021

joshtriplett commented Oct 4, 2021

rfcbot commented Oct 4, 2021 • edited by m-ou-se Loading

joshtriplett commented Oct 4, 2021

joshtriplett commented Oct 4, 2021

rfcbot commented Oct 6, 2021

rfcbot commented Oct 16, 2021

joshtriplett commented Oct 16, 2021

bors commented Oct 16, 2021

joshtriplett commented Oct 17, 2021

JanBeh commented Mar 28, 2022

Add `#[repr(i8)]` to `Ordering` #89507

Add `#[repr(i8)]` to `Ordering` #89507

rfcbot commented Oct 4, 2021 •

edited by m-ou-se

Loading