Propagate deref coercion into block #83850

ldm0 · 2021-04-04T14:39:34Z

fn main() {
    // This already compiles
    let _: &i32 = &Box::new(1i32);
    // This doesn't compile until this PR.
    let _: &i32 = & { Box::new(1i32) };
}

Above code doesn't compiles because we apply check_expr_with_expectation() on { Box::new(1i32) } with ExpectHasType(i32). Which is a hard constraint and won't success without deref coercion.

This PR taks the same path as #20083 (remove the hard constraint on check_expr_with_expectation when meets a unsized type). When the compiler see a AddrOf(Foo(...))(e.g. &{ Box::new(1i32) }), removes the hard constraint that this Foo have some type.

Fixes #26978
Fixes #57749
Fixes #83783

rust-highfive · 2021-04-04T14:39:37Z

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2021-04-05T06:02:58Z

This is no my area of expertise, and also a language change.
r? @nikomatsakis @eddyb (because coercions)

eddyb · 2021-04-30T11:34:42Z

Wouldn't this lead to inference errors? I'm surprised we don't have tests that trip. But maybe it's special-cased enough to work. I'll defer to @nikomatsakis either way.

nikomatsakis · 2021-05-13T17:20:15Z

Sorry @ldm0 ! I'll try to give useful feedback ASAP

lambda-fairy · 2021-08-18T06:50:24Z

Wouldn't this lead to inference errors?

Is this something that we can figure out with a crater run?

AaronKutch · 2022-10-16T20:30:21Z

I would like to see this change made. There are two cases I know where deref coercion propagation is very useful. I have a set of macros that use variables from their scope internally. There is a set of storage structs that need to be taken by Deref or DerefMut to produce a common reference type used in the code the macro generates. With the deref coercion propagation that exists for unsized types, this always works without a hitch and allows me the nest the macros or use any storage or reference type in any position. For example:

use awint::prelude::*;
let a: ExtAwi = extawi!(0);
let b: &Bits = &inlawi!(0);
let mut e = &mut ExtAwi::zero(bw(4));
let f = &extawi!(a, b, extawi!(1), {let d = inlawi!(1); d}; e).unwrap();

Inside the macro the variables are bound like

let tmp0: &Bits = &a;
let tmp1: &Bits = &b;
let tmp2: &Bits = &extawi!(0); // note this internally has its own scope
let tmp3: &Bits = &{let d = inlawi!(0); d};

And everything else will just work. Without the propagation the latter two bindings and the assignment to f stop working and I have to bind the extawi!(1) and {let d = inlawi!(1); d} parts to external bindings and make a single use binding for the output of the macro, which isn't the end of the world but would make many use cases of these macros more cumbersome.

Of course, since the main storage and reference types I use are naturally unsized you might think I wouldn't complain, but there are other sets of sized structs that would greatly benefit from propagation in the general case.
In my awint_dag crate, for example, I have some "mimicking" types that need to mimick everything the normal types are capable of, which means I have to use some tricky unsafe code to make the mimicking reference type artificially unsized. Other people have given other examples for why it is useful.

We are wary of adding new complications into the coercion path for relatively minor benefit.

Given what is already possible with unsized types, there shouldn't be any compiler side complications correct? I presume that proc-macro code output is compiled as if it were pasted into the edition? The main problem is just the number of regressions (or I'm not sure what is an acceptable amount of breakage, how bad is 128 root regressions of which many are minor versions of the same library), so I think a edition dependent change is something we could do. I glanced through some of the breakages and saw one related to a macro, that looked like an external binding problem. In the vast majority of cases when using older macros in a new edition context, external changes can fix the compilation, and there should be few internal problems since good practice labels types explicitly inside a macro.

ldm0 · 2022-10-17T05:26:55Z

🎉 Experiment pr-83850 is completed! 📊 4194 regressed and 11 fixed (237111 total) 📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist! ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

The crater run seems suspicious:

ld issue: https://crater-reports.s3.amazonaws.com/pr-83850/try%23f6d7c613ae2d161ff37dbc63cc5abd809c878597/gh/kevinee007.arcryptiannft-breeding-solana/log.txt
backtrace-rs issue(locally verified it's correctly compiled): https://crater-reports.s3.amazonaws.com/pr-83850/try%23f6d7c613ae2d161ff37dbc63cc5abd809c878597/gh/BeniReydman.LocalStorage/log.txt
wayland-scanner issue(locally verified it's correctly compiled): https://crater-reports.s3.amazonaws.com/pr-83850/try%23f6d7c613ae2d161ff37dbc63cc5abd809c878597/reg/isosurface-0.1.0-alpha.0/log.txt

At the time the crater runs, there are some merge conflicts, I guess the error occurs because I haven't rebase it?

@pnkfelix Could you start another crater run to ensure the real immediate breakage this PR will introduce?

jackh726 · 2022-10-19T22:30:08Z

I'm fine to requeue a crater run to get an idea of how much of the breakage is spurious, but I'm not sure that those results will change the overall feeling against doing this now.

@bors try

Let's go ahead and @fcp close

It might be worth revisiting in the future when we can model this better formally, but for now it's probably not a good idea.

bors · 2022-10-19T22:30:17Z

⌛ Trying commit 25845ff with merge f7637e1d7fb16748989c9113c7a0d47087e454f8...

jackh726 · 2022-10-19T22:30:58Z

Whoops @rustbot fcp close

jackh726 · 2022-10-19T22:31:52Z

@rfcbot fcp close

jackh726 · 2022-10-19T22:33:10Z

@rfcbot close

rfcbot · 2022-10-19T22:33:11Z

Team member @jackh726 has proposed to close this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

bors · 2022-10-20T00:40:49Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-10-20T02:14:33Z

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2022-10-19T23:15:21Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:15:21Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None
[2022-10-19T23:15:21Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmprcAxih#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:15:23Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None
[2022-10-19T23:15:24Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmprcAxih#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmprcAxih/incremental-state"
[2022-10-19T23:15:28Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:15:28Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmprcAxih#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmprcAxih/incremental-state"
[2022-10-19T23:15:29Z DEBUG collector::execute] applying println to "/tmp/.tmprcAxih"
[2022-10-19T23:15:29Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:15:29Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:15:29Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmprcAxih#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmprcAxih/incremental-state"
[2022-10-19T23:15:30Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:15:30Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None
[2022-10-19T23:15:30Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpUe6jTB#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:15:33Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:15:33Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:15:33Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpUe6jTB#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpUe6jTB/incremental-state"
[2022-10-19T23:15:38Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:15:38Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpUe6jTB#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpUe6jTB/incremental-state"
[2022-10-19T23:15:39Z DEBUG collector::execute] applying println to "/tmp/.tmpUe6jTB"
[2022-10-19T23:15:39Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:15:39Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:15:39Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpUe6jTB#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpUe6jTB/incremental-state"
Executing benchmark cargo-0.60.0 (2/8)
Preparing cargo-0.60.0
[2022-10-19T23:15:40Z INFO  collector::execute] run_rustc with incremental=false, profile=Check, scenario=None, patch=None
[2022-10-19T23:15:40Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=None, patch=None
---
[2022-10-19T23:18:05Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:18:06Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None
[2022-10-19T23:18:06Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpw7SITo#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:19:14Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None
[2022-10-19T23:19:14Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpw7SITo#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpw7SITo/incremental-state"
[2022-10-19T23:20:39Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:20:39Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpw7SITo#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpw7SITo/incremental-state"
[2022-10-19T23:20:52Z DEBUG collector::execute] applying println to "/tmp/.tmpw7SITo"
[2022-10-19T23:20:52Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:20:52Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:20:52Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpw7SITo#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpw7SITo/incremental-state"
[2022-10-19T23:21:15Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:21:16Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None
[2022-10-19T23:21:16Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp2YG1GQ#[email protected]" "--release" "--lib" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:22:36Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
---
[2022-10-19T23:24:39Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:24:39Z INFO  collector::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None
[2022-10-19T23:24:39Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpmnziDn#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:24:48Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None
[2022-10-19T23:24:48Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpmnziDn#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpmnziDn/incremental-state"
[2022-10-19T23:24:59Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:24:59Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpmnziDn#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpmnziDn/incremental-state"
[2022-10-19T23:24:59Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:24:59Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None
[2022-10-19T23:24:59Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpc4CkD9#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:25:08Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None
---
[2022-10-19T23:26:05Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:26:05Z INFO  collector::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None
[2022-10-19T23:26:06Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpJ5YAqM#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:26:26Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None
[2022-10-19T23:26:26Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpJ5YAqM#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpJ5YAqM/incremental-state"
[2022-10-19T23:26:51Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:26:51Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpJ5YAqM#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpJ5YAqM/incremental-state"
[2022-10-19T23:26:55Z DEBUG collector::execute] applying println to "/tmp/.tmpJ5YAqM"
[2022-10-19T23:26:55Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:26:55Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:26:55Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpJ5YAqM#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpJ5YAqM/incremental-state"
[2022-10-19T23:26:59Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:26:59Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None
[2022-10-19T23:26:59Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpKMNj02#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:27:23Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None
---
[2022-10-19T23:28:02Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:28:02Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None
[2022-10-19T23:28:02Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpDGKNSg#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:28:26Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:28:26Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpDGKNSg#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpDGKNSg/incremental-state"
[2022-10-19T23:28:55Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:28:55Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpDGKNSg#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpDGKNSg/incremental-state"
[2022-10-19T23:28:59Z DEBUG collector::execute] applying println to "/tmp/.tmpDGKNSg"
[2022-10-19T23:28:59Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:28:59Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-10-19T23:28:59Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpDGKNSg#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpDGKNSg/incremental-state"
Executing benchmark externs (5/8)
Preparing externs
[2022-10-19T23:29:04Z INFO  collector::execute] run_rustc with incremental=false, profile=Check, scenario=None, patch=None
[2022-10-19T23:29:04Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=None, patch=None
---
[2022-10-19T23:29:07Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:29:07Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None
[2022-10-19T23:29:07Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpJyUNL6#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:29:08Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None
[2022-10-19T23:29:08Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpJyUNL6#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpJyUNL6/incremental-state"
[2022-10-19T23:29:09Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:29:09Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpJyUNL6#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpJyUNL6/incremental-state"
[2022-10-19T23:29:10Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:29:10Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None
[2022-10-19T23:29:10Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpoOfucE#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:29:11Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:29:11Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:29:11Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpoOfucE#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpoOfucE/incremental-state"
[2022-10-19T23:29:12Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:29:12Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpoOfucE#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpoOfucE/incremental-state"
Executing benchmark match-stress (6/8)
Preparing match-stress
[2022-10-19T23:29:13Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=None, patch=None
[2022-10-19T23:29:13Z INFO  collector::execute] run_rustc with incremental=false, profile=Check, scenario=None, patch=None
---
[2022-10-19T23:29:14Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:29:14Z INFO  collector::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None
[2022-10-19T23:29:14Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpr2cGQe#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:29:17Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None
[2022-10-19T23:29:17Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpr2cGQe#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpr2cGQe/incremental-state"
[2022-10-19T23:29:20Z INFO  collector::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:29:20Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpr2cGQe#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpr2cGQe/incremental-state"
[2022-10-19T23:29:22Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:29:22Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None
[2022-10-19T23:29:22Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp3AaSlq#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:29:25Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None
---
[2022-10-19T23:29:43Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:29:43Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None
[2022-10-19T23:29:43Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp3jesRQ#[email protected]" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:29:43Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None
[2022-10-19T23:29:43Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp3jesRQ#[email protected]" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmp3jesRQ/incremental-state"
[2022-10-19T23:29:44Z INFO  collector::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:29:44Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp3jesRQ#[email protected]" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmp3jesRQ/incremental-state"
[2022-10-19T23:29:44Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:29:44Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None
[2022-10-19T23:29:44Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpLKOEWE#[email protected]" "--release" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:29:44Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:29:44Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:29:44Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpLKOEWE#[email protected]" "--release" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpLKOEWE/incremental-state"
[2022-10-19T23:29:45Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:29:45Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpLKOEWE#[email protected]" "--release" "--bin" "token-stream-stress-bin" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpLKOEWE/incremental-state"
Executing benchmark tuple-stress (8/8)
Preparing tuple-stress
[2022-10-19T23:29:45Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=None, patch=None
[2022-10-19T23:29:45Z INFO  collector::execute] run_rustc with incremental=false, profile=Debug, scenario=None, patch=None
---
[2022-10-19T23:30:28Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-10-19T23:30:28Z INFO  collector::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None
[2022-10-19T23:30:28Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpwRCzSQ#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2022-10-19T23:30:34Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None
[2022-10-19T23:30:34Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpwRCzSQ#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpwRCzSQ/incremental-state"
[2022-10-19T23:30:41Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None
[2022-10-19T23:30:41Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpwRCzSQ#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpwRCzSQ/incremental-state"
[2022-10-19T23:30:42Z DEBUG collector::execute] applying new row to "/tmp/.tmpwRCzSQ"
[2022-10-19T23:30:42Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("new row"), path: "0-new-row.patch" })
[2022-10-19T23:30:42Z INFO  collector::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("new row"), path: "0-new-row.patch" })
[2022-10-19T23:30:42Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpwRCzSQ#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=/tmp/.tmpwRCzSQ/incremental-state"
+ cd /checkout/obj
+ RUSTC_PROFILE_MERGED_FILE=/tmp/tmp-pgo/rustc-pgo.profdata
+ /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/bin/llvm-profdata merge -o /tmp/tmp-pgo/rustc-pgo.profdata /tmp/tmp-pgo/rustc-pgo
+ echo 'Rustc PGO statistics'
---
[RUSTC-TIMING] arrayvec test:false 0.341
   Compiling scoped-tls v1.0.0
[RUSTC-TIMING] unic_char_range test:false 0.185
   Compiling unic-common v0.9.0
warning: rustc_graphviz.8b9a8ee2-cgu.6: no profile data available for function _RNvMNtNtNtCs3xitxCrX5zP_4core4iter8adapters3revINtB2_3RevINtNtNtB8_3ops5range5RangejEE3newCs3vPuvVo8KOI_14rustc_graphviz Hash = 742261418966908927 up to 0 count discarded
[RUSTC-TIMING] build_script_build test:false 0.302
   Compiling quote v1.0.18
[RUSTC-TIMING] rustc_arena test:false 0.272
[RUSTC-TIMING] scoped_tls test:false 0.112
---
[RUSTC-TIMING] rustc_parse_format test:false 1.174
   Compiling ansi_term v0.12.1
[RUSTC-TIMING] build_script_build test:false 0.312
   Compiling snap v1.0.1
warning: rustc_serialize.5018bf7b-cgu.13: no profile data available for function _RINvNtCs3xitxCrX5zP_4core3ptr13drop_in_placeRjECshbPUjAbSFDz_15rustc_serialize Hash = 742261418966908927 up to 0 count discarded

warning: rustc_serialize.5018bf7b-cgu.13: no profile data available for function _RINvNtCs3xitxCrX5zP_4core9panicking13assert_failedjjECshbPUjAbSFDz_15rustc_serialize Hash = 742261418966908927 up to 0 count discarded

warning: rustc_serialize.5018bf7b-cgu.3: no profile data available for function _RNvXsV_NtCs3xitxCrX5zP_4core3fmtRjNtB5_5Debug3fmtCshbPUjAbSFDz_15rustc_serialize Hash = 1124680650125156080 up to 0 count discarded
[RUSTC-TIMING] sha1 test:false 0.552
   Compiling crossbeam-channel v0.5.4
[RUSTC-TIMING] thread_local test:false 0.537
   Compiling adler v0.2.3
---
 Documenting rustc_borrowck v0.0.0 (/checkout/compiler/rustc_borrowck)
error: unclosed HTML tag `foo`
  --> compiler/rustc_hir_analysis/src/check/expectation.rs:23:55
   |
23 |     /// Given, for example, if you have let x: &Ty = &<foo>, this
   |
   |
   = note: `-D rustdoc::invalid-html-tags` implied by `-D warnings`
error: unclosed HTML tag `foo`
  --> compiler/rustc_hir_analysis/src/check/expectation.rs:24:48
   |
   |
24 |     /// hint would be given when type-checking <foo>. It is

error: could not document `rustc_hir_analysis`

Caused by:
Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2021 --crate-type lib --crate-name rustc_hir_analysis compiler/rustc_hir_analysis/src/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/doc -Zunstable-options --check-cfg 'values(feature)' --check-cfg 'names()' --check-cfg 'values()' --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat -C metadata=ca2e6047b098073a -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/release/deps --extern rustc_arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_arena-46e5693d0a8f70ca.rmeta --extern rustc_ast=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_ast-2883c936a2417450.rmeta --extern rustc_attr=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_attr-ccfe8913afaaa7d4.rmeta --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-5d52e5ec7b038ef5.rmeta --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-d40626aeaea39bd6.rmeta --extern rustc_feature=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_feature-8326012ca70f28e3.rmeta --extern rustc_graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_graphviz-7c2234d9aef98622.rmeta --extern rustc_hir=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_hir-834d401448bac5ee.rmeta --extern rustc_hir_pretty=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_hir_pretty-117ec9fec429e1f6.rmeta --extern rustc_index=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_index-cffc7ca696d9611b.rmeta --extern rustc_infer=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_infer-a7784f5e1e0f1c20.rmeta --extern rustc_lint=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_lint-ad086e05d7306d7d.rmeta --extern rustc_macros=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/release/deps/librustc_macros-237b9fc0262b4970.so --extern rustc_middle=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_middle-5124de5580560cad.rmeta --extern rustc_serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_serialize-0ac38a19376a0cf6.rmeta --extern rustc_session=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_session-15b0f0b2f4440f63.rmeta --extern rustc_span=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_span-8e453e73a3104eca.rmeta --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-4d2fb6288867b2ab.rmeta --extern rustc_trait_selection=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_trait_selection-3993254b4a39ccb3.rmeta --extern rustc_type_ir=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_type_ir-5c9007912a963257.rmeta --extern smallvec=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/libsmallvec-9a0501c30d2a7b13.rmeta --extern tracing=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-linux-gnu/release/deps/libtracing-00860a8359fd6955.rmeta --extern-html-root-url 'smallvec=https://docs.rs/smallvec/1.8.1/' --extern-html-root-url 'tracing=https://docs.rs/tracing/0.1.35/' -Zunstable-options -Csymbol-mangling-version=v0 -Zunstable-options '--check-cfg=values(bootstrap)' '--check-cfg=values(parallel_compiler)' '--check-cfg=values(no_btreemap_remove_entry)' '--check-cfg=values(crossbeam_loom)' '--check-cfg=values(span_locations)' '--check-cfg=values(rustix_use_libc)' -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,--threads=1 -Dwarnings '-Wrustdoc::invalid_codeblock_attributes' --crate-version '1.66.0-nightly
  (f7637e1d7
  2022-10-19)' --document-private-items '-Arustdoc::private-intra-doc-links' --enable-index-page -Zunstable-options -Znormalize-docs --show-type-layout --generate-link-to-definition --extern-html-root-url 'ena=https://docs.rs/ena/latest/'` (exit status: 1)
[RUSTC-TIMING] rustc_codegen_ssa test:false 3.125
[RUSTC-TIMING] rustc_mir_transform test:false 3.475
[RUSTC-TIMING] rustc_borrowck test:false 4.951
[RUSTC-TIMING] rustc_hir_analysis test:false 10.193

rfcbot · 2022-10-20T07:56:02Z

🔔 This is now entering its final comment period, as per the review above. 🔔

bors · 2022-10-21T12:42:56Z

☔ The latest upstream changes (presumably #103310) made this pull request unmergeable. Please resolve the merge conflicts.

Add tests for autoderef on block tail ref: rust-lang#83850 (comment)

rfcbot · 2022-10-30T08:09:57Z

The final comment period, with a disposition to close, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

rust-highfive assigned petrochenkov Apr 4, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2021

rust-highfive assigned nikomatsakis and unassigned petrochenkov Apr 5, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2021

camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-type-system Area: Type system and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2021

JohnCSimon removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2021

ldm0 force-pushed the nohard branch from 2fe0131 to c1ce8dc Compare October 17, 2022 05:30

Relay deref into block

25845ff

ldm0 force-pushed the nohard branch from c1ce8dc to 25845ff Compare October 19, 2022 16:49

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 19, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-close This PR / issue is in PFCP or FCP with a disposition to close it. labels Oct 19, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2022

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 20, 2022

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2022

Rollup merge of rust-lang#103124 - ldm0:nohard_tests, r=Mark-Simulacrum

3b12086

Add tests for autoderef on block tail ref: rust-lang#83850 (comment)

ldm0 closed this Nov 1, 2022

apiraino removed the to-announce Announce this issue on triage meeting label Jan 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate deref coercion into block #83850

Propagate deref coercion into block #83850

ldm0 commented Apr 4, 2021 •

edited

Loading

rust-highfive commented Apr 4, 2021

petrochenkov commented Apr 5, 2021

eddyb commented Apr 30, 2021

nikomatsakis commented May 13, 2021

lambda-fairy commented Aug 18, 2021

AaronKutch commented Oct 16, 2022 •

edited

Loading

ldm0 commented Oct 17, 2022

jackh726 commented Oct 19, 2022

bors commented Oct 19, 2022

jackh726 commented Oct 19, 2022

jackh726 commented Oct 19, 2022 •

edited

Loading

jackh726 commented Oct 19, 2022

rfcbot commented Oct 19, 2022 •

edited by spastorino

Loading

bors commented Oct 20, 2022

rust-log-analyzer commented Oct 20, 2022

rfcbot commented Oct 20, 2022

bors commented Oct 21, 2022

rfcbot commented Oct 30, 2022

Propagate deref coercion into block #83850

Propagate deref coercion into block #83850

Conversation

ldm0 commented Apr 4, 2021 • edited Loading

rust-highfive commented Apr 4, 2021

petrochenkov commented Apr 5, 2021

eddyb commented Apr 30, 2021

nikomatsakis commented May 13, 2021

lambda-fairy commented Aug 18, 2021

AaronKutch commented Oct 16, 2022 • edited Loading

ldm0 commented Oct 17, 2022

jackh726 commented Oct 19, 2022

bors commented Oct 19, 2022

jackh726 commented Oct 19, 2022

jackh726 commented Oct 19, 2022 • edited Loading

jackh726 commented Oct 19, 2022

rfcbot commented Oct 19, 2022 • edited by spastorino Loading

bors commented Oct 20, 2022

rust-log-analyzer commented Oct 20, 2022

rfcbot commented Oct 20, 2022

bors commented Oct 21, 2022

rfcbot commented Oct 30, 2022

ldm0 commented Apr 4, 2021 •

edited

Loading

AaronKutch commented Oct 16, 2022 •

edited

Loading

jackh726 commented Oct 19, 2022 •

edited

Loading

rfcbot commented Oct 19, 2022 •

edited by spastorino

Loading