Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fp-armv8 for ARM_ALLOWED_FEATURES #83803

Merged
merged 1 commit into from
Apr 4, 2021
Merged

add fp-armv8 for ARM_ALLOWED_FEATURES #83803

merged 1 commit into from
Apr 4, 2021

Conversation

surechen
Copy link
Contributor

@surechen surechen commented Apr 3, 2021

For fixing err in rust-lang/stdarch#1105.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2021
@petrochenkov
Copy link
Contributor

@Amanieu
The analogous feature for aarch64 is called just "fp" and it's translated to "fp-armv8" by fn to_llvm_feature.
I'm not sure whether aarch32 should follow aarch64 here or use the LLVM naming "fp-armv8" directly.

@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021
@Amanieu
Copy link
Member

Amanieu commented Apr 3, 2021

On AArch64, fp-armv8 refers to the entire set of FP instructions. However on ARM, fp-armv8 only refers to the FP instructions that were added in ARMv8, which builds on top of the VFP instructions.

I think it's fine to leave it as fp-armv8 for now. We should definitely revisit the feature names when we eventually get around to stabilizing them.

@petrochenkov
Copy link
Contributor

Ok.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 3, 2021

📌 Commit 944b53e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021
@JohnTitor JohnTitor mentioned this pull request Apr 3, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2021
@bors
Auto merge of rust-lang#83811 - JohnTitor:rollup-hnw1xwz, r=JohnTitor
2616ab1 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#82487 (Constify methods of `std::net::SocketAddr`, `SocketAddrV4` and `SocketAddrV6`)
 - rust-lang#83756 (rustdoc: Rename internal uses of `spotlight`)
 - rust-lang#83780 (Document "standard" conventions for error messages)
 - rust-lang#83787 (Monomorphization doc fix)
 - rust-lang#83803 (add fp-armv8 for ARM_ALLOWED_FEATURES)
 - rust-lang#83804 (Remove nightly features in rustc_type_ir)
 - rust-lang#83810 (Fix rustc_lint_defs documentation typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d0266e3 into rust-lang:master Apr 4, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@surechen @rust-highfive @petrochenkov @Amanieu @bors @rustbot