rustdoc: Rename internal uses of spotlight
#83756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
C-cleanup
|
Some changes occurred in HTML/CSS/JS. |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camelid
added
S-waiting-on-author
|
There are conflicts, but I'll wait to fix them until after #80965 lands. I mainly opened this PR so I don't forget to do the renames :) |
camelid
force-pushed
the
internal-rename-doc-spotlight
branch
from
c086e5c
to
13e8573
Compare
camelid
added
S-waiting-on-review
|
Rebased because #80965 has now merged. Ready for review! |
| @@ -173,13 +173,10 @@ code, pre, a.test-arrow { | |||
| border-radius: 3px; | |||
| padding: 0 0.1em; | |||
| } | |||
| .docblock pre code, .docblock-short pre code, .docblock code.spotlight { | |||
| .docblock pre code, .docblock-short pre code { | |||
There was a problem hiding this comment.
Shouldn't it be:
Suggested change
| .docblock pre code, .docblock-short pre code { | |
| .docblock pre code, .docblock-short pre code, .docblock code.notable { |
?
There was a problem hiding this comment.
See the commit message in 1fe0fe4. The classes appear to be unused.
| padding: 0; | ||
| padding-right: 1ex; | ||
| } | ||
| .docblock code.spotlight :last-child { |
This comment has been minimized.
This comment has been minimized.
I didn't make these renames in rust-lang#80965 because I didn't want the PR to conflict with rust-lang#80914.
I couldn't find any uses of this CSS. I think it was superseded by the `.notable-traits` CSS class and other similarly-named CSS classes.
camelid
force-pushed
the
internal-rename-doc-spotlight
branch
from
13e8573
to
1fe0fe4
Compare
|
You're right: both CSS classes are now unused. Then it's all good for me, thanks! @bors: r+ rollup |
|
📌 Commit 1fe0fe4 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#82487 (Constify methods of `std::net::SocketAddr`, `SocketAddrV4` and `SocketAddrV6`) - rust-lang#83756 (rustdoc: Rename internal uses of `spotlight`) - rust-lang#83780 (Document "standard" conventions for error messages) - rust-lang#83787 (Monomorphization doc fix) - rust-lang#83803 (add fp-armv8 for ARM_ALLOWED_FEATURES) - rust-lang#83804 (Remove nightly features in rustc_type_ir) - rust-lang#83810 (Fix rustc_lint_defs documentation typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't make these renames in #80965 because I didn't want the PR to
conflict with #80914.