Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all submodules that rustbuild doesn't depend on lazily #82653

Merged
merged 1 commit into from
Jul 21, 2021

Commits on Jul 21, 2021

  1. Update all submodules that rustbuild doesn't depend on lazily

    This only updates the submodules the first time they're needed, instead
    of unconditionally the first time you run x.py.
    
    Ideally, this would move *all* submodules and not exclude some tools and
    backtrace. Unfortunately, cargo requires all `Cargo.toml` files in the
    whole workspace to be present to build any crate.
    
    On my machine, this takes the time for an initial submodule clone (for
    `x.py --help`) from 55.70 to 15.87 seconds.
    
    This uses exactly the same logic as the LLVM update used, modulo some
    minor cleanups:
    - Use a local variable for `src.join(relative_path)`
    - Remove unnecessary arrays for `book!` macro and make the macro simpler to use
    - Add more comments
    jyn514 committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2ac0e9b View commit details
    Browse the repository at this point in the history