-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain what ESC does #82522
Explain what ESC does #82522
Conversation
Some changes occurred in HTML/CSS/JS. |
(rust-highfive has picked a reviewer for you, use r? to override) |
0c121bb
to
df0a27e
Compare
src/librustdoc/html/static/main.js
Outdated
@@ -2913,6 +2913,7 @@ function defocusSearchBar() { | |||
["⏎", "Go to active search result"], | |||
["+", "Expand all sections"], | |||
["-", "Collapse all sections"], | |||
["esc", "Close the search view"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does a few other things like:
- Removing the query parameters from the URL (like
?whatever=12
) - Closing the help popup
- Closing the theme list if open
- Blurring the focus from the search input
857cdbd
to
56c5a4e
Compare
56c5a4e
to
16b8057
Compare
21f796a
to
4475900
Compare
4475900
to
f82d9b2
Compare
I'm not a big fan of this listing, even more since I'm sure it might do more things in the future (and I very likely forgot some of them...). However I don't have an idea on how to improve it... Maybe some from @rust-lang/rustdoc has an idea? |
This comment has been minimized.
This comment has been minimized.
2c4714e
to
078c26a
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
I also don't feel this change makes sense. esc here doesn't do anything out of the ordinary; people expect esc to escape from a particular view. If we were using esc like Emacs, as a control key, then I think it should be documented, but none of these seem particularly helpful to document to me. |
@camelid @GuillaumeGomez @jyn514 |
Both arrows definitely do something "out of the ordinary". You don't expect to be able to go through search results by simply pressing up and down arrows from the search input. |
@GuillaumeGomez |
This pull request adds a text to explain what ESC does in doc.
closes #82474