Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand: Do not allocate Lrc for allow_internal_unstable list unless necessary #82422

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Feb 22, 2021

This allocation is done for any macro defined in the current crate, or used from a different crate.
EDIT: This also removes an Lrc increment from each use of such macro, which may be more significant.
Noticed when reviewing #82367.
This probably doesn't matter, but let's do a perf run.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2021
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 22, 2021
@bors
Copy link
Contributor

bors commented Feb 22, 2021

⌛ Trying commit ddd20ef with merge b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b...

@bors
Copy link
Contributor

bors commented Feb 22, 2021

☀️ Try build successful - checks-actions
Build commit: b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b (b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b)

@rust-timer
Copy link
Collaborator

Queued b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b with parent a15f484, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Feb 23, 2021

not sure what happened there, but it doesn't load for me

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2021
@bors
Copy link
Contributor

bors commented Feb 23, 2021

⌛ Trying commit ddd20ef with merge cc15dd65555849005539c1d2776c6efedafe1eba...

@petrochenkov
Copy link
Contributor Author

not sure what happened there, but it doesn't load for me

Something is wrong with perf.rust-lang, it opened a few hours before but doesn't open now.

@bors
Copy link
Contributor

bors commented Feb 23, 2021

☀️ Try build successful - checks-actions
Build commit: cc15dd65555849005539c1d2776c6efedafe1eba (cc15dd65555849005539c1d2776c6efedafe1eba)

@rust-timer
Copy link
Collaborator

Queued cc15dd65555849005539c1d2776c6efedafe1eba with parent cd64446, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (cc15dd65555849005539c1d2776c6efedafe1eba): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2021
@Mark-Simulacrum
Copy link
Member

(We're still collecting data for the parent of the new one; we missed it finishing - but the previous one should work now)

@petrochenkov
Copy link
Contributor Author

ping @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Mar 12, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Mar 12, 2021

📌 Commit ddd20ef has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2021
@bors
Copy link
Contributor

bors commented Mar 12, 2021

⌛ Testing commit ddd20ef with merge 338647d...

@bors
Copy link
Contributor

bors commented Mar 12, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 338647d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2021
@bors bors merged commit 338647d into rust-lang:master Mar 12, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants