-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand: Do not allocate Lrc
for allow_internal_unstable
list unless necessary
#82422
Conversation
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ddd20ef with merge b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b... |
☀️ Try build successful - checks-actions |
Queued b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b with parent a15f484, future comparison URL. |
Finished benchmarking try commit (b67a0b457b5d4e5e39081e28e8b3ad4e92da8d7b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
not sure what happened there, but it doesn't load for me @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ddd20ef with merge cc15dd65555849005539c1d2776c6efedafe1eba... |
Something is wrong with perf.rust-lang, it opened a few hours before but doesn't open now. |
☀️ Try build successful - checks-actions |
Queued cc15dd65555849005539c1d2776c6efedafe1eba with parent cd64446, future comparison URL. |
Finished benchmarking try commit (cc15dd65555849005539c1d2776c6efedafe1eba): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
(We're still collecting data for the parent of the new one; we missed it finishing - but the previous one should work now) |
ping @oli-obk |
@bors r+ |
📌 Commit ddd20ef has been approved by |
☀️ Test successful - checks-actions |
This allocation is done for any macro defined in the current crate, or used from a different crate.
EDIT: This also removes an
Lrc
increment from each use of such macro, which may be more significant.Noticed when reviewing #82367.
This probably doesn't matter, but let's do a perf run.