Feature-gate pointer and reference in intra-doc links
#81015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
T-rustdoc
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
feature-gate-ptr
branch
from
f9b6c69
to
2161012
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
feature-gate-ptr
branch
from
2161012
to
45e7a7a
Compare
This comment has been minimized.
This comment has been minimized.
camelid
reviewed
Jan 14, 2021
camelid
reviewed
Jan 14, 2021
jyn514
force-pushed
the
feature-gate-ptr
branch
from
4f43693
to
fc25597
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
feature-gate-ptr
branch
from
fc25597
to
2671365
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
feature-gate-ptr
branch
from
2671365
to
a17842d
Compare
camelid
reviewed
Jan 15, 2021
src/doc/unstable-book/src/language-features/intra-doc-pointers.md
Outdated
Show resolved
Hide resolved
camelid
reviewed
Jan 15, 2021
jyn514
force-pushed
the
feature-gate-ptr
branch
from
05d7fb5
to
1c44f0e
Compare
|
FYI, you accidentally committed some submodules :) |
|
Thanks, fixed. |
jyn514
force-pushed
the
feature-gate-ptr
branch
from
1c44f0e
to
54a81fe
Compare
This comment has been minimized.
This comment has been minimized.
- Only feature gate associated items - Add docs to unstable book
jyn514
force-pushed
the
feature-gate-ptr
branch
from
54a81fe
to
fc53594
Compare
|
@camelid did you have other concerns for me to address? |
|
I see that you had to adjust tidy so it checks |
|
Thanks! @bors r=camelid |
|
📌 Commit fc53594 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jan 18, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @camelid
Addresses (but does not close) #80896.