Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #79138

Merged
merged 25 commits into from
Nov 17, 2020
Merged

Rollup of 8 pull requests #79138

merged 25 commits into from
Nov 17, 2020

Commits on Nov 3, 2020

  1. [self-profiling] Include the estimated size of each cgu in the profile

    This is helpful when looking for CGUs where the size estimate isn't a
    good indicator of compilation time.
    
    I verified that moving the profiling timer call doesn't affect the
    results.
    wesleywiser committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    efe703a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2020

  1. Get rid of Class::None

    This is mostly me learning the codebase, so feel free to close the PR.
    It does have the small benefit that we statically know rustdoc isn't
    generating useless `span`s, though.
    jyn514 committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    279bf29 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Configuration menu
    Copy the full SHA
    74d5466 View commit details
    Browse the repository at this point in the history
  2. Get rid of clean::TyMethod

    It's the same as clean::Function.
    jyn514 committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    b3f9795 View commit details
    Browse the repository at this point in the history
  3. Get rid of clean::Method

    Replace it instead with `(clean::Function, Option<hir::Defaultness>)`.
    jyn514 committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    2a991e1 View commit details
    Browse the repository at this point in the history
  4. Remove duplicate Trait::auto field

    It was exactly the same as `is_auto`.
    jyn514 committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    5903163 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a1cdf72 View commit details
    Browse the repository at this point in the history
  6. extend macro braces test

    lcnr committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    5f2a627 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    96a6a5f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    54e8216 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    57bab5e View commit details
    Browse the repository at this point in the history
  10. Update lock file

    GuillaumeGomez committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    704001b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    32d64ed View commit details
    Browse the repository at this point in the history
  12. Update doctest tests

    GuillaumeGomez committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    fd4a33c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    95ee1fc View commit details
    Browse the repository at this point in the history
  14. Add comment explaining why we can't split on error[{}]: because of…

    … the color escape characters
    GuillaumeGomez committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    63785c8 View commit details
    Browse the repository at this point in the history
  15. Remove unused import

    GuillaumeGomez committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ec10824 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#74293 - GuillaumeGomez:rustdoc-test-compile…

    …r-output-color, r=jyn514
    
    Rustdoc test compiler output color
    
    Fixes rust-lang#72915
    
    We just need to be sure it doesn't break rustdoc doctests' compilation checks. Maybe some other unforeseen consequences too?
    
    r? `@ehuss`
    cc `@rust-lang/rustdoc`
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    81f9feb View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#78702 - wesleywiser:self_profile_cgu_sizes,…

    … r=Mark-Simulacrum
    
    [self-profiling] Include the estimated size of each cgu in the profile
    
    This is helpful when looking for CGUs where the size estimate isn't a
    good indicator of compilation time.
    
    I verified that moving the profiling timer call doesn't affect the
    results.
    
    Results:
    
    <img width="297" alt="Screen Shot 2020-11-03 at 7 25 04 AM" src="https://user-images.githubusercontent.com/831192/97985503-5901d100-1da6-11eb-9f10-f3e399702952.png">
    
    `measureme` doesn't have support for custom arg names yet so `arg0` is the CGU name and `arg1` is the estimated size.
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    fa45fce View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#79069 - jyn514:class-none, r=GuillaumeGomez

    Get rid of `highlight::Class::None`
    
    This is mostly me learning the codebase for rust-lang#77939, so feel free to close the PR.
    It does have the small benefit that we statically know rustdoc isn't generating useless `span`s, though.
    
    r? `@GuillaumeGomez`
    cc `@matklad`
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    dda4798 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#79072 - oli-obk:byte_str_pat, r=estebank

    Fix exhaustiveness in case a byte string literal is used at slice type
    
    fixes rust-lang#79048
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    b6f5241 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#79120 - calebcartwright:update-rustfmt, r=M…

    …ark-Simulacrum
    
    update rustfmt to v1.4.27
    
    Fixes rust-lang/rustfmt#4528
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    53ddb73 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#79125 - jyn514:fewer-types, r=GuillaumeGomez

    Get rid of clean::{Method, TyMethod}
    
    They're redundant and almost the same as `clean::Function`.
    
    I needed this for rust-lang#78082, although I forget why.
    
    r? `@GuillaumeGomez`
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    3d63f25 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#79126 - jyn514:auto, r=GuillaumeGomez

    Remove duplicate `Trait::auto` field
    
    It was exactly the same as `is_auto`.
    
    I found this while working on rust-lang#78082, but it's not required for that PR.
    
    r? `@GuillaumeGomez`
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ca38bd4 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#79130 - lcnr:extend-tes, r=varkor

    extend macro braces test
    
    r? `@varkor`
    m-ou-se authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    f698505 View commit details
    Browse the repository at this point in the history