Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustdoc warnings about invalid Rust syntax #77559

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Fix rustdoc warnings about invalid Rust syntax #77559

merged 2 commits into from
Oct 6, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 5, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2020
@camelid camelid added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Oct 5, 2020
@camelid camelid force-pushed the fix-rustdoc-warnings-invalid-rust-syntax branch from 9bd032b to c877ff3 Compare October 5, 2020 02:36
@jyn514 jyn514 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Oct 5, 2020
lcnr
lcnr approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits, otherwise lgtm

@camelid
Copy link
Member Author

camelid commented Oct 5, 2020

@lcnr I addressed your comments in c8d25af. (I made a new commit so you can easily see the changes, but I can squash once you've reviewed.)

@lcnr
Copy link
Contributor

lcnr commented Oct 5, 2020

lgtm. Thanks

r? @lcnr
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 5, 2020

📌 Commit c8d25af has been approved by lcnr

@rust-highfive rust-highfive assigned lcnr and unassigned varkor Oct 5, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 6, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2020
@bors
Auto merge of rust-lang#77606 - JohnTitor:rollup-7rgahdt, r=JohnTitor
5ded394 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#76388 (Add a note about the panic behavior of math operations on time objects)
 - rust-lang#76855 (Revamp rustdoc docs about documentation using `cfg`)
 - rust-lang#76995 (Reduce boilerplate with the matches! macro)
 - rust-lang#77228 (Add missing examples for MaybeUninit)
 - rust-lang#77528 (Avoid unchecked casts in net parser)
 - rust-lang#77534 (Disallow overriding forbid in same scope)
 - rust-lang#77555 (Allow anyone to set regression labels)
 - rust-lang#77558 (Rename bootstrap/defaults/{config.toml.PROFILE => config.PROFILE.toml})
 - rust-lang#77559 (Fix rustdoc warnings about invalid Rust syntax)
 - rust-lang#77560 (Fix LitKind's byte buffer to use refcounted slice)
 - rust-lang#77573 (Hint doc use convert::identity relative link)
 - rust-lang#77587 (Fix span for unicode escape suggestion.)
 - rust-lang#77591 (Record `expansion_that_defined` into crate metadata)

Failed merges:

r? `@ghost`
@bors bors merged commit 2970af8 into rust-lang:master Oct 6, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 6, 2020
@camelid camelid deleted the fix-rustdoc-warnings-invalid-rust-syntax branch October 6, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr approved these changes

@jyn514 jyn514 jyn514 left review comments

Assignees

@lcnr lcnr

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
7 participants
@camelid @rust-highfive @lcnr @bors @jyn514 @varkor @rustbot