Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Zprecise-enum-drop-elaboration #77423

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Add -Zprecise-enum-drop-elaboration #77423

merged 1 commit into from
Oct 2, 2020

Conversation

ecstatic-morse
Copy link
Contributor

Its purpose is to assist in debugging #77382 and #74551. Passing -Zprecise-enum-drop-elaboration=no will turn off the added precision that seems to be causing issues on some platforms. This assumes that we can reproduce #77382 on the latest master. I should have done this earlier. Oh well.

cc @cuviper
r? @pnkfelix

@ecstatic-morse
Add -Zprecise-enum-drop-elaboration
6691d11 
Its purpose is to assist in debugging rust-lang#77382 and rust-lang#74551.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2020
@camelid camelid added the A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html label Oct 1, 2020
@cuviper
Copy link
Member

cuviper commented Oct 2, 2020 •
edited
Loading

This assumes that we can reproduce #77382 on the latest master.

I was still able to reproduce with nightly-2020-09-30, at least. However, I just did my own master build with rust debug-assertions and llvm assertions enabled, hoping to get a hit, but that test passed. I'm trying again with debug-assertions-std disabled, so hopefully that will un-perturb the test to reproduce the crash again.

Once I find a reliable build config to reproduce on master, I'll try with your changes here.

@pnkfelix
Copy link
Member

pnkfelix commented Oct 2, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 2, 2020

📌 Commit 6691d11 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 2, 2020
Merged
@cuviper
Copy link
Member

cuviper commented Oct 2, 2020

Passing -Zprecise-enum-drop-elaboration=no will turn off the added precision that seems to be causing issues on some platforms. This assumes that we can reproduce #77382 on the latest master.

I reproduced it on master, and I can also reproduce it on this branch with the given flag to disable. I even made sure to set RUSTFLAGS_NO_BOOTSTRAP=-Z... so std should have that flag as well.

@cuviper cuviper mentioned this pull request Oct 2, 2020
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2020
@bors
Auto merge of rust-lang#77462 - jonas-schievink:rollup-m0rqdh5, r=jon…
8876ffc 
…as-schievink

Rollup of 12 pull requests

Successful merges:

 - rust-lang#76101 (Update RELEASES.md for 1.47.0)
 - rust-lang#76739 (resolve: prohibit anon const non-static lifetimes)
 - rust-lang#76811 (Doc alias name restriction)
 - rust-lang#77405 (Add tracking issue of iter_advance_by feature)
 - rust-lang#77409 (Add example for iter chain struct)
 - rust-lang#77415 (Better error message for `async` blocks in a const-context)
 - rust-lang#77423 (Add `-Zprecise-enum-drop-elaboration`)
 - rust-lang#77432 (Use posix_spawn on musl targets)
 - rust-lang#77441 (Fix AVR stack corruption bug)
 - rust-lang#77442 (Clean up on example doc fixes for ptr::copy)
 - rust-lang#77444 (Fix span for incorrect pattern field and add label)
 - rust-lang#77453 (Stop running macOS builds on Azure Pipelines)

Failed merges:

r? `@ghost`
@bors bors merged commit 1e3c7e2 into rust-lang:master Oct 2, 2020
@rustbot rustbot added this to the 1.48.0 milestone Oct 2, 2020
This was referenced Oct 3, 2020
Closed
Open
@ecstatic-morse ecstatic-morse deleted the discriminant-switch-effect-config branch October 6, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ecstatic-morse @cuviper @pnkfelix @bors @rust-highfive @camelid @rustbot