expand: Stop normalizing NtIdents before passing them to built-in macros
#77275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 3b27799 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 28, 2020
expand: Stop normalizing `NtIdent`s before passing them to built-in macros Built-in macros should be able to deal with `NtIdents` in the input by themselves like any other parser code. You can't imagine how bad mutable AST visitors are, *especially* if they are modifying tokens. This is one step towards removing token visiting from the visitor infrastructure (rust-lang#77271 also works in this direction.)
|
I think this broke the @bors r- rollup=iffy |
bors
added
S-waiting-on-author
|
Yep, this PR is to blame. |
…-in macros This was a big hack, and built-in macros should be able to deal with `NtIdents` in the input by themselves like any other parser code.
petrochenkov
force-pushed
the
interpid
branch
from
3b27799
to
4a4a7f8
Compare
|
@bors r=varkor |
|
📌 Commit 4a4a7f8 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 4a4a7f8 with merge a0aa59c155b4edde00742e095cdfb552cdf200f9... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built-in macros should be able to deal with
NtIdentsin the input by themselves like any other parser code.You can't imagine how bad mutable AST visitors are, especially if they are modifying tokens.
This is one step towards removing token visiting from the visitor infrastructure (#77271 also works in this direction.)