Rollup of 16 pull requests #76045

Renamed remaining references to "undef" to "uninit" when referring to Miri. Impacted directories are: - src/librustc_codegen_llvm/consts.rs - src/librustc_middle/mir/interpret/ - src/librustc_middle/ty/print/pretty.rs - src/librustc_mir/ - src/tools/clippy/clippy_lints/src/consts.rs Upon building Miri based on the new changes it was verified that no changes needed to be made with the Miri project. Related issue rust-lang#71193

Fixes rust-lang#214

Miri: Renamed "undef" to "uninit" Renamed remaining references to "undef" to "uninit" when referring to Miri. Impacted directories are: - `src/librustc_codegen_llvm/consts.rs` - `src/librustc_middle/mir/interpret/` - `src/librustc_middle/ty/print/pretty.rs` - `src/librustc_mir/` - `src/tools/clippy/clippy_lints/src/consts.rs` Upon building Miri based on the new changes it was verified that no changes needed to be made with the Miri project. Related issue rust-lang#71193

…a method.

unnecessary-mut-passed: make lint message say if fn is a function or a method changelog: refine "unnecessary-mut-passed" lint message

@Manishearth

Update Clippy Biweekly Clippy update (2 days late, since I wanted to wait for rust-lang#75098) r? @Manishearth

Co-authored-by: Philipp Krones <[email protected]>

@ghost

Rustup r? @ghost changelog: none

Add example of false positive to PTR_ARG docs. Addresses rust-lang#214 changelog: Add example of false positive to `ptr_arg` docs.

In rust-lang#2268 I idly mused that the other user-overloadable operations could be added to this lint. Knowing that the lint was arguably incomplete was gnawing at the back of my mind, so I figured that I might as well make this PR, particularly given the change needed was so small.

Should have actually ran rustfmt on it, rather than attempting to fix it manually

@yaahc

fix remaining lint messages r? @yaahc changelog: make remaining lint messages adhere to rustc dev guide lint message convention.

…pl.rs'

Add the other overloadable operations to suspicious_arithmetic_impl In rust-lang#2268 I idly mused that the other user-overloadable operations could be added to this lint. Knowing that the lint was arguably incomplete was gnawing at the back of my mind, so I figured that I might as well make this PR, particularly given the change needed was so small. changelog: Start warning on suspicious implementations of the `BitAnd`, `BitOr`, `BitXor`, `Rem`, `Shl`, and `Shr` traits.

write.rs: don't clone TokenStream changelog: none

…phansch Fix: keep parenthesis for suggestion in `useless_conversion` lint Note: this lint was previously named `identity_conversion`. fixes: rust-lang#4750 changelog: fix parenthesis for `useless_conversion` lint suggestion

Change Rc<Box<T>> recommendation to be Rc<T> instead of Box<T> Fixes rust-lang#5722 changelog: Suggest `Rc<Box<T>>` -> `Rc<T>` in [`redundant_allocation`] lint

…uide, r=matthiaskrgr Add reference to rustc-dev-guide about lint message I think it would be better to add lint message convention to documentation. I referred to rust-lang/rust-clippy#5888 and rust-lang/rust-clippy#5893. changelog: none

docs: typo in `temporary_cstring_as_ptr`: s/point/&s changelog: none

Fixes: rust-lang#5847

Don't emit a lint when `pushed_item` was declared as mutable variable.

Fixes rust-lang#5875

@ghost

Rustup r? @ghost changelog: none

@llogiq

…nts, r=Manishearth,flip1995 Parse doctests in needless_doctest_main This switches from text-based search to running the parser to avoid false positives. Inspired by how [rustdoc](https://github.com/rust-lang/rust/blob/3f3250500fe152b5759c21453ba9a9129808d0d8/src/librustdoc/test.rs#L366) handles this and by rust-lang#4729. cc @llogiq changelog: Fix multiple false positives in [`needless_doctest_main`]. Fixes rust-lang#5879 Fixes rust-lang#4906 Fixes rust-lang#5103 Fixes rust-lang#4698

Don't use `to_string` in impl Display fixes rust-lang#3876 this PR is derived from [Toxyxer's implementation](rust-lang/rust-clippy#5574). changelog: add [`to_string_in_display`] lint

…=ebroto,flip1995 Lint `push_str` with a single-character string literal Fixes rust-lang#5875 changelog: `* [single_char_push_str]`

Needless return Fixes rust-lang#5858 changelog: fix false positive [`needless_return`]

…=flip1995 appreciative too_large_for_stack in useless `vec!` Fixes: rust-lang#5847 changelog: Add `too_large_for_stack ` configuration option for `USELESS_VEC`

should_impl_trait - ignore methods with lifetime params Fixes: rust-lang#5617 changelog: don't lint should_implement_trait when an `Iterator::next` case has explicit parameters

…et linted

Co-authored-by: Philipp Krones <[email protected]>

Fix typo in description of unnecessary_mut_passed changelog: Correct "immutable reference" to "mutable reference" in description of `unnecessary_mut_passed`

Add unnecessary lazy evaluation lint changelog: Add [`unnecessary_lazy_evaluations`] lint that checks for usages of `unwrap_or_else` and similar functions that can be simplified. Closes rust-lang#5715

Introduce `eq_expr_value(cx, a, b)` as a shortcut for `SpanlessEq::new(cx).ignore_fn().eq_expr(cx, a, b)`. No functional changes intended.

No functional changes intended.

Warn about assignments where left-hand side place expression is the same as right-hand side value expression. For example, warn about assignment in: ```rust pub struct Event { id: usize, x: i32, y: i32, } pub fn copy_position(a: &mut Event, b: &Event) { a.x = b.x; a.y = a.y; } ```

Warn about explicit self-assignment Warn about assignments where left-hand side place expression is the same as right-hand side value expression. For example, warn about assignment in: ```rust pub struct Event { id: usize, x: i32, y: i32, } pub fn copy_position(a: &mut Event, b: &Event) { a.x = b.x; a.y = a.y; } ``` changelog: New lint `self_assignment`, checks for explicit self-assignments.

cargo_metadata 0.9.1 -> 0.11.1 semver 0.9.0 -> 0.10.0

deps: bump cargo_metadata and semver cargo_metadata 0.9.1 -> 0.11.1 semver 0.9.0 -> 0.10.0 changelog: none

This commit updates clippy with the introduction of `QPath::LangItem` so that it still compiles. Signed-off-by: David Wood <[email protected]>

…=flip1995 Fix FP for `same_item_push` Fixes rust-lang/rust-clippy#5902 changelog: Fix FP for `same_item_push` where the pushed variable is mutated.

@Dylan-DPC

rust_ast::ast => rustc_ast Rework of rust-lang#71199 which is a rework rust-lang#70621 Still working on this but just made the PR to track progress r? @Dylan-DPC

@ghost

Rustup r? @ghost changelog: none

Extend the lint to handle chains of methods combined with unary negation. Closes rust-lang#5924

This extends PR rust-lang#73293 to handle patterns (Pat). Unlike expressions, patterns do not support custom attributes, so we only need to capture tokens during macro_rules! argument parsing.

…hiaskrgr transmute: avoid suggesting from/to bits in const changelog: Avoid suggesting from/to bits in const contexts in [`transmute_int_to_float`] Fixes rust-lang#5747

Fix false positive in `PRECEDENCE` lint Extend the lint to handle chains of methods combined with unary negation. Closes rust-lang#5924 changelog: Fix false negative in `PRECEDENCE` lint

@ghost

Rustup r? @ghost changelog: none

Fix false negative in `option_as_ref_deref` Closes rust-lang#5927 changelog: Fix false negative in `option_as_ref_deref`

…tring_in_display, r=yaahc Improve lint message in `to_string_in_display` This is a follow-up of rust-lang/rust-clippy#5831. changelog: none

@ebroto

Add async test case for FP in `wrong_self_convention` lint Closes: rust-lang#4037 changelog: none r? @ebroto

Prelude imports are exempt from wildcard import warnings. Until now only imports of the form ``` use ...::prelude::*; ``` were considered. This change makes it so that the segment `prelude` can show up anywhere, for instance: ``` use ...::prelude::v1::*; ``` Fixes rust-lang#5917

Widen understanding of prelude import Prelude imports are exempt from wildcard import warnings. Until now only imports of the form ``` use ...::prelude::*; ``` were considered. This change makes it so that the segment `prelude` can show up anywhere, for instance: ``` use ...::prelude::v1::*; ``` Fixes rust-lang#5917 changelog: Allow `prelude` to appear in any segment of the import path in [`wildcard_imports`]

Don't lint if it has always inline attribute Don't trigger the lint `trivially_copy_pass_by_ref` if it has `#[inline(always)]` attribute. Note: I am not particularly familiar with `inline` impacts, so I implemented this the way that if only `#[inline]` attribute is here (without `always`), the lint will still trigger. Also, it will still trigger if it has `#[inline(never)]`. Just tell me if it sounds too much conservative. Fixes: rust-lang#5876 changelog: none

Add a cast to the suggestion when the return expression has adjustments. These adjustments are lost when the suggestion is applied. This is similar to the problem in issue rust-lang#4437. Closes rust-lang#5729

Fix false positive when referencing a field behind a pointer.

Fix cargo dev new_lint for late lint passes Since rust-lang/rust-clippy@30c046e, `LateLintPass` has only one lifetime parameter. I'm not sure how to easily test this, I think adding this kind of tests would be probably part of rust-lang#5394 changelog: none

Fix ICE in `repeat_once` changelog: Fix ICE in [`repeat_once`] Fixes rust-lang#5944

Visit the nested things like function body when checking closure call.

Co-authored-by: Thibaud <[email protected]>

Fixes a false positive for transparent newtype with a non-zero member.

…t message

…flip1995 stable_sort_primitive: print the type that is being sorted in the lint message changelog: stable_sort_primitive: print the type that is being sorted in the lint message

…_call, r=mikerite Fix FP for `redundant_closure_call` Fix rust-lang#5916 changelog: Fix FP for `redundant_closure_call` when called in function body

The fmt test will cause clippy dev to be compiled and run. The clippy dev dependencies are currently stored at `target/debug/deps` when this happens. This location sometimes causes conflicts with ui tests which result in the build error "thread 'compile_test' panicked at 'Found multiple rlibs for crate `regex` ...". This commit forces the clippy_dev dependencies to be stored under `clippy_dev/target/` which seems to resolve this problem.

Co-authored-by: Bastian Kauschke <[email protected]>

@ghost

Rustup r? @ghost changelog: none

@flip1995

…1995 Improve documentation related to the sync process [Rendered](https://github.com/ebroto/rust-clippy/blob/rustup_doc_improvements/CONTRIBUTING.md) r? @flip1995 changelog: none

Added a lint which corrects expressions like (a - b) < f32::EPSILON, according to rust-lang#5819 Fixes rust-lang#5819 changelog: none

Various fmt test improvements Various fmt test improvements. changelog: none

Re-enable len_zero for ranges now that `is_empty` is stable on them Fixes rust-lang#5956 Completed stabilization PR: rust-lang#75132 changelog: len_zero: re-enable linting ranges now that range_is_empty is stable

Co-authored-by: Eduardo Broto <[email protected]>

- Give a suggestion even if there is no span available - Give a more accurate description of the change than 'use the disambiguator' - Write much less code

@ebroto

…roto Fix incorrect suggestion when `clone_on_ref_ptr` is triggered in macros In the lint `clone_on_ref_ptr`, if the `span` is in a macro, don't expand it for suggestion. Fixes: rust-lang#2076 changelog: none r? @ebroto

Co-authored-by: Ivan Tham <[email protected]>

Fix typo changelog: none

…le_const, r=oli-obk Fix fp in `borrow_interior_mutable_const` fixes rust-lang#5796 changelog: fix false positive in `borrow_interior_mutable_const` when referencing a field behind a pointer.

Fix `let_and_return` bad suggestion Add a cast to the suggestion when the return expression has adjustments. These adjustments are lost when the suggestion is applied. This is similar to the problem in issue rust-lang#4437. Closes rust-lang#5729 changelog: Fix `let_and_return` bad suggestion

…ion is assembled

@flip1995

Corrects the float_equality_without_abs lint Fixes an issue in the `float_equality_without_abs` lint. The lint suggestion was configured in a way that it lints the whole error and not just the subtraction part. In the current configuration the lint would suggest to change the expression in a wrong way, e.g. ```rust let _ = (a - b) < f32::EPSILON; // before let _ = (a - b).abs(); // after ``` This was dicovered by @flip1995. (See discussion of PR rust-lang#5952). Also the suggestion is now formatted via `utils::sugg`. changelog: none

Ninja substantially improves LLVM build time. On a 96-way system, using Make took 248s, and using Ninja took 161s, a 35% improvement. We already require a variety of tools to build Rust. If someone wants to build without Ninja (for instance, to minimize the set of packages required to bootstrap a new target), they can easily set `ninja=false` in `config.toml`. Our defaults should help people build Rust (and LLVM) faster, to speed up development.

Should be re-enabled when we have a recipe for installing ninja on macOS.

Windows CI builds already install ninja. Install it in all the Docker-based builds as well.

Let people know that they can set ninja=false if they don't want to install ninja.

This includes a workaround of the issue rust-lang#5822, the cause of this little mistake.

…bility, r=flip1995 Fix the wrong use of `snippet_with_applicability` For the context, please see rust-lang/rust-clippy#5822 (comment) and rust-lang/rust-clippy#5822 (comment). --- changelog: none

… r=yaahc Adding new lint to prevent usage of 'unwrap' inside functions that re… ### Change Adding a new lint that will emit a warning when using "unwrap" or "expect" inside a function that returns result. ### Motivation These functions promote recoverable errors to non-recoverable errors which may be undesirable in code bases which wish to avoid panics. ### Test plan Running: `TESTNAME=unwrap_in_result cargo uitest `--- changelog: none

Don't emit a lint when `.to_string()` on anything that is not `self`

…ay, r=ebroto Fix FP in `to_string_in_display` Don't emit a lint when `.to_string()` on anything that is not `self` Fix rust-lang#5967 changelog: Fix FP in `to_string_in_display` when calling `.to_string()` on anything that is not `self`

Fixes rust-lang#57820 and rust-lang#46651

Co-authored-by: Eduardo Broto <[email protected]>

Fix FP in `new_ret_no_self`: trigger in trait def instead of impl block Lint in trait def instead of impl block. Fixes: rust-lang#5435 changelog: none

…rk-Simulacrum Set ninja=true by default Ninja substantially improves LLVM build time. On a 96-way system, using Make took 248s, and using Ninja took 161s, a 35% improvement. We already require a variety of tools to build Rust. If someone wants to build without Ninja (for instance, to minimize the set of packages required to bootstrap a new target), they can easily set `ninja=false` in `config.toml`. Our defaults should help people build Rust (and LLVM) faster, to speed up development.

@rustbot

Switch to intra-doc links in `core::hash` Part of rust-lang#75080. @rustbot modify labels: A-intra-doc-links T-doc T-rustdoc

@jyn514

Shorten liballoc doc intra link while readable r? @jyn514 Do you want to reviews these sort of pull requests in the future? I might send a few of them while reading vec code.

Update compiler-builtins Update the compiler-builtins dependency to include latest changes. This allows for `aarch64-unknown-linux-musl` to pass all tests. Fixes rust-lang#57820 and fixes rust-lang#46651

@GuillaumeGomez

Expand rustdoc theme chooser x padding ![image](https://user-images.githubusercontent.com/4687791/91057476-d0eea500-e659-11ea-8c9a-e44db937da89.png) ![image](https://user-images.githubusercontent.com/4687791/91057530-e368de80-e659-11ea-9298-fbb00006d91f.png) But I still think there is room for improvement considering mdbook. ![image](https://user-images.githubusercontent.com/4687791/91057583-f7acdb80-e659-11ea-9dc5-317caed92bc5.png) CC @GuillaumeGomez @jyn514

@lcnr

…declarations-transparent-nonzero, r=lcnr Fix another clashing_extern_declarations false positive. Fixes rust-lang#75739. Fix another clashing_extern_declarations false positive, this time for transparent newtype with a non-zero member. r? @lcnr

…_typo, r=petrochenkov Fix typo in TLS Model in Unstable Book

@pickfire

…er-background-color, r=pickfire Improve theme button hover background color Fixes rust-lang#75880. ![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png) ![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png) r? @pickfire

Add test for issue rust-lang#27130 rust-lang#27130 seems to be fixed by the llvm 11 update. The issue is marked with needs-test, so here it is. As some historical context, the generated code was fine until 1.38, and remained unoptimized from 1.38 up until the current nightly. I've also added a pattern matching version that was fine on 1.45.2.

@euclio

Unify error reporting for intra-doc links - Give a suggestion even if there is no span available - Give a more accurate description of the change than 'use the disambiguator' - Write much less code Closes rust-lang#75836. r? @euclio cc @pickfire - this gets rid of 'disambiguator' like you suggested in rust-lang#75079 (comment).

Fix a typo in rust-lang#75781

@estebank

Should not apply field accessing on enum Closes rust-lang#75977 But I'm surprised that `x.py test --stage 1` and CI didn't catch this with existing testcase. r? @estebank

Add __fastfail for Windows on arm/aarch64 Fixes rust-lang#73215

…acrum Fix loading pretty-printers in rust-lldb script Pretty-printers loading in `rust-lldb` script was broken in rust-lang#72357 This fixes rust-lang#76006

@ghost

bump Miri Fixes rust-lang#75970 Cc @rust-lang/miri r? @ghost

@Manishearth

Update Clippy Bi-weekly Clippy update, as per the [new policy](https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md#syncing-back-changes-in-clippy-to-rust-langrust). r? @Manishearth

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 16 pull requests #76045

Rollup of 16 pull requests #76045

Commits on Aug 8, 2020

Commits on Aug 9, 2020

Commits on Aug 10, 2020

Commits on Aug 11, 2020

Commits on Aug 12, 2020

Commits on Aug 13, 2020

Commits on Aug 14, 2020

Commits on Aug 15, 2020

Commits on Aug 16, 2020

Commits on Aug 17, 2020

Commits on Aug 18, 2020

Commits on Aug 19, 2020

Commits on Aug 20, 2020

Commits on Aug 21, 2020

Commits on Aug 22, 2020

Commits on Aug 23, 2020

Commits on Aug 24, 2020

Commits on Aug 25, 2020

Commits on Aug 26, 2020

Commits on Aug 27, 2020

Commits on Aug 28, 2020

Commits on Aug 29, 2020