-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reallocation to different alignment in AllocRef
#75687
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 438c40e with merge 0b22c8a0d3ea0197f040b0d363462264e8646d10... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 0b22c8a0d3ea0197f040b0d363462264e8646d10 with parent e7f6ed1, future comparison URL. |
Finished benchmarking try commit (0b22c8a0d3ea0197f040b0d363462264e8646d10): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
That's an interesting report. The regression mainly occured in doc-runs (1.2% to 0.7%). Then almost only check-, doc-, and debug-runs betwee 0.5% and 0.1%). opt-runs are not affected. Mainly the regression will come from optimizing out the third match arm in I think the stats are looking fine 🙂 |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 46b547c with merge e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca... |
☀️ Try build successful - checks-actions, checks-azure |
Queued e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca with parent 1a22a0f, future comparison URL. |
Finished benchmarking try commit (e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Wow, didn't expected that! Nice observation. |
@bors r+ |
📌 Commit 46b547c has been approved by |
⌛ Testing commit 46b547c with merge 79e6f4f5d592f9c34349ef841f802b473060eb84... |
💔 Test failed - checks-actions |
We just entered the beta week. |
No Breakage Week is over, let's merge this. 🙂 |
@bors retry |
☀️ Test successful - checks-actions, checks-azure |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@rust-lang/infra something odd happened here... this is the PR that broke Miri, but for some reason CI only noticed this when the next PR (#75966) landed? |
A bunch of recent PRs have a "Your PR failed" message after landing -- not just this one, also e.g. #75912. |
The allocator-wg has decided to support reallocating to a different alignment in
AllocRef
. For more details please see the linked issue.r? @Amanieu
closes rust-lang/wg-allocators#5