Update Clippy #75405
Merged
Update Clippy #75405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flip1995 Fix FP for `suspicious_arithmetic_impl` from `suspicious_trait_impl` … As discussed in rust-lang#3215, the `suspicious_trait_impl` lint causes too many false positives, as it is complex to find out if binary operations are suspicious or not. This PR restricts the number of binary operations to at most one, otherwise we don't lint. This can be seen as very conservative, but at least FP can be reduced to bare minimum. Fixes: rust-lang#3215 changelog: limit the `suspicious_arithmetic_impl` lint to one binop, to avoid many FPs
specifically: cargo dev new_lint --name derive_ord_xor_partial_ord --category correctness --pass late
…e_hash_xor_partial_eq code later
… which is showing one error when there should be four
…p1995 Small fix: `chmod` 644 `clippy_lints/src/utils/ast_utils.rs` changelog: none It looks like `clippy_lints/src/utils/ast_utils.rs` doesn't have to be an executable file.
Rustup r? @ghost changelog: none
Basic instruction for new contributors While answering a few questions to @AB1908, I realized, that our documentation could use some love. Especially the "Getting Started" part for new contributors. So I wrote together some instruction on how to get the toolchain and how to build and test Clippy. [Rendered](https://github.com/flip1995/rust-clippy/blob/basics/doc/basics.md) r? @phansch changelog: none
…r=phansch Add suggestion for `iter_skip_next` lint changelog: Add suggestion for [`iter_skip_next`](https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next) lint
make a bunch of lints texts adhere to rustc dev guide According to the rustc-dev guide: "The text should be matter of fact and avoid capitalization and periods, unless multiple sentences are needed" changelog: make some lint output adhere to the rustc-dev guide
…xperiment, r=oli-obk Clippy pointer cast lint experiment This PR is an experiment about exposing more parts of `rustc_typeck` for use in `clippy`. In particular, the code that checks where a cast is valid or not was exposed, which necessitated exposing [`FnCtxt`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_typeck/check/struct.FnCtxt.html), and figuring out how to create an instance of that type inside `clippy`. This was prompted by [this clippy issue](rust-lang/rust-clippy#2064). r? @oli-obk
Rustup r? @ghost Sync back rust-lang#75098 changelog: none
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit c22ddd9a265301d6d63deb29db1af605cda81a7b has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never |
|
⌛ Testing commit c22ddd9a265301d6d63deb29db1af605cda81a7b with merge d2d0097d3470f478699eca30050646d81aa77dda... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@Manishearth The commit c22ddd9 was faulty, I removed it again. Now CI should pass. |
|
@bors r+ |
|
📌 Commit d6b991d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 28, 2020
Update Clippy Biweekly Clippy update (2 days late, since I wanted to wait for rust-lang#75098) r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biweekly Clippy update (2 days late, since I wanted to wait for #75098)
r? @Manishearth