miri-unleashed: test that we detect heap allocations #71276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
commented
Apr 18, 2020
| @@ -0,0 +1,14 @@ | |||
| // compile-flags: -Zunleash-the-miri-inside-of-you | |||
| #![feature(const_mut_refs, box_syntax)] | |||
There was a problem hiding this comment.
I was quite surprised that I had to add const_mut_refs here, given that I unleashed miri. Is that expected?
There was a problem hiding this comment.
Yes. That was an explicit choice:
rust/src/librustc_mir/transform/check_consts/validation.rs
Lines 214 to 216 in 339a938
RalfJung
force-pushed
the
miri-unleash-box
branch
from
dd6a62c
to
cf3470a
Compare
|
@bors r+ rollup |
|
📌 Commit cf3470a has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 18, 2020
…ic-morse miri-unleashed: test that we detect heap allocations This removes the second-to-last use of `IS_SUPPORTED_IN_MIRI = false`. r? @ecstatic-morse @oli-obk
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71271 (Move `MapInPlace` to rustc_data_structures) - rust-lang#71276 (miri-unleashed: test that we detect heap allocations) - rust-lang#71283 (Minor improvements to -Zprofile) - rust-lang#71287 (Explain why we shouldn't add inline attr to into_vec) - rust-lang#71303 (remove build warnings) Failed merges: r? @ghost
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the second-to-last use of
IS_SUPPORTED_IN_MIRI = false.r? @ecstatic-morse @oli-obk