Rollup of 5 pull requests #70481
Closed
Rollup of 5 pull requests #70481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the bound restriction structured suggestions were incorrect while others had subpar output.
Tweak `suggest_constraining_type_param` Some of the bound restriction structured suggestions were incorrect while others had subpar output. The only issue left is a suggestion for an already present bound when dealing with `const`s that should be handled independently. Fix rust-lang#69983.
suggest `;` on expr `mac!()` which is good as stmt `mac!()` Fixes rust-lang#34421 by implementing @jseyfried's suggestion in rust-lang#34421 (comment). r? @petrochenkov
…pe, r=estebank non-exhastive diagnostic: add note re. scrutinee type This fixes rust-lang#67259 by adding a note: ``` = note: the matched value is of type &[i32] ``` to non-exhaustive pattern matching errors. r? @varkor @estebank
Refactor type_of for constants If I have to look at this function for a few hours I want it to at least look good. r? @varkor
clarify hir_id <-> node_id method names resolves 2 FIXME. r? @eddyb
|
@bors r+ p=5 rollup=never |
|
📌 Commit ae4bfd8 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit ae4bfd8 with merge aa18c4e2d67eeee736e7be87684e30e0a92cb906... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
suggest_constraining_type_param#70009 (Tweaksuggest_constraining_type_param);on exprmac!()which is good as stmtmac!()#70434 (suggest;on exprmac!()which is good as stmtmac!())Failed merges:
r? @ghost