Nits in tuple to_str implementation #6975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a pointer to #4760, which is a closed issue. The real issue is the more general problem described in #4653. Correct the comment. Signed-off-by: Ramkumar Ramachandra <[email protected]>
The three-tuple uses fmt!, and there's no reason to hand-concatenate strings. Signed-off-by: Ramkumar Ramachandra <[email protected]>
bors
added a commit
that referenced
this pull request
Jun 6, 2013
[1/2] fixes a couple of comments. [2/2] uses fmt! instead of hand-concatenating strings in a couple of places. No functional changes.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 8, 2021
Improve `redundant_slicing` fixes: rust-lang#6968 changelog: Fix `redundant_slicing` suggestion when a reborrow might be required or when the value is from a macro call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1/2] fixes a couple of comments.
[2/2] uses fmt! instead of hand-concatenating strings in a couple of places.
No functional changes.