Replace some desc logic in librustc_lint with article_and_desc #69740

mark-i-m · 2020-03-05T16:20:49Z

Followup to #69674

Blocked on #69498

rust-highfive · 2020-03-05T16:49:41Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-05T16:21:43.3890430Z ========================== Starting Command Output ===========================
2020-03-05T16:21:43.3894409Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/c684cc31-65b4-4012-be54-22d90c67cd47.sh
2020-03-05T16:21:43.3894826Z 
2020-03-05T16:21:43.3899566Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-05T16:21:43.3949678Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-05T16:21:43.3954426Z Task         : Get sources
2020-03-05T16:21:43.3954886Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-05T16:21:43.3955345Z Version      : 1.0.0
2020-03-05T16:21:43.3955640Z Author       : Microsoft
---
2020-03-05T16:21:44.3880906Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-05T16:21:44.3888126Z ##[command]git config gc.auto 0
2020-03-05T16:21:44.3893364Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-05T16:21:44.3897965Z ##[command]git config --get-all http.proxy
2020-03-05T16:21:44.3904043Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69740/merge:refs/remotes/pull/69740/merge
---
2020-03-05T16:49:25.4511021Z    Compiling compiler_builtins v0.1.25
2020-03-05T16:49:27.0511484Z    Compiling backtrace-sys v0.1.32
2020-03-05T16:49:27.8686978Z    Compiling unwind v0.0.0 (/checkout/src/libunwind)
2020-03-05T16:49:28.6757884Z    Compiling hashbrown v0.6.2
2020-03-05T16:49:33.5793839Z error: internal compiler error: src/librustc/ty/context.rs:1530: article_and_description called on def_id DefId(0:1 ~ core[a88a]::{{misc}}[0])
2020-03-05T16:49:33.5802956Z thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:875:9
2020-03-05T16:49:33.5807374Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-05T16:49:33.5809942Z 
2020-03-05T16:49:33.5814479Z note: the compiler unexpectedly panicked. this is a bug.
2020-03-05T16:49:33.5814479Z note: the compiler unexpectedly panicked. this is a bug.
2020-03-05T16:49:33.5817350Z 
2020-03-05T16:49:33.5822819Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-03-05T16:49:33.5830472Z note: rustc 1.43.0-nightly (9f478f6c5 2020-03-05) running on x86_64-unknown-linux-gnu
2020-03-05T16:49:33.5834745Z 
2020-03-05T16:49:33.5834745Z 
2020-03-05T16:49:33.5836431Z note: compiler flags: -Z macro-backtrace -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C codegen-units=1 -C debuginfo=0 -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C llvm-args=-import-instr-limit=10 -C debug-assertions=n --crate-type lib
2020-03-05T16:49:33.5838472Z note: some of the compiler flags provided by cargo are hidden
2020-03-05T16:49:33.5838822Z 
2020-03-05T16:49:33.9390856Z error: aborting due to previous error
2020-03-05T16:49:33.9395484Z 
---
2020-03-05T16:49:34.5514682Z   local time: Thu Mar  5 16:49:34 UTC 2020
2020-03-05T16:49:34.6175003Z   network time: Thu, 05 Mar 2020 16:49:34 GMT
2020-03-05T16:49:34.6175715Z == end clock drift check ==
2020-03-05T16:49:36.2696616Z 
2020-03-05T16:49:36.2769179Z ##[error]Bash exited with code '1'.
2020-03-05T16:49:36.2783707Z ##[section]Finishing: Run build
2020-03-05T16:49:36.2836763Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-05T16:49:36.2841909Z Task         : Get sources
2020-03-05T16:49:36.2842276Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-05T16:49:36.2842603Z Version      : 1.0.0
2020-03-05T16:49:36.2842833Z Author       : Microsoft
2020-03-05T16:49:36.2842833Z Author       : Microsoft
2020-03-05T16:49:36.2843206Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-05T16:49:36.2843620Z ==============================================================================
2020-03-05T16:49:36.6150382Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-05T16:49:36.6193632Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-05T16:49:36.6282843Z Cleaning up task key
2020-03-05T16:49:36.6284232Z Start cleaning up orphan processes.
2020-03-05T16:49:36.6456475Z Terminate orphan process: pid (3323) (python)
2020-03-05T16:49:36.6623964Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-08T14:59:36Z

☔ The latest upstream changes (presumably #69822) made this pull request unmergeable. Please resolve the merge conflicts.

mark-i-m · 2020-03-12T22:59:18Z

Nevermind, the ICE was all in my head. Tests are passing locally.
@rustbot modify labels: +S-blocked -S-waiting-on-author
Blocked on #69498, but otherwise ready

@rustbot modify labels: +S-waiting-on-author

rust-highfive · 2020-03-13T02:23:56Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-13T01:53:49.6257929Z ========================== Starting Command Output ===========================
2020-03-13T01:53:49.6263174Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/dddcbbca-04f4-4d9a-a7c4-e55b5ec9766e.sh
2020-03-13T01:53:49.6263690Z 
2020-03-13T01:53:49.6268744Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-13T01:53:49.6289683Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-13T01:53:49.6293175Z Task         : Get sources
2020-03-13T01:53:49.6293502Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-13T01:53:49.6293835Z Version      : 1.0.0
2020-03-13T01:53:49.6294054Z Author       : Microsoft
---
2020-03-13T01:53:50.6219212Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-13T01:53:50.6229670Z ##[command]git config gc.auto 0
2020-03-13T01:53:50.6233709Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-13T01:53:50.6237396Z ##[command]git config --get-all http.proxy
2020-03-13T01:53:50.6244324Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69740/merge:refs/remotes/pull/69740/merge
---
2020-03-13T02:23:39.4855438Z    Compiling compiler_builtins v0.1.25
2020-03-13T02:23:41.2134300Z    Compiling unwind v0.0.0 (/checkout/src/libunwind)
2020-03-13T02:23:42.0513978Z    Compiling backtrace-sys v0.1.32
2020-03-13T02:23:42.9625508Z    Compiling hashbrown v0.6.2
2020-03-13T02:23:49.0373284Z error: internal compiler error: src/librustc/ty/context.rs:1530: article_and_description called on def_id DefId(0:1 ~ core[50b3]::{{misc}}[0])
2020-03-13T02:23:49.0375322Z thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:880:9
2020-03-13T02:23:49.0375947Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-13T02:23:49.0376354Z 
2020-03-13T02:23:49.0376708Z note: the compiler unexpectedly panicked. this is a bug.
2020-03-13T02:23:49.0376708Z note: the compiler unexpectedly panicked. this is a bug.
2020-03-13T02:23:49.0377029Z 
2020-03-13T02:23:49.0377968Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-03-13T02:23:49.0379158Z note: rustc 1.43.0-nightly (0b21918ba 2020-03-12) running on x86_64-unknown-linux-gnu
2020-03-13T02:23:49.0379585Z 
2020-03-13T02:23:49.0379585Z 
2020-03-13T02:23:49.0380819Z note: compiler flags: -Z macro-backtrace -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C codegen-units=1 -C debuginfo=0 -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C llvm-args=-import-instr-limit=10 -C debug-assertions=n --crate-type lib
2020-03-13T02:23:49.0382014Z note: some of the compiler flags provided by cargo are hidden
2020-03-13T02:23:49.0382340Z 
2020-03-13T02:23:49.3814343Z error: aborting due to previous error
2020-03-13T02:23:49.3819654Z 
---
2020-03-13T02:23:49.4198531Z   local time: Fri Mar 13 02:23:49 UTC 2020
2020-03-13T02:23:49.5226611Z   network time: Fri, 13 Mar 2020 02:23:49 GMT
2020-03-13T02:23:49.5230349Z == end clock drift check ==
2020-03-13T02:23:51.2018674Z 
2020-03-13T02:23:51.2182434Z ##[error]Bash exited with code '1'.
2020-03-13T02:23:51.2196119Z ##[section]Finishing: Run build
2020-03-13T02:23:51.2250882Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-13T02:23:51.2256441Z Task         : Get sources
2020-03-13T02:23:51.2256851Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-13T02:23:51.2257415Z Version      : 1.0.0
2020-03-13T02:23:51.2257711Z Author       : Microsoft
2020-03-13T02:23:51.2257711Z Author       : Microsoft
2020-03-13T02:23:51.2258130Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-13T02:23:51.2258620Z ==============================================================================
2020-03-13T02:23:51.5899043Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-13T02:23:51.5953140Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-13T02:23:51.6056738Z Cleaning up task key
2020-03-13T02:23:51.6058222Z Start cleaning up orphan processes.
2020-03-13T02:23:51.6257576Z Terminate orphan process: pid (4186) (python)
2020-03-13T02:23:51.6554354Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

mark-i-m · 2020-03-15T19:00:35Z

It looks like those functions are called for def_ids that have DefPathData::Misc, which doesn't really give us enough info. This causes article_and_description to crash.

eddyb · 2020-03-15T21:11:02Z

The important thing for article_and_description should be the DefKind, not DefPathData (which is just a crutch) - can you figure out what those DefIds are?
We should start adding DefKinds as needed.

mark-i-m · 2020-03-16T01:36:49Z

@rustbot modify labels: +S-waiting-on-author -S-blocked

@eddyb It looks like they are things like use items, etc. I will take a closer look soon. A quick fix for this PR might be to check the hir ItemKind and return early for the ones we don't want. Does every item have a DefId? i.e. if I have an arbitrary HirId can I always get a DefId to use with def_kind?

EDIT: I have something that seems to work, but I do now see your point about making article_and_description use def_kind and only fall back to DefPathData. However, I see that the def_kind query returns an Option<DefKind>. Can you tell me when it would return None?

eddyb · 2020-03-16T06:10:58Z

Can you tell me when it would return None?

For things that don't have a DefKind variant yet (DefKind originated in name resolution so it doesn't yet have variants like Impl or Closure, but we should eventually move everything over).

mark-i-m · 2020-03-22T00:51:21Z

@eddyb This is ready now. ui tests passing locally.

mark-i-m · 2020-03-22T00:51:45Z

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review

src/librustc_lint/builtin.rs

eddyb · 2020-03-22T01:11:16Z

src/librustc_lint/builtin.rs

@@ -349,7 +349,7 @@ impl MissingDoc {
        id: Option<hir::HirId>,


Does anything pass None for this? If not you could remove the Option and compute article_and_desc inside here from the HirId.

Unfortunately, it is passed with a Crate down below, so for now I will keep the option.

rust-highfive · 2020-03-22T03:40:43Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-22T02:33:12.8400260Z ========================== Starting Command Output ===========================
2020-03-22T02:33:12.8417687Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/6d68d504-c5bf-4374-8f4a-fc0995647c6c.sh
2020-03-22T02:33:12.8578747Z 
2020-03-22T02:33:12.8635558Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-22T02:33:12.8655456Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-22T02:33:12.8659933Z Task         : Get sources
2020-03-22T02:33:12.8660385Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-22T02:33:12.8660671Z Version      : 1.0.0
2020-03-22T02:33:12.8660837Z Author       : Microsoft
---
2020-03-22T02:33:13.6519663Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-22T02:33:13.6525319Z ##[command]git config gc.auto 0
2020-03-22T02:33:13.6529932Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-22T02:33:13.6533734Z ##[command]git config --get-all http.proxy
2020-03-22T02:33:13.6540651Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69740/merge:refs/remotes/pull/69740/merge
---
2020-03-22T03:29:52.9210012Z .................................................................................................... 1700/9818
2020-03-22T03:29:56.8172422Z .................................................................................................... 1800/9818
2020-03-22T03:30:07.1074442Z ..............................................................................i..................... 1900/9818
2020-03-22T03:30:13.1486456Z .................................................................................................... 2000/9818
2020-03-22T03:30:20.2350016Z ....................................................................iiiii........................... 2100/9818
2020-03-22T03:30:38.8470037Z .................................................................................................... 2300/9818
2020-03-22T03:30:40.9511766Z .................................................................................................... 2400/9818
2020-03-22T03:30:43.4912939Z .................................................................................................... 2500/9818
2020-03-22T03:30:59.1296572Z .................................................................................................... 2600/9818
---
2020-03-22T03:33:34.1977998Z ..........................................i...............i......................................... 5000/9818
2020-03-22T03:33:42.5352149Z .................................................................................................... 5100/9818
2020-03-22T03:33:48.6811701Z ......................................................................................i............. 5200/9818
2020-03-22T03:33:54.4632106Z .................................................................................................... 5300/9818
2020-03-22T03:34:04.5566847Z .....................................................................ii.ii........i...i............. 5400/9818
2020-03-22T03:34:12.7204957Z .........i.......................................................................................... 5600/9818
2020-03-22T03:34:21.7771903Z ..............i.F................................................................................... 5700/9818
2020-03-22T03:34:27.9927941Z ...............................ii...................................i............................... 5800/9818
2020-03-22T03:34:34.8223260Z .................................................................................................... 5900/9818
2020-03-22T03:34:34.8223260Z .................................................................................................... 5900/9818
2020-03-22T03:34:41.3694344Z .................................................................................................... 6000/9818
2020-03-22T03:34:50.6589465Z ..............................................................ii...i..ii...........i................ 6100/9818
2020-03-22T03:35:10.1224385Z .................................................................................................... 6300/9818
2020-03-22T03:35:17.0201943Z .................................................................................................... 6400/9818
2020-03-22T03:35:17.0201943Z .................................................................................................... 6400/9818
2020-03-22T03:35:23.8306355Z ............................................................................................i..ii... 6500/9818
2020-03-22T03:35:45.0404246Z .................................................................................................... 6700/9818
2020-03-22T03:35:55.0177439Z ...........................................................................................i........ 6800/9818
2020-03-22T03:35:56.9538011Z .................................................................................................... 6900/9818
2020-03-22T03:35:58.9769152Z .................................................................................................... 7000/9818
---
2020-03-22T03:37:38.6943749Z .................................................................................................... 7800/9818
2020-03-22T03:37:43.2913959Z .................................................................................................... 7900/9818
2020-03-22T03:37:49.1353181Z ................................................................................i................... 8000/9818
2020-03-22T03:37:58.2726335Z .................................................................................................... 8100/9818
2020-03-22T03:38:03.9306378Z .............................iiiiiiiiii.i........................................................... 8200/9818
2020-03-22T03:38:17.2933400Z .................................................................................................... 8400/9818
2020-03-22T03:38:22.2697854Z .................................................................................................... 8500/9818
2020-03-22T03:38:36.9890947Z .................................................................................................... 8600/9818
2020-03-22T03:38:44.8114669Z .................................................................................................... 8700/9818
---
2020-03-22T03:40:36.9406330Z - error: missing documentation for crate
2020-03-22T03:40:36.9406727Z + error: missing documentation for a crate
2020-03-22T03:40:36.9407287Z 2   --> $DIR/issue-10656.rs:1:1
2020-03-22T03:40:36.9407604Z 3    |
2020-03-22T03:40:36.9407883Z 4 LL | / #![deny(missing_docs)]
2020-03-22T03:40:36.9408344Z 
2020-03-22T03:40:36.9408639Z The actual stderr differed from the expected stderr.
2020-03-22T03:40:36.9409393Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-10656/issue-10656.stderr
2020-03-22T03:40:36.9409393Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-10656/issue-10656.stderr
2020-03-22T03:40:36.9410127Z To update references, rerun the tests and pass the `--bless` flag
2020-03-22T03:40:36.9410816Z To only update this specific test, also pass `--test-args issues/issue-10656.rs`
2020-03-22T03:40:36.9411688Z error: 1 errors occurred comparing output.
2020-03-22T03:40:36.9412017Z status: exit code: 1
2020-03-22T03:40:36.9412017Z status: exit code: 1
2020-03-22T03:40:36.9414526Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-10656.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-10656" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-10656/auxiliary"
2020-03-22T03:40:36.9416261Z ------------------------------------------
2020-03-22T03:40:36.9416544Z 
2020-03-22T03:40:36.9417010Z ------------------------------------------
2020-03-22T03:40:36.9417335Z stderr:
2020-03-22T03:40:36.9417335Z stderr:
2020-03-22T03:40:36.9417782Z ------------------------------------------
2020-03-22T03:40:36.9418163Z error: missing documentation for a crate
2020-03-22T03:40:36.9418889Z   --> /checkout/src/test/ui/issues/issue-10656.rs:1:1
2020-03-22T03:40:36.9419223Z    |
2020-03-22T03:40:36.9419519Z LL | / #![deny(missing_docs)]
2020-03-22T03:40:36.9419816Z LL | | #![crate_type="lib"]
2020-03-22T03:40:36.9420374Z    |
2020-03-22T03:40:36.9420640Z note: the lint level is defined here
2020-03-22T03:40:36.9421209Z   --> /checkout/src/test/ui/issues/issue-10656.rs:1:9
2020-03-22T03:40:36.9421701Z    |
---
2020-03-22T03:40:36.9424495Z 
2020-03-22T03:40:36.9425099Z ---- [ui] ui/lint/lints-in-foreign-macros.rs stdout ----
2020-03-22T03:40:36.9425323Z diff of stderr:
2020-03-22T03:40:36.9425437Z 
2020-03-22T03:40:36.9425657Z 26 LL | mod d { baz2!(use std::string::ToString;); }
2020-03-22T03:40:36.9426114Z 28 
2020-03-22T03:40:36.9426464Z - warning: missing documentation for crate
2020-03-22T03:40:36.9426711Z + warning: missing documentation for a crate
2020-03-22T03:40:36.9427265Z 30   --> $DIR/lints-in-foreign-macros.rs:4:1
2020-03-22T03:40:36.9427265Z 30   --> $DIR/lints-in-foreign-macros.rs:4:1
2020-03-22T03:40:36.9427472Z 31    |
2020-03-22T03:40:36.9427636Z 32 LL | / #![warn(unused_imports)]
2020-03-22T03:40:36.9427770Z 
2020-03-22T03:40:36.9427853Z 
2020-03-22T03:40:36.9428045Z The actual stderr differed from the expected stderr.
2020-03-22T03:40:36.9428830Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lints-in-foreign-macros/lints-in-foreign-macros.stderr
2020-03-22T03:40:36.9429405Z To update references, rerun the tests and pass the `--bless` flag
2020-03-22T03:40:36.9429948Z To only update this specific test, also pass `--test-args lint/lints-in-foreign-macros.rs`
2020-03-22T03:40:36.9430349Z error: 1 errors occurred comparing output.
2020-03-22T03:40:36.9430574Z status: exit code: 0
2020-03-22T03:40:36.9430574Z status: exit code: 0
2020-03-22T03:40:36.9432437Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lints-in-foreign-macros.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lints-in-foreign-macros" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lints-in-foreign-macros/auxiliary"
2020-03-22T03:40:36.9434389Z ------------------------------------------
2020-03-22T03:40:36.9434550Z 
2020-03-22T03:40:36.9434884Z ------------------------------------------
2020-03-22T03:40:36.9435069Z stderr:
2020-03-22T03:40:36.9435069Z stderr:
2020-03-22T03:40:36.9435466Z ------------------------------------------
2020-03-22T03:40:36.9435739Z warning: unused import: `std::string::ToString`
2020-03-22T03:40:36.9436266Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:11:16
2020-03-22T03:40:36.9436500Z    |
2020-03-22T03:40:36.9436773Z LL |     () => {use std::string::ToString;} //~ WARN: unused import
2020-03-22T03:40:36.9437400Z ...
2020-03-22T03:40:36.9437541Z LL | mod a { foo!(); }
2020-03-22T03:40:36.9437918Z    |         ------- in this macro invocation
2020-03-22T03:40:36.9438097Z    |
2020-03-22T03:40:36.9438097Z    |
2020-03-22T03:40:36.9438262Z note: the lint level is defined here
2020-03-22T03:40:36.9438904Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:4:9
2020-03-22T03:40:36.9439136Z    |
2020-03-22T03:40:36.9439554Z LL | #![warn(unused_imports)] //~ missing documentation for crate [missing_docs]
2020-03-22T03:40:36.9440355Z    = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
2020-03-22T03:40:36.9440791Z 
2020-03-22T03:40:36.9441008Z warning: unused import: `std::string::ToString`
2020-03-22T03:40:36.9441839Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:16:18
2020-03-22T03:40:36.9441839Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:16:18
2020-03-22T03:40:36.9442069Z    |
2020-03-22T03:40:36.9442340Z LL | mod c { baz!(use std::string::ToString;); } //~ WARN: unused import
2020-03-22T03:40:36.9442808Z 
2020-03-22T03:40:36.9443003Z warning: unused import: `std::string::ToString`
2020-03-22T03:40:36.9443510Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:17:19
2020-03-22T03:40:36.9443744Z    |
2020-03-22T03:40:36.9443744Z    |
2020-03-22T03:40:36.9444000Z LL | mod d { baz2!(use std::string::ToString;); } //~ WARN: unused import
2020-03-22T03:40:36.9444633Z 
2020-03-22T03:40:36.9444801Z warning: missing documentation for a crate
2020-03-22T03:40:36.9445267Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:4:1
2020-03-22T03:40:36.9445487Z    |
2020-03-22T03:40:36.9445487Z    |
2020-03-22T03:40:36.9445724Z LL | / #![warn(unused_imports)] //~ missing documentation for crate [missing_docs]
2020-03-22T03:40:36.9446016Z LL | | #![warn(missing_docs)]
2020-03-22T03:40:36.9446472Z LL | | #[macro_use]
2020-03-22T03:40:36.9446608Z ...  |
2020-03-22T03:40:36.9446740Z LL | |
2020-03-22T03:40:36.9446875Z LL | | fn main() {}
---
2020-03-22T03:40:36.9448620Z 
2020-03-22T03:40:36.9448810Z warning: missing documentation for a function
2020-03-22T03:40:36.9449270Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:18:6
2020-03-22T03:40:36.9449492Z    |
2020-03-22T03:40:36.9449765Z LL | baz!(pub fn undocumented() {}); //~ WARN: missing documentation for a function
2020-03-22T03:40:36.9450196Z 
2020-03-22T03:40:36.9450369Z warning: missing documentation for a function
2020-03-22T03:40:36.9450843Z   --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:19:7
2020-03-22T03:40:36.9451063Z    |
2020-03-22T03:40:36.9451063Z    |
2020-03-22T03:40:36.9451323Z LL | baz2!(pub fn undocumented2() {}); //~ WARN: missing documentation for a function
2020-03-22T03:40:36.9451930Z 
2020-03-22T03:40:36.9452092Z 
2020-03-22T03:40:36.9452419Z ------------------------------------------
2020-03-22T03:40:36.9453373Z 
---
2020-03-22T03:40:36.9466041Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-03-22T03:40:36.9466441Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-22T03:40:36.9466647Z 
2020-03-22T03:40:36.9466731Z 
2020-03-22T03:40:36.9470645Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-22T03:40:36.9473501Z 
2020-03-22T03:40:36.9473585Z 
2020-03-22T03:40:36.9474041Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-03-22T03:40:36.9474360Z Build completed unsuccessfully in 1:02:01
2020-03-22T03:40:36.9474360Z Build completed unsuccessfully in 1:02:01
2020-03-22T03:40:36.9492118Z == clock drift check ==
2020-03-22T03:40:36.9512341Z   local time: Sun Mar 22 03:40:36 UTC 2020
2020-03-22T03:40:37.0996141Z   network time: Sun, 22 Mar 2020 03:40:37 GMT
2020-03-22T03:40:37.0998029Z == end clock drift check ==
2020-03-22T03:40:37.6328311Z 
2020-03-22T03:40:37.6403680Z ##[error]Bash exited with code '1'.
2020-03-22T03:40:37.6419170Z ##[section]Finishing: Run build
2020-03-22T03:40:37.6468152Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-22T03:40:37.6473036Z Task         : Get sources
2020-03-22T03:40:37.6473342Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-22T03:40:37.6473621Z Version      : 1.0.0
2020-03-22T03:40:37.6473850Z Author       : Microsoft
2020-03-22T03:40:37.6473850Z Author       : Microsoft
2020-03-22T03:40:37.6474160Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-22T03:40:37.6474668Z ==============================================================================
2020-03-22T03:40:37.9827077Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-22T03:40:37.9868778Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-22T03:40:37.9960767Z Cleaning up task key
2020-03-22T03:40:37.9961839Z Start cleaning up orphan processes.
2020-03-22T03:40:38.0157702Z Terminate orphan process: pid (3511) (python)
2020-03-22T03:40:38.0313766Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

src/librustc_lint/builtin.rs

eddyb · 2020-03-22T20:54:02Z

@bors r+

bors · 2020-03-22T20:54:03Z

📌 Commit d40dff9 has been approved by eddyb

rust-highfive · 2020-03-22T21:26:21Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-22T19:38:30.8102304Z ========================== Starting Command Output ===========================
2020-03-22T19:38:30.8107206Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/8479b2be-3bc5-4ce5-af78-9c42d459a85d.sh
2020-03-22T19:38:30.8107667Z 
2020-03-22T19:38:30.8112273Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-22T19:38:30.8130640Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-22T19:38:30.8134122Z Task         : Get sources
2020-03-22T19:38:30.8134412Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-22T19:38:30.8134709Z Version      : 1.0.0
2020-03-22T19:38:30.8134902Z Author       : Microsoft
---
2020-03-22T19:38:31.8014114Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-22T19:38:31.8019361Z ##[command]git config gc.auto 0
2020-03-22T19:38:31.8023161Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-22T19:38:31.8026589Z ##[command]git config --get-all http.proxy
2020-03-22T19:38:31.8032708Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69740/merge:refs/remotes/pull/69740/merge
---
2020-03-22T20:35:04.3417223Z .................................................................................................... 1700/9821
2020-03-22T20:35:08.5111049Z .................................................................................................... 1800/9821
2020-03-22T20:35:18.2986828Z ................................................................................i................... 1900/9821
2020-03-22T20:35:25.4459879Z .................................................................................................... 2000/9821
2020-03-22T20:35:32.0511024Z ......................................................................iiiii......................... 2100/9821
2020-03-22T20:35:51.6051525Z .................................................................................................... 2300/9821
2020-03-22T20:35:53.7296552Z .................................................................................................... 2400/9821
2020-03-22T20:35:56.2391453Z .................................................................................................... 2500/9821
2020-03-22T20:36:09.7226668Z .................................................................................................... 2600/9821
---
2020-03-22T20:38:48.4312004Z ............................................i...............i....................................... 5000/9821
2020-03-22T20:38:57.3646027Z .................................................................................................... 5100/9821
2020-03-22T20:39:04.0569724Z ........................................................................................i........... 5200/9821
2020-03-22T20:39:09.7553573Z .................................................................................................... 5300/9821
2020-03-22T20:39:19.8071757Z .......................................................................ii.ii........i...i........... 5400/9821
2020-03-22T20:39:27.6529916Z ...........i........................................................................................ 5600/9821
2020-03-22T20:39:36.2075901Z ................i................................................................................... 5700/9821
2020-03-22T20:39:42.5022484Z .................................ii...................................i............................. 5800/9821
2020-03-22T20:39:49.1596422Z .................................................................................................... 5900/9821
2020-03-22T20:39:49.1596422Z .................................................................................................... 5900/9821
2020-03-22T20:39:55.2939723Z .................................................................................................... 6000/9821
2020-03-22T20:40:04.1158295Z ................................................................ii...i..ii...........i.............. 6100/9821
2020-03-22T20:40:23.0203428Z .................................................................................................... 6300/9821
2020-03-22T20:40:29.8818036Z .................................................................................................... 6400/9821
2020-03-22T20:40:29.8818036Z .................................................................................................... 6400/9821
2020-03-22T20:40:36.6995293Z ..............................................................................................i..ii. 6500/9821
2020-03-22T20:41:04.6294189Z .................................................................................................... 6700/9821
2020-03-22T20:41:14.8537838Z .............................................................................................i...... 6800/9821
2020-03-22T20:41:16.8449060Z .................................................................................................... 6900/9821
2020-03-22T20:41:18.9490170Z .................................................................................................... 7000/9821
---
2020-03-22T20:42:58.5741361Z .................................................................................................... 7800/9821
2020-03-22T20:43:03.0257372Z .................................................................................................... 7900/9821
2020-03-22T20:43:08.8015614Z ...................................................................................i................ 8000/9821
2020-03-22T20:43:17.0465974Z .................................................................................................... 8100/9821
2020-03-22T20:43:23.7283743Z ................................iiiiiiiiii.i........................................................ 8200/9821
2020-03-22T20:43:37.2802045Z .................................................................................................... 8400/9821
2020-03-22T20:43:42.2697708Z .................................................................................................... 8500/9821
2020-03-22T20:43:56.5897815Z .................................................................................................... 8600/9821
2020-03-22T20:44:03.9908586Z .................................................................................................... 8700/9821
---
2020-03-22T20:46:18.1559694Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-03-22T20:46:18.1731439Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-22T20:46:18.3758300Z 
2020-03-22T20:46:18.3761493Z running 183 tests
2020-03-22T20:46:21.0333473Z iiii......i............ii.i..iiii....i....i...........i............i..i..................i....i..... 100/183
2020-03-22T20:46:23.6035440Z .......i.i.i...iii..iiiiiiiiiiiiiiii.......................iii.............ii......
2020-03-22T20:46:23.6038294Z 
2020-03-22T20:46:23.6043378Z  finished in 5.431
2020-03-22T20:46:23.6049985Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-03-22T20:46:23.6224799Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-22T20:46:25.5548171Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-03-22T20:46:25.5736906Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-22T20:46:25.7254500Z 
2020-03-22T20:46:25.7254834Z running 9 tests
2020-03-22T20:46:25.7256410Z iiiiiiiii
2020-03-22T20:46:25.7257459Z 
2020-03-22T20:46:25.7257656Z  finished in 0.152
2020-03-22T20:46:25.7263928Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-03-22T20:46:25.7440860Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-22T20:46:44.7222264Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-03-22T20:46:44.7426843Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-22T20:46:44.9217029Z 
2020-03-22T20:46:44.9217814Z running 115 tests
2020-03-22T20:46:57.8469133Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-22T20:46:59.6138602Z ...iiii.....ii.
2020-03-22T20:46:59.6139950Z 
2020-03-22T20:46:59.6143007Z  finished in 14.871
2020-03-22T20:46:59.6147435Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-03-22T20:46:59.6151297Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-22T20:59:32.8282568Z 
2020-03-22T20:59:32.8283644Z    Doc-tests core
2020-03-22T20:59:37.4353739Z 
2020-03-22T20:59:37.4362782Z running 2484 tests
2020-03-22T20:59:46.0377552Z ......iiiii......................................................................................... 100/2484
2020-03-22T20:59:54.4397141Z .....................................................................................ii............. 200/2484
2020-03-22T21:00:15.4378047Z ....................i............................................................................... 400/2484
2020-03-22T21:00:15.4378047Z ....................i............................................................................... 400/2484
2020-03-22T21:00:24.8313892Z .........................................................................i..i..................iiii. 500/2484
2020-03-22T21:00:40.3190872Z .................................................................................................... 700/2484
2020-03-22T21:00:48.2519019Z .................................................................................................... 800/2484
2020-03-22T21:00:56.1738635Z .................................................................................................... 900/2484
2020-03-22T21:01:04.0363543Z .................................................................................................... 1000/2484
---
2020-03-22T21:04:14.6476290Z .................................................thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:888:13
2020-03-22T21:04:14.6485277Z .. 300/760
2020-03-22T21:04:14.7149917Z .................................................................................................... 400/760
2020-03-22T21:04:16.7806414Z .................................................................................................... 500/760
2020-03-22T21:04:16.8037864Z ..................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2741:22
2020-03-22T21:04:16.8052012Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2766:17
2020-03-22T21:04:16.8057809Z .thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2778:21
2020-03-22T21:04:16.8075687Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2645:13
2020-03-22T21:04:17.7897933Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997:22
2020-03-22T21:04:17.7899476Z ....thread '<unnamed>.' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError.', src/libstd/sync/mpsc/mod.rs:2034:21
2020-03-22T21:04:17.7901237Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:13
2020-03-22T21:04:19.1354788Z ....................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-03-22T21:04:19.1363135Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:587:13
2020-03-22T21:04:19.1371392Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
2020-03-22T21:04:19.1379199Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:694:13
---
2020-03-22T21:04:28.7933140Z 
2020-03-22T21:04:28.7933375Z running 1012 tests
2020-03-22T21:04:45.0467472Z i................................................................................................... 100/1012
2020-03-22T21:04:54.5905531Z .................................................................................................... 200/1012
2020-03-22T21:05:01.2354307Z ..................iii......i......i...i......i...................................................... 300/1012
2020-03-22T21:05:12.3456750Z ............................................i....i......................................ii.......... 500/1012
2020-03-22T21:05:19.1354314Z .................................................................................................... 600/1012
2020-03-22T21:05:24.1066257Z .................................................................................................... 700/1012
2020-03-22T21:05:24.1066257Z .................................................................................................... 700/1012
2020-03-22T21:05:30.5206078Z ......................................iiii.......................................................... 800/1012
2020-03-22T21:05:43.8855362Z .................................................................................................... 900/1012
2020-03-22T21:05:50.2596214Z ............................................................iiii.................................... 1000/1012
2020-03-22T21:05:50.6941814Z test result: ok. 992 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-03-22T21:05:50.6942119Z 
2020-03-22T21:05:50.6989596Z  finished in 159.488
2020-03-22T21:05:50.6994577Z Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
2020-03-22T21:24:32.5075904Z Suite("src/test/run-make-fulldeps") not skipped for "bootstrap::test::RunMakeFullDeps" -- not in ["src/tools/tidy"]
2020-03-22T21:24:32.5371971Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-22T21:24:32.7585157Z 
2020-03-22T21:24:32.7585996Z running 210 tests
2020-03-22T21:25:03.4850681Z ......................i...ii.......................................................................i 100/210
2020-03-22T21:25:34.1329379Z ........................................iiiiii......i..............iii.............................. 200/210
2020-03-22T21:25:39.8962787Z test result: ok. 195 passed; 0 failed; 15 ignored; 0 measured; 0 filtered out
2020-03-22T21:25:39.8963105Z 
2020-03-22T21:25:39.8965834Z  finished in 67.359
2020-03-22T21:25:39.8979444Z Set({"src/doc/rustdoc"}) not skipped for "bootstrap::test::RustdocBook" -- not in ["src/tools/tidy"]
---
2020-03-22T21:26:15.5386055Z - error: missing documentation for crate
2020-03-22T21:26:15.5386332Z + error: missing documentation for the crate
2020-03-22T21:26:15.5386823Z 2   --> $DIR/deny-missing-docs-crate.rs:1:1
2020-03-22T21:26:15.5387060Z 3    |
2020-03-22T21:26:15.5387246Z 4 LL | / #![deny(missing_docs)]
2020-03-22T21:26:15.5387497Z 
2020-03-22T21:26:15.5443080Z The actual stderr differed from the expected stderr.
2020-03-22T21:26:15.5444217Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/deny-missing-docs-crate/deny-missing-docs-crate.stderr
2020-03-22T21:26:15.5444217Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/deny-missing-docs-crate/deny-missing-docs-crate.stderr
2020-03-22T21:26:15.5445077Z To update references, rerun the tests and pass the `--bless` flag
2020-03-22T21:26:15.5445842Z To only update this specific test, also pass `--test-args deny-missing-docs-crate.rs`
2020-03-22T21:26:15.5446408Z error: 1 errors occurred comparing output.
2020-03-22T21:26:15.5446723Z status: exit code: 1
2020-03-22T21:26:15.5446723Z status: exit code: 1
2020-03-22T21:26:15.5449119Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/checkout/src/test/rustdoc-ui/deny-missing-docs-crate.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/deny-missing-docs-crate" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/deny-missing-docs-crate/auxiliary"
2020-03-22T21:26:15.5451126Z ------------------------------------------
2020-03-22T21:26:15.5451349Z 
2020-03-22T21:26:15.5451802Z ------------------------------------------
2020-03-22T21:26:15.5452055Z stderr:
2020-03-22T21:26:15.5452055Z stderr:
2020-03-22T21:26:15.5452690Z ------------------------------------------
2020-03-22T21:26:15.5453059Z error: missing documentation for the crate
2020-03-22T21:26:15.5453698Z   --> /checkout/src/test/rustdoc-ui/deny-missing-docs-crate.rs:1:1
2020-03-22T21:26:15.5454023Z    |
2020-03-22T21:26:15.5454286Z LL | / #![deny(missing_docs)] //~ ERROR
2020-03-22T21:26:15.5454763Z LL | | pub struct Foo; //~ ERROR
2020-03-22T21:26:15.5455029Z    | |_______________^
2020-03-22T21:26:15.5455244Z    |
2020-03-22T21:26:15.5455475Z note: the lint level is defined here
2020-03-22T21:26:15.5455475Z note: the lint level is defined here
2020-03-22T21:26:15.5456108Z   --> /checkout/src/test/rustdoc-ui/deny-missing-docs-crate.rs:1:9
2020-03-22T21:26:15.5456445Z    |
2020-03-22T21:26:15.5456677Z LL | #![deny(missing_docs)] //~ ERROR
2020-03-22T21:26:15.5457153Z 
2020-03-22T21:26:15.5457389Z error: missing documentation for a struct
2020-03-22T21:26:15.5458021Z   --> /checkout/src/test/rustdoc-ui/deny-missing-docs-crate.rs:3:1
2020-03-22T21:26:15.5458343Z    |
---
2020-03-22T21:26:15.5462249Z test result: FAILED. 39 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2020-03-22T21:26:15.5462605Z 
2020-03-22T21:26:15.5462796Z 
2020-03-22T21:26:15.5462934Z 
2020-03-22T21:26:15.5467843Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc-ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-22T21:26:15.5472421Z 
2020-03-22T21:26:15.5472522Z 
2020-03-22T21:26:15.5473140Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-03-22T21:26:15.5473551Z Build completed unsuccessfully in 1:43:40
2020-03-22T21:26:15.5473551Z Build completed unsuccessfully in 1:43:40
2020-03-22T21:26:15.5473803Z == clock drift check ==
2020-03-22T21:26:15.5501792Z   local time: Sun Mar 22 21:26:15 UTC 2020
2020-03-22T21:26:15.8469539Z   network time: Sun, 22 Mar 2020 21:26:15 GMT
2020-03-22T21:26:15.8470911Z == end clock drift check ==
2020-03-22T21:26:16.5210966Z 
2020-03-22T21:26:16.5289835Z ##[error]Bash exited with code '1'.
2020-03-22T21:26:16.5304430Z ##[section]Finishing: Run build
2020-03-22T21:26:16.5356691Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-22T21:26:16.5362344Z Task         : Get sources
2020-03-22T21:26:16.5362692Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-22T21:26:16.5363029Z Version      : 1.0.0
2020-03-22T21:26:16.5363254Z Author       : Microsoft
2020-03-22T21:26:16.5363254Z Author       : Microsoft
2020-03-22T21:26:16.5363622Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-22T21:26:16.5364053Z ==============================================================================
2020-03-22T21:26:16.8682443Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-22T21:26:16.8730434Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69740/merge to s
2020-03-22T21:26:16.8819709Z Cleaning up task key
2020-03-22T21:26:16.8821119Z Start cleaning up orphan processes.
2020-03-22T21:26:16.9006013Z Terminate orphan process: pid (3873) (python)
2020-03-22T21:26:16.9299894Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-22T22:00:50Z

⌛ Testing commit d40dff9 with merge c7397479d94c8f7d2e6c6ac68aa10de635d85067...

mark-i-m · 2020-03-22T22:19:16Z

Oh, it looks like I missed a test and I think bors will fail :(

eddyb · 2020-03-23T22:10:11Z

@bors r+

bors · 2020-03-23T22:10:12Z

📌 Commit 5e8b795 has been approved by eddyb

@eddyb

Replace some desc logic in librustc_lint with article_and_desc r? @eddyb @Centril @matthewjasper Followup to rust-lang#69674 Blocked on rust-lang#69498

@eddyb

Replace some desc logic in librustc_lint with article_and_desc r? @eddyb @Centril @matthewjasper Followup to rust-lang#69674 Blocked on rust-lang#69498

@ghost

Rollup of 11 pull requests Successful merges: - rust-lang#67761 (Move the dep_graph construction to a dedicated crate.) - rust-lang#69740 (Replace some desc logic in librustc_lint with article_and_desc) - rust-lang#69981 (Evaluate repeat expression lengths as late as possible) - rust-lang#70087 (Remove const eval loop detector) - rust-lang#70242 (Improve E0308 error message wording) - rust-lang#70264 (Fix invalid suggestion on `&mut` iterators yielding `&` references) - rust-lang#70267 (get rid of ConstPropUnsupported; use ZST marker structs instead) - rust-lang#70277 (Remove `ReClosureBound`) - rust-lang#70283 (Add regression test for rust-lang#70155.) - rust-lang#70294 (Account for bad placeholder types in where clauses) - rust-lang#70309 (Clean up E0452 explanation) Failed merges: r? @ghost

rust-highfive assigned eddyb Mar 5, 2020

This comment has been minimized.

Sign in to view

mark-i-m force-pushed the describe-it-3 branch from 63a15fc to 92fd79d Compare March 12, 2020 20:50

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 12, 2020

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2020

mark-i-m force-pushed the describe-it-3 branch from 92fd79d to c20aaed Compare March 15, 2020 18:59

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 16, 2020

mark-i-m added 2 commits March 21, 2020 16:33

replace some adhoc logic with article_and_descr

2daaf2b

convert a couple more errors

1661a0a

mark-i-m force-pushed the describe-it-3 branch from 9f7f2c6 to 1661a0a Compare March 22, 2020 00:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2020

eddyb reviewed Mar 22, 2020

View reviewed changes

src/librustc_lint/builtin.rs Outdated Show resolved Hide resolved

eddyb reviewed Mar 22, 2020

View reviewed changes

use static strs

cdb2c3c

eddyb reviewed Mar 22, 2020

View reviewed changes

src/librustc_lint/builtin.rs Outdated Show resolved Hide resolved

the crate and tests

d40dff9

eddyb approved these changes Mar 22, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2020

fix one more test

5e8b795

Centril mentioned this pull request Mar 23, 2020

Rollup of 9 pull requests #70335

Closed

This was referenced Mar 23, 2020

Rollup of 9 pull requests #70338

Closed

Rollup of 11 pull requests #70343

Merged

bors merged commit ee90948 into rust-lang:master Mar 24, 2020

mark-i-m deleted the describe-it-3 branch March 24, 2020 06:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace some desc logic in librustc_lint with article_and_desc #69740

Replace some desc logic in librustc_lint with article_and_desc #69740

mark-i-m commented Mar 5, 2020

This comment has been minimized.

rust-highfive commented Mar 5, 2020

bors commented Mar 8, 2020

This comment has been minimized.

mark-i-m commented Mar 12, 2020 •

edited

Loading

rust-highfive commented Mar 13, 2020

mark-i-m commented Mar 15, 2020

eddyb commented Mar 15, 2020

mark-i-m commented Mar 16, 2020 •

edited

Loading

eddyb commented Mar 16, 2020

mark-i-m commented Mar 22, 2020

mark-i-m commented Mar 22, 2020

eddyb Mar 22, 2020

mark-i-m Mar 22, 2020

rust-highfive commented Mar 22, 2020

eddyb commented Mar 22, 2020

bors commented Mar 22, 2020

rust-highfive commented Mar 22, 2020

bors commented Mar 22, 2020

mark-i-m commented Mar 22, 2020

eddyb commented Mar 23, 2020

bors commented Mar 23, 2020

		@@ -349,7 +349,7 @@ impl MissingDoc {
		id: Option<hir::HirId>,

Replace some desc logic in librustc_lint with article_and_desc #69740

Replace some desc logic in librustc_lint with article_and_desc #69740

Conversation

mark-i-m commented Mar 5, 2020

This comment has been minimized.

rust-highfive commented Mar 5, 2020

bors commented Mar 8, 2020

This comment has been minimized.

mark-i-m commented Mar 12, 2020 • edited Loading

rust-highfive commented Mar 13, 2020

mark-i-m commented Mar 15, 2020

eddyb commented Mar 15, 2020

mark-i-m commented Mar 16, 2020 • edited Loading

eddyb commented Mar 16, 2020

mark-i-m commented Mar 22, 2020

mark-i-m commented Mar 22, 2020

eddyb Mar 22, 2020

Choose a reason for hiding this comment

mark-i-m Mar 22, 2020

Choose a reason for hiding this comment

rust-highfive commented Mar 22, 2020

eddyb commented Mar 22, 2020

bors commented Mar 22, 2020

rust-highfive commented Mar 22, 2020

bors commented Mar 22, 2020

mark-i-m commented Mar 22, 2020

eddyb commented Mar 23, 2020

bors commented Mar 23, 2020

mark-i-m commented Mar 12, 2020 •

edited

Loading

mark-i-m commented Mar 16, 2020 •

edited

Loading