Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #69219

Closed
wants to merge 15 commits into from
Closed

Rollup of 6 pull requests #69219

wants to merge 15 commits into from

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

thesoftwarephilosopher and others added 15 commits January 23, 2020 15:25
@thesoftwarephilosopher
Updating str.chars docs to mention crates.io.
ac19dff 
This might spare someone else a little time searching the stdlib for unicode/grapheme support.
@petrochenkov
parser: macro_rules is a weak keyword
dcad07a
@amosonn
Improve #Safety in various methods in core::ptr
302b9e4 
s/for reads and writes/for both ...
@amosonn
Improve #Safety of core::ptr::replace
351782d 
Added missing condition:
`dst` must be readable
@amosonn
Improve #Safety in various methods in core::ptr
40ca167 
For all methods which read a value of type T, `read`, `read_unaligned`,
`read_volatile` and `replace`, added missing
constraint:
The value they point to must be properly initialized
@GuillaumeGomez
Clean up E0309 explanation
cadf9ef
@kubo39
macOS: avoid calling pthread_self() twice
67068f3
@amosonn
Improve #Safety of core::ptr::drop_in_place
943e653 
Added missing conditions:
- Valid for writes
- Valid for destructing
@RalfJung
debug_assert a few more raw pointer methods
bec5d37
@Dylan-DPC
Rollup merge of rust-lang#68495 - sdegutis:patch-1, r=Mark-Simulacrum
78deb93 
Updating str.chars docs to mention crates.io.

This might spare someone else a little time searching the stdlib for unicode/grapheme support.
@Dylan-DPC
Rollup merge of rust-lang#68701 - amosonn:patch-2, r=RalfJung
c1cda01 
Improve #Safety of various methods in core::ptr

For `read`, `read_unaligned`,`read_volatile`, `replace`, and `drop_in_place`:

- The value they point to must be properly initialized

For `replace`, additionally:

- The pointer must be readable
@Dylan-DPC
Rollup merge of rust-lang#68767 - kubo39:patch-macos, r=shepmaster
0ee1177 
macOS: avoid calling pthread_self() twice
@Dylan-DPC
Rollup merge of rust-lang#69186 - petrochenkov:kwrules, r=Centril
3b77477 
[tiny] parser: `macro_rules` is a weak keyword

r? @Centril
@Dylan-DPC
Rollup merge of rust-lang#69188 - GuillaumeGomez:clean-up-e0309, r=Dy…
5c96c06 
…lan-DPC

Clean up E0309 explanation

r? @Dylan-DPC
@Dylan-DPC
Rollup merge of rust-lang#69208 - RalfJung:debug-assert, r=Mark-Simul…
b0052c4 
…acrum

debug_assert a few more raw pointer methods

Fixes rust-lang#53871
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Feb 16, 2020

📌 Commit b0052c4 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 16, 2020
@Dylan-DPC-zz Dylan-DPC-zz added the rollup A PR which is a rollup label Feb 16, 2020
@bors
Copy link
Contributor

bors commented Feb 17, 2020

⌛ Testing commit b0052c4 with merge 942ea9628bd6a99d0034937a62bd3f4da07402e0...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-02-17T03:22:50.5983168Z 
2020-02-17T03:22:50.5983346Z ------------------------------------------
2020-02-17T03:22:50.5983417Z stderr:
2020-02-17T03:22:50.5983593Z ------------------------------------------
2020-02-17T03:22:50.5983889Z thread 'main' panicked at 'used 976 bytes of stack, but `struct Big` is only 384 bytes', /checkout/src/test/ui/issues/issue-40883.rs:83:9
2020-02-17T03:22:50.5984041Z 
2020-02-17T03:22:50.5984232Z ------------------------------------------
2020-02-17T03:22:50.5984287Z 
2020-02-17T03:22:50.5984315Z 
---
2020-02-17T03:22:50.5995073Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-17T03:22:50.5995223Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-17T03:22:50.6003719Z 
2020-02-17T03:22:50.6003784Z 
2020-02-17T03:22:50.6005382Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.1-rust-1.43.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-17T03:22:50.6006051Z 
2020-02-17T03:22:50.6006083Z 
2020-02-17T03:22:50.6014190Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-17T03:22:50.6014308Z Build completed unsuccessfully in 1:26:59
2020-02-17T03:22:50.6014308Z Build completed unsuccessfully in 1:26:59
2020-02-17T03:22:50.6060681Z == clock drift check ==
2020-02-17T03:22:50.6079685Z   local time: Mon Feb 17 03:22:50 UTC 2020
2020-02-17T03:22:50.7883541Z   network time: Mon, 17 Feb 2020 03:22:50 GMT
2020-02-17T03:22:50.7884671Z == end clock drift check ==
2020-02-17T03:22:51.1702915Z 
2020-02-17T03:22:51.1785889Z ##[error]Bash exited with code '1'.
2020-02-17T03:22:51.1837244Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-17T03:22:51.1838885Z ==============================================================================
2020-02-17T03:22:51.1838971Z Task         : Get sources
2020-02-17T03:22:51.1839035Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Feb 17, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2020
@JohnTitor
Copy link
Member

Uhmm, this failure has been shown three times, closing.

@JohnTitor JohnTitor closed this Feb 17, 2020
@JohnTitor JohnTitor mentioned this pull request Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.