clean up E0185 explanation #68070
Merged
clean up E0185 explanation #68070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Dylan-DPC-zz
suggested changes
Jan 10, 2020
| @@ -17,3 +17,19 @@ impl Foo for Bar { | |||
| fn foo(&self) {} | |||
| } | |||
| ``` | |||
|
|
|||
| When a type implements a trait's associated function, it has to use the same | |||
| signature. So in this case, since `Foo::foo` doesn't take argument and doesn't | |||
There was a problem hiding this comment.
Suggested change
| signature. So in this case, since `Foo::foo` doesn't take argument and doesn't | |
| signature. So in this case, since `Foo::foo` doesn't take any arguments or |
|
|
||
| When a type implements a trait's associated function, it has to use the same | ||
| signature. So in this case, since `Foo::foo` doesn't take argument and doesn't | ||
| return anything, its implementation on `Bar` should the same: |
There was a problem hiding this comment.
Suggested change
| return anything, its implementation on `Bar` should the same: | |
| return anything, its implementation on `Bar` should be the same: |
|
Updated! |
|
@bors r+ rollup |
|
📌 Commit 4fadb50 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 11, 2020
…lan-DPC clean up E0185 explanation r? @Dylan-DPC
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 11, 2020
…lan-DPC clean up E0185 explanation r? @Dylan-DPC
bors
added a commit
that referenced
this pull request
Jan 11, 2020
Rollup of 9 pull requests Successful merges: - #67000 (Promote references to constants instead of statics) - #67756 (Collector tweaks) - #67889 (Compile some CGUs in parallel at the start of codegen) - #67930 (Rename Result::as_deref_ok to as_deref) - #68018 (feature_gate: Remove `GateStrength`) - #68070 (clean up E0185 explanation) - #68072 (Fix ICE #68058) - #68114 (Don't require `allow_internal_unstable` unless `staged_api` is enabled.) - #68120 (Ban `...X` pats, harden tests, and improve diagnostics) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 11, 2020
…lan-DPC clean up E0185 explanation r? @Dylan-DPC
bors
added a commit
that referenced
this pull request
Jan 11, 2020
Rollup of 8 pull requests Successful merges: - #67756 (Collector tweaks) - #67889 (Compile some CGUs in parallel at the start of codegen) - #67930 (Rename Result::as_deref_ok to as_deref) - #68018 (feature_gate: Remove `GateStrength`) - #68070 (clean up E0185 explanation) - #68072 (Fix ICE #68058) - #68114 (Don't require `allow_internal_unstable` unless `staged_api` is enabled.) - #68120 (Ban `...X` pats, harden tests, and improve diagnostics) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC