Improve diagnostics for invalid assignment #67538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
force-pushed
the
lhs-assign-diagnostics
branch
from
2aeb937
to
ddd4500
Compare
|
r? @Centril |
|
@bors r+ |
|
📌 Commit 770725c has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 22, 2019
…ntril Improve diagnostics for invalid assignment - Improve wording and span information for invalid assignment diagnostics. - Link to rust-lang/rfcs#372 when it appears the user is trying a destructuring assignment. - Make the equality constraint in `where` clauses error consistent with the invalid assignment error.
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
lhs-assign-diagnostics
branch
from
770725c
to
522a499
Compare
|
@bors r=Centril |
|
📌 Commit 522a499de9b5daae8d0e44cca418fba537d358fa has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
|
☔ The latest upstream changes (presumably #67540) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
varkor
force-pushed
the
lhs-assign-diagnostics
branch
from
522a499
to
9e50813
Compare
|
@bors r=Centril |
|
📌 Commit 9e50813 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 23, 2019
…ntril Improve diagnostics for invalid assignment - Improve wording and span information for invalid assignment diagnostics. - Link to rust-lang/rfcs#372 when it appears the user is trying a destructuring assignment. - Make the equality constraint in `where` clauses error consistent with the invalid assignment error.
bors
added a commit
that referenced
this pull request
Dec 23, 2019
Rollup of 8 pull requests Successful merges: - #67233 (Add PartialEq and Eq to Cursor) - #67466 (Require const stability attributes on intrinsics to be able to use them in constant contexts) - #67507 (Remove mem::uninitalized from tests) - #67527 (Results show too much) - #67536 (Move `{hir::lowering -> hir}::is_range_literal`) - #67538 (Improve diagnostics for invalid assignment) - #67546 (Fix ICE in mir interpretation) - #67559 (Document that calling Drop, even after it panics, is UB) Failed merges: r? @ghost
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 24, 2019
rustup "Add span information to `ExprKind::Assign`" cc rust-lang/rust#67538 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whereclauses error consistent with the invalid assignment error.