Generate DWARF address ranges for faster lookups #66532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new option `-Zgenerate-arange-section`, enabled by default, corresponding to LLVM's `-generate-arange-section`. This creates a `.debug_aranges` section with DWARF address ranges, which some tools depend on to optimize address lookups (elfutils [22288], [25173]). This only has effect when debuginfo is enabled, and the additional data is small compared to the other debug sections. For example, libstd.so with full debuginfo is about 11MB, with just 61kB in aranges. [22288]: https://sourceware.org/bugzilla/show_bug.cgi?id=22288 [25173]: https://sourceware.org/bugzilla/show_bug.cgi?id=25173 Closes rust-lang#45246.
rust-highfive
added
the
S-waiting-on-review
|
We could of course choose a different option name, and I wasn't sure if it should be |
|
Seems like it should be tracked, since we presumably want to rerun codegen (and debuginfo-gen) if it changes. How is the performance side of this? We can check somewhat on perf I guess... @bors try @rust-timer queue |
|
⌛ Trying commit a5d624d with merge cac893b7e1ae448226feb916d342a26bb7492344... |
|
☀️ Try build successful - checks-azure |
There was a problem hiding this comment.
Thanks, @cuviper! Looks good to me. Let's get this merged asap so we get some testing while still early in the current cycle.
|
@bors r+ |
|
📌 Commit 4c2f1c8 has been approved by |
bors
added
S-waiting-on-bors
|
Let's keep this change bisectable: |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 20, 2019
…rister Generate DWARF address ranges for faster lookups This adds a new option `-Zgenerate-arange-section`, enabled by default, corresponding to LLVM's `-generate-arange-section`. This creates a `.debug_aranges` section with DWARF address ranges, which some tools depend on to optimize address lookups (elfutils [22288], [25173]). This only has effect when debuginfo is enabled, and the additional data is small compared to the other debug sections. For example, libstd.so with full debuginfo is about 11MB, with just 61kB in aranges. [22288]: https://sourceware.org/bugzilla/show_bug.cgi?id=22288 [25173]: https://sourceware.org/bugzilla/show_bug.cgi?id=25173 Closes rust-lang#45246. r? @michaelwoerister
bors
added a commit
that referenced
this pull request
Nov 20, 2019
Rollup of 8 pull requests Successful merges: - #65665 (Update Source Code Pro and include italics) - #66478 (rustc_plugin: Remove the compatibility shim) - #66497 (Fix #53820) - #66526 (Add more context to `async fn` trait error) - #66532 (Generate DWARF address ranges for faster lookups) - #66546 (Remove duplicate function) - #66548 ([RISCV] Disable Atomics on all Non-A RISC-V targets) - #66553 (remove HermitCore leftovers from sys/unix) Failed merges: r? @ghost
|
So it was rolled up anyway -- I think the bot syntax is "rollup=never". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option
-Zgenerate-arange-section, enabled by default,corresponding to LLVM's
-generate-arange-section. This creates a.debug_arangessection with DWARF address ranges, which some toolsdepend on to optimize address lookups (elfutils 22288, 25173).
This only has effect when debuginfo is enabled, and the additional data
is small compared to the other debug sections. For example, libstd.so
with full debuginfo is about 11MB, with just 61kB in aranges.
Closes #45246.
r? @michaelwoerister