Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #53820 #66497

Merged
merged 11 commits into from
Nov 20, 2019
Merged

Fix #53820 #66497

merged 11 commits into from
Nov 20, 2019

Commits on Nov 16, 2019

  1. Tweak VarLenSlice subtraction

    @Nadrieril
    Nadrieril committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    143fb43 View commit details
    Browse the repository at this point in the history

  2. Add some tests

    @Nadrieril
    Nadrieril committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    c00ecfa View commit details
    Browse the repository at this point in the history

  3. Introduce new FixedLenSlice constructor 

    It is used in the case where a variable-length slice pattern is used to
match on an array of known size. This allows considering only those
entries in the array that are captured by one of the patterns.
As a side-effect, diagnostics improve a bit for those cases.
    @Nadrieril
    Nadrieril committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    d93c1b3 View commit details
    Browse the repository at this point in the history

  4. Add regression test for issue 53820

    @Nadrieril
    Nadrieril committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    5b420a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. Unify the various slice constructors

    @Nadrieril
    Nadrieril committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    d0cfef3 View commit details
    Browse the repository at this point in the history

  2. Factor out slice constructor struct and simplify

    @Nadrieril
    Nadrieril committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    54e97e8 View commit details
    Browse the repository at this point in the history

  3. Small improvement to exhaustiveness diagnostics

    @Nadrieril
    Nadrieril committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    daa117e View commit details
    Browse the repository at this point in the history

  4. Store SliceKinds directly when subtracting

    @Nadrieril
    Nadrieril committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    bd0e3cc View commit details
    Browse the repository at this point in the history

  5. ConstantValue is the only other ctor allowed when subtracting from … 

    …slice ctors
    @Nadrieril
    Nadrieril committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    7f5e044 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Update src/test/ui/pattern/issue-53820-slice-pattern-large-array.rs 

    Co-Authored-By: Mazdak Farrokhzad <[email protected]>
    @Nadrieril @Centril
    Nadrieril and Centril authored Nov 18, 2019
    Configuration menu
    Copy the full SHA
    2079ae3 View commit details
    Browse the repository at this point in the history

  2. Tweak diagnostics code

    @Nadrieril
    Nadrieril committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    1425ae1 View commit details
    Browse the repository at this point in the history