Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #65713

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Update clippy #65713

merged 4 commits into from
Oct 23, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 23, 2019 •
edited
Loading

Replaces #65690
cc #65503
Closes #65683

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Oct 23, 2019

cc @flip1995 , @oli-obk, @Centril
r? @Manishearth

@rust-highfive rust-highfive assigned Manishearth and unassigned eddyb Oct 23, 2019
@tesuji tesuji mentioned this pull request Oct 23, 2019
Closed
@Manishearth
Copy link
Member

@bors r+ p=2

@bors
Copy link
Contributor

bors commented Oct 23, 2019

📌 Commit 557cbd0 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Oct 23, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2019
@bors
Copy link
Contributor

bors commented Oct 23, 2019

⌛ Testing commit 557cbd0 with merge d6e4028...

bors added a commit that referenced this pull request Oct 23, 2019
@bors
Auto merge of #65713 - lzutao:clippy-up, r=Manishearth
d6e4028 
Update clippy

Replaces #65690
cc  #65503
Closes #65683
@bors
Copy link
Contributor

bors commented Oct 23, 2019

☀️ Test successful - checks-azure
Approved by: Manishearth
Pushing d6e4028 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2019
@bors bors merged commit 557cbd0 into rust-lang:master Oct 23, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #65713!

Tested on commit d6e4028.
Direct link to PR: #65713

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 23, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#65713!
8bf3aa0 
Tested on commit rust-lang/rust@d6e4028.
Direct link to PR: <rust-lang/rust#65713>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@bors bors mentioned this pull request Oct 23, 2019
Merged
@tesuji tesuji deleted the clippy-up branch October 23, 2019 10:13
@RalfJung
Copy link
Member

Does this make enough types from libtest public again to fix Manishearth/compiletest-rs#197 ?

@RalfJung RalfJung mentioned this pull request Oct 24, 2019
Closed
@tesuji
Copy link
Contributor Author

tesuji commented Oct 24, 2019

yes, at least for compiletest_rs v0.3.25.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#65671
7 participants
@tesuji @rust-highfive @Manishearth @bors @RalfJung @eddyb @flip1995