Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[track_caller] feature gate (RFC 2091 1/N) #65037

Merged
merged 13 commits into from
Oct 9, 2019
Merged

#[track_caller] feature gate (RFC 2091 1/N) #65037

merged 13 commits into from
Oct 9, 2019

Commits on Oct 7, 2019

  1. [RFC 2091] Add #[track_caller] attribute. 

    - The attribute is behind a feature gate.
- Error if both #[naked] and #[track_caller] are applied to the same function.
- Error if #[track_caller] is applied to a non-function item.
- Error if ABI is not "rust"
- Error if #[track_caller] is applied to a trait function.

Error codes and descriptions are pending.
    @ayosec @anp
    ayosec authored and anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    543449d View commit details
    Browse the repository at this point in the history

  2. track_caller run-pass test, lint cleanup, PR review.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    6c04c8e View commit details
    Browse the repository at this point in the history

  3. track_caller feature gate starts in 1.40.0. 

    Co-Authored-By: Mazdak Farrokhzad <[email protected]>
    @anp @Centril
    anp and Centril committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    43d4b70 View commit details
    Browse the repository at this point in the history

  4. Mark #![feature(track_caller)] as incomplete.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    d931afe View commit details
    Browse the repository at this point in the history

  5. track_caller error numbers and text.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    9900211 View commit details
    Browse the repository at this point in the history

  6. track_caller tests account for incomplete feature warning.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    53096c5 View commit details
    Browse the repository at this point in the history

  7. E0735 -> E0739 

    Prevents number collision with another approved PR.
    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    8992c30 View commit details
    Browse the repository at this point in the history

  8. E073[6-8] include failing code examples.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    bdc4bd1 View commit details
    Browse the repository at this point in the history

  9. Expand E0738 to cover different cases.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    130be6d View commit details
    Browse the repository at this point in the history

  10. Update expected error output.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    f70ed29 View commit details
    Browse the repository at this point in the history

  11. Prohibit #[track_caller] within trait impls as well as decls.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    190212c View commit details
    Browse the repository at this point in the history

  12. Clarify variable names when checking track_caller methods.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    c49966b View commit details
    Browse the repository at this point in the history

  13. Fix syntax typo in error message.

    @anp
    anp committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    cca58d1 View commit details
    Browse the repository at this point in the history