Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point at original span when emitting unreachable lint #64592

Merged
merged 8 commits into from
Sep 20, 2019
Merged

Point at original span when emitting unreachable lint #64592

merged 8 commits into from
Sep 20, 2019

Commits on Sep 18, 2019

  1. Point at original span when emitting unreachable lint 

    Fixes rust-lang#64590

When we emit an 'unreachable' lint, we now add a note pointing at the
expression that actually causes the code to be unreachable (e.g.
`return`, `break`, `panic`).

This is especially useful when macros are involved, since a diverging
expression might be hidden inside of a macro invocation.
    @Aaron1011
    Aaron1011 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    822393d View commit details
    Browse the repository at this point in the history

  2. Make note better when all arms in a match diverge

    @Aaron1011
    Aaron1011 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    cd4b468 View commit details
    Browse the repository at this point in the history

  3. Some formatting cleanup

    @Aaron1011
    Aaron1011 committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    9e777eb View commit details
    Browse the repository at this point in the history

  4. Apply formatting fixes 

    Co-Authored-By: Mazdak Farrokhzad <[email protected]>
    @Aaron1011 @Centril
    Aaron1011 and Centril authored Sep 18, 2019
    Configuration menu
    Copy the full SHA
    6edcfbe View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Introduce Diverges::always constructor 

    Rename the existing Diverges.always method to Diverges.is_always
    @Aaron1011
    Aaron1011 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    a8ce93e View commit details
    Browse the repository at this point in the history

  2. Use 'if let' instead of 'match'

    @Aaron1011
    Aaron1011 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    41e1128 View commit details
    Browse the repository at this point in the history

  3. Another formatting fix 

    Co-Authored-By: Mazdak Farrokhzad <[email protected]>
    @Aaron1011 @Centril
    Aaron1011 and Centril authored Sep 19, 2019
    Configuration menu
    Copy the full SHA
    034a8fd View commit details
    Browse the repository at this point in the history

  4. Merge inherent impl blocks for `Diverges

    @Aaron1011
    Aaron1011 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    d67528f View commit details
    Browse the repository at this point in the history