Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #61852

Closed
wants to merge 17 commits into from
Closed

Commits on Jun 13, 2019

  1. typeck: Fix ICE for blocks in repeat expr count.

    This commit extends the work in rust-lang#61698 to get the `DefId` of const
    parameters from block that resolve to a const parameter (as well as
    const parameters directly, as it was previously).
    davidtwco committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    bc36aab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bdb05a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Configuration menu
    Copy the full SHA
    8ce063a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d302413 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    065151f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00bae87 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    363940b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ae8d6a8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4e212c6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5c84cd3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    34c4117 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#61143 - estebank:issue-61106, r=eddyb

    When suggesting borrow, remove useless clones
    
    Fix rust-lang#61106.
    Centril authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    58a6259 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#61785 - RalfJung:as-ref, r=rkruppe

    note some safety concerns of raw-ptr-to-ref casts
    Centril authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    75d136e View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#61805 - davidtwco:ice-const-generic-repeat-…

    …expr-count-sequel, r=varkor
    
    typeck: Fix ICE for blocks in repeat expr count.
    
    Fixes rust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression.
    
    r? @varkor
    Centril authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    2396a15 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#61813 - matthewjasper:remove-unnecessary-sy…

    …mbol-ops, r=petrochenkov
    
    Remove some unnecessary symbol interner ops
    
    * Don't gensym symbols that don't need to worry about colliding with other symbols
    * Use symbol constants instead of interning string literals in a few places.
    * Don't generate a module in `__register_diagnostic`
    
    r? @petrochenkov
    Centril authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    57822f9 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#61825 - Centril:tauv-infer-fix, r=petrochenkov

    type_alias_enum_variants: fix rust-lang#61801; allow a path pattern to infer
    
    Fix rust-lang#61801.
    
    Given a type-relative path pattern referring to an enum variant through a type alias, allow inferring the generic argument applied in the expectation set by the scrutinee of a `match` expression.
    
    Similar issues may exist for `let` statements but I don't know how to test for that since `PhantomData<T>` is necessary...)
    
    The gist of the problem here was that `resolve_ty_and_res_ufcs` was called twice which is apparently no good... It is possible that this PR is papering over some deeper problem, but that is beyond my knowledge of the compiler.
    
    r? @petrochenkov
    cc @eddyb @alexreg
    cc rust-lang#61682
    cc rust-lang#49683
    Centril authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    140fa2f View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#61844 - AaronKutch:master, r=Centril

    Change `...` to `..=` where applicable
    
    This is mainly to fix rust-lang#61816, but I decided to manually check a few thousand `...` throughout the code base to check for any other cases. I think I found a documentation bug in `src\libsyntax\ast.rs` where both `1..` and `1...` where mentioned. If there is internal support for both `1..` and `1..=` (that can exist before error handling gets to it), then I can add that back.
    There were some other cases that look like `// struct Closure<'l0...'li, T0...Tj, CK, CS, U0...Uk> {`, `// <P0 as Trait<P1...Pn>>::Foo: 'a`, and `assert!(min <= max, "discriminant range is {}...{}", min, max);`, but I am not sure if I should change those.
    There are a bunch of cases in the `/test/` directory that could be changed, but I presume I should just leave those be.
    Centril authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    4b528fe View commit details
    Browse the repository at this point in the history