Support ? Kleene macro operator in 2015 #60932

Centril · 2019-05-18T06:26:38Z

See that issue for rationale and discussion.

Crater will be needed (done in #60932 (comment), zero regressions) and then, if all goes well, FCP (in #60932 (comment)).

rust-highfive · 2019-05-18T06:26:49Z

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-05-18T06:27:16Z

@bors try

bors · 2019-05-18T06:27:28Z

⌛ Trying commit 695b601 with merge 097e262...

Support ? Kleene macro operator in 2015 Closes #56668. See that issue for rationale and discussion. Crater will be needed and then, if all goes well, FCP.

bors · 2019-05-18T08:45:18Z

☀️ Try build successful - checks-travis
Build commit: 097e262

Centril · 2019-05-18T08:49:24Z

@craterbot run mode=check-only

craterbot · 2019-05-18T08:49:26Z

👌 Experiment pr-60932 created and queued.
🤖 Automatically detected try build 097e262
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-19T07:55:34Z

🚧 Experiment pr-60932 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

michaelwoerister · 2019-05-20T08:12:53Z

r? @nikomatsakis for re-assignment. I don't really know what this is about.

craterbot · 2019-05-20T23:47:12Z

🎉 Experiment pr-60932 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Centril · 2019-05-20T23:54:15Z

r? @petrochenkov for actual code review.

@rfcbot merge

Per note in #56668 (comment) we said that we would do this if crater said it didn't break anyone and indeed it does not. Therefore, I propose that we extend support for ? as the Kleene at-most-one macro operator to 2015. The rationale is provided in #56668 (comment). The gist of it is that we want to reduce technical debt in the compiler, the spec, and also reduce edition differences that must be learned. The original stabilization report summarizing the behavior on 2018 can be found in #48075 (comment).

rfcbot · 2019-05-20T23:54:15Z

Team member @Centril has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Centril · 2019-05-20T23:54:56Z

N.B. Aaron is on leave so I've checked his box.

mark-i-m · 2019-06-09T01:35:04Z

@bors r+

bors · 2019-06-09T01:35:05Z

📌 Commit 1993bef2f440bb656ce9438870cb601ff8865700 has been approved by mark-i-m

Centril · 2019-06-09T03:01:38Z

...rebased

@bors r=mark-i-m

bors · 2019-06-09T03:01:39Z

📌 Commit 3ba82f7 has been approved by mark-i-m

bors · 2019-06-09T05:00:28Z

⌛ Testing commit 3ba82f7 with merge e6e60ef...

Support ? Kleene macro operator in 2015 Closes #56668. See that issue for rationale and discussion. Crater will be needed (done in #60932 (comment), zero regressions) and then, if all goes well, FCP (in #60932 (comment)).

bors · 2019-06-09T07:48:04Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: mark-i-m
Pushing e6e60ef to master...

Pkgsrc changes: * Add a patch to llvm to deal with const dli_saddr. * Adapt two other patches. * Cross-build currently fails, so i386, powerpc and sparc64 bootstrap kits for 1.37.0 are built natively. Missing aarch64 hardware, so that's not available yet. * Bump bootstrap requirements to 1.36.0 except for armv7-unknown-netbsd-eabihf which I've not managed to cross-build. Upstream changes: Version 1.37.0 (2019-08-15) ========================== Language -------- - `#[must_use]` will now warn if the type is contained in a [tuple][61100], [`Box`][62228], or an [array][62235] and unused. - [You can now use the `cfg` and `cfg_attr` attributes on generic parameters.][61547] - [You can now use enum variants through type alias.][61682] e.g. You can write the following: ```rust type MyOption = Option<u8>; fn increment_or_zero(x: MyOption) -> u8 { match x { MyOption::Some(y) => y + 1, MyOption::None => 0, } } ``` - [You can now use `_` as an identifier for consts.][61347] e.g. You can write `const _: u32 = 5;`. - [You can now use `#[repr(align(X)]` on enums.][61229] - [The `?`/_"Kleene"_ macro operator is now available in the 2015 edition.][60932] Compiler -------- - [You can now enable Profile-Guided Optimization with the `-C profile-generate` and `-C profile-use` flags.][61268] For more information on how to use profile guided optimization, please refer to the [rustc book][rustc-book-pgo]. - [The `rust-lldb` wrapper script should now work again.][61827] Libraries --------- - [`mem::MaybeUninit<T>` is now ABI-compatible with `T`.][61802] Stabilized APIs --------------- - [`BufReader::buffer`] - [`BufWriter::buffer`] - [`Cell::from_mut`] - [`Cell<[T]>::as_slice_of_cells`][`Cell<slice>::as_slice_of_cells`] - [`DoubleEndedIterator::nth_back`] - [`Option::xor`] - [`Wrapping::reverse_bits`] - [`i128::reverse_bits`] - [`i16::reverse_bits`] - [`i32::reverse_bits`] - [`i64::reverse_bits`] - [`i8::reverse_bits`] - [`isize::reverse_bits`] - [`slice::copy_within`] - [`u128::reverse_bits`] - [`u16::reverse_bits`] - [`u32::reverse_bits`] - [`u64::reverse_bits`] - [`u8::reverse_bits`] - [`usize::reverse_bits`] Cargo ----- - [`Cargo.lock` files are now included by default when publishing executable crates with executables.][cargo/7026] - [You can now specify `default-run="foo"` in `[package]` to specify the default executable to use for `cargo run`.][cargo/7056] Misc ---- Compatibility Notes ------------------- - [Using `...` for inclusive range patterns will now warn by default.][61342] Please transition your code to using the `..=` syntax for inclusive ranges instead. - [Using a trait object without the `dyn` will now warn by default.][61203] Please transition your code to use `dyn Trait` for trait objects instead. [62228]: rust-lang/rust#62228 [62235]: rust-lang/rust#62235 [61802]: rust-lang/rust#61802 [61827]: rust-lang/rust#61827 [61547]: rust-lang/rust#61547 [61682]: rust-lang/rust#61682 [61268]: rust-lang/rust#61268 [61342]: rust-lang/rust#61342 [61347]: rust-lang/rust#61347 [61100]: rust-lang/rust#61100 [61203]: rust-lang/rust#61203 [61229]: rust-lang/rust#61229 [60932]: rust-lang/rust#60932 [cargo/7026]: rust-lang/cargo#7026 [cargo/7056]: rust-lang/cargo#7056 [`BufReader::buffer`]: https://doc.rust-lang.org/std/io/struct.BufReader.html#method.buffer [`BufWriter::buffer`]: https://doc.rust-lang.org/std/io/struct.BufWriter.html#method.buffer [`Cell::from_mut`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.from_mut [`Cell<slice>::as_slice_of_cells`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.as_slice_of_cells [`DoubleEndedIterator::nth_back`]: https://doc.rust-lang.org/std/iter/trait.DoubleEndedIterator.html#method.nth_back [`Option::xor`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.xor [`RefCell::try_borrow_unguarded`]: https://doc.rust-lang.org/std/cell/struct.RefCell.html#method.try_borrow_unguarded [`Wrapping::reverse_bits`]: https://doc.rust-lang.org/std/num/struct.Wrapping.html#method.reverse_bits [`i128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i128.html#method.reverse_bits [`i16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i16.html#method.reverse_bits [`i32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i32.html#method.reverse_bits [`i64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i64.html#method.reverse_bits [`i8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i8.html#method.reverse_bits [`isize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.isize.html#method.reverse_bits [`slice::copy_within`]: https://doc.rust-lang.org/std/primitive.slice.html#method.copy_within [`u128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u128.html#method.reverse_bits [`u16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u16.html#method.reverse_bits [`u32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u32.html#method.reverse_bits [`u64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u64.html#method.reverse_bits [`u8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u8.html#method.reverse_bits [`usize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.usize.html#method.reverse_bits [rustc-book-pgo]: https://doc.rust-lang.org/rustc/profile-guided-optimization.html

rust-highfive assigned michaelwoerister May 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2019

Centril added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels May 18, 2019

bors added a commit that referenced this pull request May 18, 2019

Auto merge of #60932 - Centril:macro-at-most-once-2015, r=<try>

097e262

Support ? Kleene macro operator in 2015 Closes #56668. See that issue for rationale and discussion. Crater will be needed and then, if all goes well, FCP.

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label May 18, 2019

Centril added this to the 1.37 milestone May 18, 2019

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2019

rust-highfive assigned nikomatsakis and unassigned michaelwoerister May 20, 2019

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 20, 2019

rust-highfive assigned petrochenkov and unassigned nikomatsakis May 20, 2019

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 20, 2019

Centril removed the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label May 20, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jun 9, 2019

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2019

This comment has been minimized.

Sign in to view

Centril added 7 commits June 9, 2019 04:16

Support ? Kleene operator in 2015.

39fbcfb

Update tests since ? macro op is supported on 2015.

1e793c7

Cleanups in parse_sep_and_kleene_op.

ab7d75d

Some more cleanup in libsyntax::ext::tt::quoted

f86719a

Fix inaccurate comments in '?' Kleene operator tests.

a4b9a03

Fix typo in comment.

73c6563

pacify tidy.

3ba82f7

Centril force-pushed the macro-at-most-once-2015 branch from 1993bef to 3ba82f7 Compare June 9, 2019 03:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2019

This was referenced Jun 9, 2019

Kleene ? macro operator is now supported in 2015 rust-lang/reference#616

Closed

Since 1.37.0, Rust 2015 also supports Kleene ? repetition operator rust-lang/edition-guide#161

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2019

bors merged commit 3ba82f7 into rust-lang:master Jun 9, 2019

Centril deleted the macro-at-most-once-2015 branch June 9, 2019 07:58

Centril mentioned this pull request Aug 18, 2019

syntax: Support modern attribute syntax in the meta matcher #63674

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ? Kleene macro operator in 2015 #60932

Support ? Kleene macro operator in 2015 #60932

Centril commented May 18, 2019 •

edited

Loading

rust-highfive commented May 18, 2019

Centril commented May 18, 2019

bors commented May 18, 2019

bors commented May 18, 2019

Centril commented May 18, 2019

craterbot commented May 18, 2019

craterbot commented May 19, 2019

michaelwoerister commented May 20, 2019

craterbot commented May 20, 2019

Centril commented May 20, 2019

rfcbot commented May 20, 2019 •

edited by nikomatsakis

Loading

Centril commented May 20, 2019

mark-i-m commented Jun 9, 2019

bors commented Jun 9, 2019

This comment has been minimized.

This comment has been minimized.

Centril commented Jun 9, 2019

bors commented Jun 9, 2019

bors commented Jun 9, 2019

bors commented Jun 9, 2019

Support ? Kleene macro operator in 2015 #60932

Support ? Kleene macro operator in 2015 #60932

Conversation

Centril commented May 18, 2019 • edited Loading

rust-highfive commented May 18, 2019

Centril commented May 18, 2019

bors commented May 18, 2019

bors commented May 18, 2019

Centril commented May 18, 2019

craterbot commented May 18, 2019

craterbot commented May 19, 2019

michaelwoerister commented May 20, 2019

craterbot commented May 20, 2019

Centril commented May 20, 2019

rfcbot commented May 20, 2019 • edited by nikomatsakis Loading

Centril commented May 20, 2019

mark-i-m commented Jun 9, 2019

bors commented Jun 9, 2019

This comment has been minimized.

This comment has been minimized.

Centril commented Jun 9, 2019

bors commented Jun 9, 2019

bors commented Jun 9, 2019

bors commented Jun 9, 2019

Centril commented May 18, 2019 •

edited

Loading

rfcbot commented May 20, 2019 •

edited by nikomatsakis

Loading