Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ICE when relating const type args #60277

Merged
merged 1 commit into from
May 7, 2019
Merged

Don't ICE when relating const type args #60277

merged 1 commit into from
May 7, 2019

Conversation

estebank
Copy link
Contributor

Fix #60263.

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2019
varkor
varkor reviewed Apr 25, 2019
View reviewed changes
src/librustc/ty/relate.rs Outdated Show resolved Hide resolved
@varkor varkor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2019
@varkor
Copy link
Member

varkor commented May 2, 2019

Now that #59008 has been merged, it should be sufficient just to add the regression test.

@estebank
Copy link
Contributor Author

estebank commented May 2, 2019

@varkor cool! I'll do that soonish.

@varkor varkor mentioned this pull request May 2, 2019
Closed
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2019
@varkor
Copy link
Member

varkor commented May 6, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 6, 2019

📌 Commit 7508086 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2019
bors added a commit that referenced this pull request May 7, 2019
@bors
Auto merge of #60277 - estebank:relate-ice, r=varkor
17dba3b 
Don't ICE when relating const type args

Fix #60263.

r? @varkor
@bors
Copy link
Contributor

bors commented May 7, 2019

⌛ Testing commit 7508086 with merge 17dba3b...

@bors
Copy link
Contributor

bors commented May 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: varkor
Pushing 17dba3b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 7, 2019
@bors bors merged commit 7508086 into rust-lang:master May 7, 2019
@hellow554 hellow554 mentioned this pull request May 8, 2019
Closed
@varkor varkor added the F-const_generics `#![feature(const_generics)]` label Oct 19, 2019
@estebank estebank deleted the relate-ice branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varkor varkor varkor left review comments

Assignees

@varkor varkor

Labels
F-const_generics `#![feature(const_generics)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Const generic ICE without feature specified
4 participants
@estebank @varkor @bors @rust-highfive