Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #59602

Closed
wants to merge 13 commits into from
Closed

Rollup of 5 pull requests #59602

wants to merge 13 commits into from

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Apr 1, 2019

Successful merges:

Failed merges:

r? @ghost

Saleem Jaffer and others added 13 commits March 9, 2019 13:30
Fallback to `static_impl_trait` for nice error message by peeking at the
return type and the lifetime type. Point at the return type instead of
the return expr/stmt in NLL mode.
…, r=pnkfelix

Suggest using anonymous lifetime in `impl Trait` return

Fix rust-lang#48467.

r? @nikomatsakis
Fix small typo

This PR fixes a small typo in `eq()` comments.
@Centril
Copy link
Contributor Author

Centril commented Apr 1, 2019

@bors r+ p=5

@bors
Copy link
Contributor

bors commented Apr 1, 2019

📌 Commit ab19e15 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 1, 2019
@bors
Copy link
Contributor

bors commented Apr 1, 2019

⌛ Testing commit ab19e15 with merge af188067b15be58ad36015a884acc8385292c8a9...

@bors
Copy link
Contributor

bors commented Apr 1, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:50:19] [RUSTC-TIMING] rustc test:false 719.769
[00:50:19]    Compiling rustc_mir v0.0.0 (/checkout/src/librustc_mir)
[00:50:19]    Compiling rustc_typeck v0.0.0 (/checkout/src/librustc_typeck)
[00:50:19]    Compiling rustc_lint v0.0.0 (/checkout/src/librustc_lint)
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2019
@Centril
Copy link
Contributor Author

Centril commented Apr 1, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2019
@Centril Centril closed this Apr 1, 2019
@Centril Centril deleted the rollup branch April 1, 2019 15:28
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank document comment in trait raises error different from with that in function.
6 participants