libcore: clarify documentation for char_at(_reverse) #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Apr 19, 2013
The documentation was unclear/wrong: it implies the functions operated on unicode char indices, but they actually operate on byte indices. Also, the `char_at_reverse` documentation was unclear whether it counted from the beginning or the end (causing #5956).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 28, 2020
… r=yaahc Adding new lint to prevent usage of 'unwrap' inside functions that re… ### Change Adding a new lint that will emit a warning when using "unwrap" or "expect" inside a function that returns result. ### Motivation These functions promote recoverable errors to non-recoverable errors which may be undesirable in code bases which wish to avoid panics. ### Test plan Running: `TESTNAME=unwrap_in_result cargo uitest `--- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation was unclear/wrong: it implies the functions operated on unicode char indices, but they actually operate on byte indices. Also, the
char_at_reversedocumentation was unclear whether it counted from the beginning or the end (causing #5956).