Restore Num trait and use macros to implement and test NumCast #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the trait that was lost in 216e85f. It will eventually be broken up into a more fine-grained trait hierarchy in the future once a design can be agreed upon.
bors
added a commit
that referenced
this pull request
Apr 13, 2013
This restores the trait that was lost in 216e85f. `Num` will eventually be broken up into a more fine-grained trait hierarchy in the future once a design can be agreed upon. To contribute to the discussion about the future of Rust's numeric traits, please see issue #4819 and the [wiki page](https://github.com/mozilla/rust/wiki/Bikeshed-Numeric-Traits). I have also switched to [implementing NumCast using macros](brendanzab@353ce87). This removes a significant number of lines of code.
|
Hurrah! Thanks @nikomatsakis and @catamorphism for your hard work making this possible. |
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2020
…to,flip1995 New lint against `Self` as an arbitrary self type Fixes rust-lang#5861 changelog: * [`needless_arbitrary_self_type`] [rust-lang#5869](rust-lang/rust-clippy#5869)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#5825 (Add the new lint `same_item_push`) - rust-lang#5869 (New lint against `Self` as an arbitrary self type) - rust-lang#5870 (enable #[allow(clippy::unsafe_derive_deserialize)]) - rust-lang#5871 (Lint .min(x).max(y) with x < y) - rust-lang#5874 (Make the docs clearer for new contributors) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the trait that was lost in 216e85f.
Numwill eventually be broken up into a more fine-grained trait hierarchy in the future once a design can be agreed upon.To contribute to the discussion about the future of Rust's numeric traits, please see issue #4819 and the wiki page.
I have also switched to implementing NumCast using macros. This removes a significant number of lines of code.