-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedup a rustdoc diagnostic construction #58591
Dedup a rustdoc diagnostic construction #58591
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
5f099a6
to
ad096d1
Compare
Thanks! Please add a test and then r=me. |
Hey @GuillaumeGomez. This should be pure refactoring. What kind of test would you like for this? |
Ah my bad. I understood that you were deduplicating a code (I understood it was thrown twice). My bad. Then it's all good! @bors: r+ rollup |
📌 Commit ad096d1 has been approved by |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit ad096d1 has been approved by |
…ruction, r=GuillaumeGomez Dedup a rustdoc diagnostic construction None
…ruction, r=GuillaumeGomez Dedup a rustdoc diagnostic construction None
Rollup of 17 pull requests Successful merges: - #57656 (Deprecate the unstable Vec::resize_default) - #58059 (deprecate before_exec in favor of unsafe pre_exec) - #58064 (override `VecDeque::try_rfold`, also update iterator) - #58198 (Suggest removing parentheses surrounding lifetimes) - #58431 (fix overlapping references in BTree) - #58555 (Add a note about 2018e if someone uses `try {` in 2015e) - #58588 (remove a bit of dead code) - #58589 (cleanup macro after 2018 transition) - #58591 (Dedup a rustdoc diagnostic construction) - #58600 (fix small documentation typo) - #58601 (Search for target_triple.json only if builtin target not found) - #58606 (Docs: put Future trait into spotlight) - #58607 (Fixes #58586: Make E0505 erronous example fail for the 2018 edition) - #58615 (miri: explain why we use static alignment in ref-to-place conversion) - #58620 (introduce benchmarks of BTreeSet.intersection) - #58621 (Update miri links) - #58632 (Make std feature list sorted) Failed merges: r? @ghost
No description provided.