Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.32.0 stable release #57600

Merged
merged 4 commits into from
Jan 16, 2019
Merged

Rust 1.32.0 stable release #57600

merged 4 commits into from
Jan 16, 2019

Conversation

pietroalbini
Copy link
Member

Also cherry-picked the following beta-accepted PRs:

r? @Mark-Simulacrum
cc @rust-lang/release

pthariensflame and others added 3 commits January 14, 2019 17:19
@pthariensflame @pietroalbini
Correct RELEASES.md for 1.32.0
a9ac964 
The `into_to_from_bytes` feature was stabilized for `i128` and `u128` just like for the other integer types, but they seem to have been missed.
@pthariensflame @pietroalbini
Fix new hyperlinks in RELEASES.md
d2b4fe0
@pietroalbini
stable 1.32.0 release
04ccee1
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019
@pietroalbini pietroalbini added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jan 14, 2019
@Centril
Copy link
Contributor

Centril commented Jan 14, 2019

@bors p=1000

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented Jan 14, 2019

📌 Commit 04ccee1 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019
@bors
Copy link
Contributor

bors commented Jan 14, 2019

⌛ Testing commit 04ccee1 with merge 929d50aa4108695704c49860265558db30018560...

@bors
Copy link
Contributor

bors commented Jan 14, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2019
@pietroalbini
Copy link
Member Author

Uh?

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019
@bors
Copy link
Contributor

bors commented Jan 15, 2019

⌛ Testing commit 04ccee1 with merge 1823a3189a3de2e08333027821e07e9d747a2df7...

@bors
Copy link
Contributor

bors commented Jan 15, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2019
@Mark-Simulacrum
Copy link
Member

@alexcrichton Do you by chance know the .iss file syntax? Or maybe @retep998? I don't have the time to investigate tonight and am not quite sure what the problem is -- I suspect it has something to do with https://github.com/rust-lang/rust/blob/master/src/etc/installer/exe/rust.iss#L60 but haven't been able to determine yet if that's actually the problem or just a side effect.

@Mark-Simulacrum
Copy link
Member

Well, all I've learned from the ~half hour of investigative work I did tonight is that I don't understand where these files are coming from. I also haven't found anything that changed since the last successful build of the parent commit from this PR -- i.e., https://ci.appveyor.com/project/rust-lang/rust/builds/21559614/job/6vmkp5fj047niib5 -- within the logs. We've bumped the toolchain to "stable" but that seems to be unrelated to the current failure. As far as I can tell, std is being built and disted -- even though I'm still not quite sure how the files make it into work here because as far as I could tell nothing is copying them there. Maybe I'm missing something though -- the dist code is quite convoluted; and in any case nothing has changed in all of bootstrap since the beta build was successful.

@alexcrichton said he'd do some more investigating tomorrow -- and I hope to spend at least a little time as well, though not sure how much I'll have.

@bors
Copy link
Contributor

bors commented Jan 15, 2019

⌛ Testing commit 04ccee1 with merge 7a1d3dd80798d600bf3b17a42ce1e912894b1161...

@kennytm
Copy link
Member

kennytm commented Jan 15, 2019

@bors r- retry

bors added a commit that referenced this pull request Jan 16, 2019
@bors
Auto merge of #57600 - rust-lang:stable-next, r=alexcrichton
24348d8 
Rust 1.32.0 stable release

Also cherry-picked the following beta-accepted PRs:

* #57519: Correct RELEASES.md for 1.32.0

r? @Mark-Simulacrum
cc @rust-lang/release
@bors
Copy link
Contributor

bors commented Jan 16, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2019
@alexcrichton
Copy link
Member

@bors: treeclosed=9000

@alexcrichton
Update the tar crate
05fe2fc 
Fixes a bug in extracting a tarball by correctly recognizing entries are
files instead of directories.
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 16, 2019

📌 Commit 05fe2fc has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 16, 2019

🌲 The tree is currently closed for pull requests below priority 9000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2019
@alexcrichton
Copy link
Member

@bors: p=10000

@bors
Copy link
Contributor

bors commented Jan 16, 2019

🛑 Priority higher than 9001 is ignored.

@alexcrichton
Copy link
Member

@bors: treeclosed-

@bors
Copy link
Contributor

bors commented Jan 16, 2019

⌛ Testing commit 05fe2fc with merge e8f3130...

bors added a commit that referenced this pull request Jan 16, 2019
@bors
Auto merge of #57600 - rust-lang:stable-next, r=alexcrichton
e8f3130 
Rust 1.32.0 stable release

Also cherry-picked the following beta-accepted PRs:

* #57519: Correct RELEASES.md for 1.32.0

r? @Mark-Simulacrum
cc @rust-lang/release
@bors
Copy link
Contributor

bors commented Jan 16, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[02:58:18] [ 39%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FEntryInserter.cpp.o
[02:58:28] [ 40%] Building CXX object lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAGTargetInfo.cpp.o
[02:58:39] [ 40%] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/DwarfAccelTable.cpp.o

Broadcast message from root@travis-job-befe3580-53b6-4135-8089-c1b3cf4a15db
 (unknown) at 9:23 ...
The system is going down for power off NOW!

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2019
@kennytm
Copy link
Member

kennytm commented Jan 16, 2019

@bors retry

Repopulating cache

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2019
@bors
Copy link
Contributor

bors commented Jan 16, 2019

⌛ Testing commit 05fe2fc with merge 9fda7c2...

@Centril Centril mentioned this pull request Jan 16, 2019
Merged
bors added a commit that referenced this pull request Jan 16, 2019
@bors
Auto merge of #57600 - rust-lang:stable-next, r=alexcrichton
9fda7c2 
Rust 1.32.0 stable release

Also cherry-picked the following beta-accepted PRs:

* #57519: Correct RELEASES.md for 1.32.0

r? @Mark-Simulacrum
cc @rust-lang/release
@bors
Copy link
Contributor

bors commented Jan 16, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 9fda7c2 to stable...

@bors bors merged commit 05fe2fc into stable Jan 16, 2019
@Mark-Simulacrum Mark-Simulacrum deleted the stable-next branch January 16, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pietroalbini @rust-highfive @Centril @Mark-Simulacrum @bors @kennytm @alexcrichton @mark-i-m @petrochenkov @pthariensflame