Stabilize `linker-flavor` flag. #56351

davidtwco · 2018-11-29T21:02:05Z

Part of #55396.

This commit moves the linker-flavor flag from a debugging option to a
codegen option, thus stabilizing it. There are no feature flags
associated with this flag.

r? @nagisa

nagisa · 2018-11-29T21:24:52Z

@rfcbot merge

We had a blunder a little while ago and ended up stabilising a behaviour in -Clinker that would automatically infer the -Clinker-flavor from the filename. That regressed some previous users of -Clinker that were relying on this flag not inferring the -Clinker-flavor in certain ways.

We cannot revert -Clinker behaviour and it is very likely that we want to keep the infer-ful behaviour either way. Therefore, it is important for us to provide a way to override this behaviour in some way and -Clinker-flavor enables user to do exactly that.

I’m pushing this through an FCP to avoid the same issue that occurred when -Clinker got stabilised without the due diligence on reviewing the pitfalls.

rfcbot · 2018-11-29T21:24:53Z

rfcbot · 2018-12-06T11:32:50Z

🔔 This is now entering its final comment period, as per the review above. 🔔

src/doc/rustc/src/codegen-options/index.md

This commit moves the linker-flavor flag from a debugging option to a codegen option, thus stabilizing it. There are no feature flags associated with this flag.

nagisa · 2018-12-13T14:51:44Z

@bors r+

bors · 2018-12-13T14:51:45Z

📌 Commit 9536d04 has been approved by nagisa

…ker-flavor, r=nagisa Stabilize `linker-flavor` flag. Part of rust-lang#55396. This commit moves the linker-flavor flag from a debugging option to a codegen option, thus stabilizing it. There are no feature flags associated with this flag.

bors · 2018-12-14T00:28:15Z

⌛ Testing commit 9536d04 with merge 0d4f919...

@nagisa

… r=nagisa Stabilize `linker-flavor` flag. Part of #55396. This commit moves the linker-flavor flag from a debugging option to a codegen option, thus stabilizing it. There are no feature flags associated with this flag. r? @nagisa

bors · 2018-12-14T02:53:25Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing 0d4f919 to master...

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

rust-highfive assigned nagisa Nov 29, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2018

nagisa added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 29, 2018

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 29, 2018

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 30, 2018

This comment has been minimized.

Sign in to view

davidtwco force-pushed the issue-55396-stabilize-linker-flavor branch from 0bf2560 to fbda374 Compare December 5, 2018 09:40

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 6, 2018

Ralith reviewed Dec 12, 2018

View reviewed changes

src/doc/rustc/src/codegen-options/index.md Outdated Show resolved Hide resolved

Stabilize linker-flavor flag.

9536d04

This commit moves the linker-flavor flag from a debugging option to a codegen option, thus stabilizing it. There are no feature flags associated with this flag.

davidtwco force-pushed the issue-55396-stabilize-linker-flavor branch from fbda374 to 9536d04 Compare December 13, 2018 08:42

pnkfelix mentioned this pull request Dec 13, 2018

rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker #55396

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2018

kennytm mentioned this pull request Dec 13, 2018

Rollup of 32 pull requests #56775

Closed

bors mentioned this pull request Dec 14, 2018

Start using serde_derive in a couple places in the compiler #56795

Closed

bors merged commit 9536d04 into rust-lang:master Dec 14, 2018

davidtwco deleted the issue-55396-stabilize-linker-flavor branch December 15, 2018 20:52

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 16, 2018

briansmith mentioned this pull request Mar 26, 2019

Linking with LLD #39915

Open

Centril added this to the 1.33 milestone Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize `linker-flavor` flag. #56351

Stabilize `linker-flavor` flag. #56351

davidtwco commented Nov 29, 2018

nagisa commented Nov 29, 2018 •

edited by pnkfelix

Loading

rfcbot commented Nov 29, 2018 •

edited by petrochenkov

Loading

This comment has been minimized.

rfcbot commented Dec 6, 2018

nagisa commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 14, 2018

bors commented Dec 14, 2018

Stabilize linker-flavor flag. #56351

Stabilize linker-flavor flag. #56351

Conversation

davidtwco commented Nov 29, 2018

nagisa commented Nov 29, 2018 • edited by pnkfelix Loading

rfcbot commented Nov 29, 2018 • edited by petrochenkov Loading

This comment has been minimized.

rfcbot commented Dec 6, 2018

nagisa commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 14, 2018

bors commented Dec 14, 2018

Stabilize `linker-flavor` flag. #56351

Stabilize `linker-flavor` flag. #56351

nagisa commented Nov 29, 2018 •

edited by pnkfelix

Loading

rfcbot commented Nov 29, 2018 •

edited by petrochenkov

Loading