Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[rustc_error] survey #55532

Merged
merged 5 commits into from
Nov 8, 2018
Merged

#[rustc_error] survey #55532

merged 5 commits into from
Nov 8, 2018

Conversation

pnkfelix
Copy link
Member

Fix #55505

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2018
@pnkfelix pnkfelix changed the title Rustc error survey #[rustc_error] survey Oct 31, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2018

📌 Commit 51fd805dfc8fc84ccefffb2a9511530116845668 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2018
@bors
Copy link
Contributor

bors commented Nov 4, 2018

⌛ Testing commit 51fd805dfc8fc84ccefffb2a9511530116845668 with merge 56d741945fbc18d539fe5664c3c18e68db41b983...

@bors
Copy link
Contributor

bors commented Nov 4, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-nopt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:11:30] 
[01:11:30] ---- [ui] ui/lint/lint-type-overflow2.rs stdout ----
[01:11:30] diff of stderr:
[01:11:30] 
[01:11:30] 34 LL |     let x =  1.7976931348623159e+308_f64; //~ warn: literal out of range for f64
[01:11:30] 36 
[01:11:30] - warning: this expression will panic at runtime
[01:11:30] - warning: this expression will panic at runtime
[01:11:30] + warning: attempt to negate with overflow
[01:11:30] 39    |
[01:11:30] 39    |
[01:11:30] 40 LL |     let x2: i8 = --128; //~ warn: literal out of range for i8
[01:11:30] -    |                  ^^^^^ attempt to negate with overflow
[01:11:30] +    |                  ^^^^^
[01:11:30] 42    |
[01:11:30] 43 note: lint level defined here
[01:11:30] 43 note: lint level defined here
[01:11:30] 44   --> $DIR/lint-type-overflow2.rs:13:9
[01:11:30] 
[01:11:30] 45    |
[01:11:30] 46 LL | #![warn(const_err)]
[01:11:30] + 
[01:11:30] + warning: this expression will panic at runtime
[01:11:30] +   --> $DIR/lint-type-overflow2.rs:19:18
[01:11:30] +    |
[01:11:30] +    |
[01:11:30] + LL |     let x2: i8 = --128; //~ warn: literal out of range for i8
[01:11:30] +    |                  ^^^^^ attempt to negate with overflow
[01:11:30] 49 
[01:11:30] 
[01:11:30] 
[01:11:30] The actual stderr differed from the expected stderr.
[01:11:30] The actual stderr differed from the expected stderr.
[01:11:30] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/lint-type-overflow2.stderr
[01:11:30] To update references, rerun the tests and pass the `--bless` flag
[01:11:30] To only update this specific test, also pass `--test-args lint/lint-type-overflow2.rs`
[01:11:30] error: 1 errors occurred comparing output.
[01:11:30] status: exit code: 0
[01:11:30] status: exit code: 0
[01:11:30] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-type-overflow2.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/a" "-Crpath" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/auxiliary" "-A" "unused"
[01:11:30] ------------------------------------------
[01:11:30] 
[01:11:30] ------------------------------------------
[01:11:30] stderr:
[01:11:30] stderr:
[01:11:30] ------------------------------------------
[01:11:30] {"message":"literal out of range for i8","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":597,"byte_end":600,"line_start":19,"line_end":19,"column_start":20,"column_end":23,"is_primary":true,"text":[{"text":"    let x2: i8 = --128; //~ warn: literal out of range for i8","highlight_start":20,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":478,"byte_end":498,"line_start":12,"line_end":12,"column_start":9,"column_end":29,"is_primary":true,"text":[{"text":"#![warn(overflowing_literals)]","highlight_start":9,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"warning: literal out of range for i8\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:19:20\n   |\nLL |     let x2: i8 = --128; //~ warn: literal out of range for i8\n   |                    ^^^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:12:9\n   |\nLL | #![warn(overflowing_literals)]\n   |         ^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:11:30] {"message":"literal out of range for f32","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":654,"byte_end":672,"line_start":21,"line_end":21,"column_start":14,"column_end":32,"is_primary":true,"text":[{"text":"    let x = -3.40282357e+38_f32; //~ warn: literal out of range for f32","highlight_start":14,"highlight_end":32}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: literal out of range for f32\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:21:14\n   |\nLL |     let x = -3.40282357e+38_f32; //~ warn: literal out of range for f32\n   |              ^^^^^^^^^^^^^^^^^^\n\n"}
[01:11:30] {"message":"literal out of range for f32","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":726,"byte_end":744,"line_start":22,"line_end":22,"column_start":14,"column_end":32,"is_primary":true,"text":[{"text":"    let x =  3.40282357e+38_f32; //~ warn: literal out of range for f32","highlight_start":14,"highlight_end":32}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: literal out of range for f32\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:22:14\n   |\nLL |     let x =  3.40282357e+38_f32; //~ warn: literal out of range for f32\n   |              ^^^^^^^^^^^^^^^^^^\n\n"}
[01:11:30] {"message":"literal out of range for f64","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":798,"byte_end":825,"line_start":23,"line_end":23,"column_start":14,"column_end":41,"is_primary":true,"text":[{"text":"    let x = -1.7976931348623159e+308_f64; //~ warn: literal out of range for f64","highlight_start":14,"highlight_end":41}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: literal out of range for f64\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:23:14\n   |\nLL |     let x = -1.7976931348623159e+308_f64; //~ warn: literal out of range for f64\n   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:11:30] {"message":"literal out of range for f64","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":879,"byte_end":906,"line_start":24,"line_end":24,"column_start":14,"column_end":41,"is_primary":true,"text":[{"text":"    let x =  1.7976931348623159e+308_f64; //~ warn: literal out of range for f64","highlight_start":14,"highlight_end":41}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: literal out of range for f64\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:24:14\n   |\nLL |     let x =  1.7976931348623159e+308_f64; //~ warn: literal out of range for f64\n   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:11:30] {"message":"attempt to negate with overflow","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":595,"byte_end":600,"line_start":19,"line_end":19,"column_start":18,"column_end":23,"is_primary":true,"text":[{"text":"    let x2: i8 = --128; //~ warn: literal out of range for i8","highlight_start":18,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":509,"byte_end":518,"line_start":13,"line_end":13,"column_start":9,"column_end":18,"is_primary":true,"text":[{"text":"#![warn(const_err)]","highlight_start":9,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"warning: attempt to negate with overflow\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:19:18\n   |\nLL |     let x2: i8 = --128; //~ warn: literal out of range for i8\n   |                  ^^^^^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:13:9\n   |\nLL | #![warn(const_err)]\n   |         ^^^^^^^^^\n\n"}
[01:11:30] {"message":"this expression will panic at runtime","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":595,"byte_end":600,"line_start":19,"line_end":19,"column_start":18,"column_end":23,"is_primary":true,"text":[{"text":"    let x2: i8 = --128; //~ warn: literal out of range for i8","highlight_start":18,"highlight_end":23}],"label":"attempt to negate with overflow","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: this expression will panic at runtime\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:19:18\n   |\nLL |     let x2: i8 = --128; //~ warn: literal out of range for i8\n   |                  ^^^^^ attempt to negate with overflow\n\n"}
[01:11:30] ------------------------------------------
[01:11:30] 
[01:11:30] thread '[ui] ui/lint/lint-type-overflow2.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3284:9
[01:11:30] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[01:11:30] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:503:22
[01:11:30] 
[01:11:30] 
[01:11:30] 
[01:11:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -Zunstable-options " "--target-rustcflags" "-Crpath -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:11:30] 
[01:11:30] 
[01:11:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:11:30] Build completed unsuccessfully in 0:04:07
[01:11:30] Build completed unsuccessfully in 0:04:07
[01:11:30] make: *** [check] Error 1
[01:11:30] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:018ff906
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0a0faff7:start=1541372107584086224,finish=1541372107592674328,duration=8588104
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:002969b8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0cf5a3de
travis_time:start:0cf5a3de
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0242e098
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2018
@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 5, 2018

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Nov 5, 2018

📌 Commit b1d39bf26143c15a91811d1978c521621fc39441 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:03254a7e:start=1541417438953379725,finish=1541417441090165198,duration=2136785473
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:49:11] .................................................................................................... 2600/4989
[00:49:15] .................................................................................................... 2700/4989
[00:49:18] .................................................................................................... 2800/4989
[00:49:21] .................................................................................................... 2900/4989
[00:49:25] ..........................F......................................................................... 3000/4989
[00:49:31] ..............................................................................i.i..ii............... 3200/4989
[00:49:35] .................................................................................................... 3300/4989
[00:49:39] .................................................................................................... 3400/4989
[00:49:42] ...................................................i.ii............................................. 3500/4989
---
[00:50:27] 
[00:50:27] ---- [ui] ui/lint/lint-type-overflow2.rs stdout ----
[00:50:27] diff of stderr:
[00:50:27] 
[00:50:27] 34 LL |     let x =  1.7976931348623159e+308_f64; //~ warn: literal out of range for f64
[00:50:27] 36 
[00:50:27] - warning: attempt to negate with overflow
[00:50:27] + warning: this expression will panic at runtime
[00:50:27] 38   --> $DIR/lint-type-overflow2.rs:19:18
[00:50:27] 38   --> $DIR/lint-type-overflow2.rs:19:18
[00:50:27] 39    |
[00:50:27] 40 LL |     let x2: i8 = --128; //~ warn: literal out of range for i8
[00:50:27] -    |                  ^^^^^
[00:50:27] +    |                  ^^^^^ attempt to negate with overflow
[00:50:27] 42    |
[00:50:27] 43 note: lint level defined here
[00:50:27] 43 note: lint level defined here
[00:50:27] 44   --> $DIR/lint-type-overflow2.rs:13:9
[00:50:27] 
[00:50:27] 45    |
[00:50:27] 46 LL | #![warn(const_err)]
[00:50:27] - 
[00:50:27] - warning: this expression will panic at runtime
[00:50:27] -   --> $DIR/lint-type-overflow2.rs:19:18
[00:50:27] -    |
[00:50:27] -    |
[00:50:27] - LL |     let x2: i8 = --128; //~ warn: literal out of range for i8
[00:50:27] -    |                  ^^^^^ attempt to negate with overflow
[00:50:27] 55 
[00:50:27] 
[00:50:27] 
[00:50:27] The actual stderr differed from the expected stderr.
[00:50:27] The actual stderr differed from the expected stderr.
[00:50:27] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/lint-type-overflow2.stderr
[00:50:27] To update references, rerun the tests and pass the `--bless` flag
[00:50:27] To only update this specific test, also pass `--test-args lint/lint-type-overflow2.rs`
[00:50:27] error: 1 errors occurred comparing output.
[00:50:27] status: exit code: 0
[00:50:27] status: exit code: 0
[00:50:27] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-type-overflow2.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-hiletest/src/runtest.rs:3284:9
[00:50:27] 
[00:50:27] 
[00:50:27] failures:
[00:50:27]     [ui] ui/lint/lint-type-overflow2.rs
[00:50:27]     [ui] ui/lint/lint-type-overflow2.rs
[00:50:27] 
[00:50:27] test result: FAILED. 4964 passed; 1 failed; 24 ignored; 0 measured; 0 filtered out
[00:50:27] 
[00:50:27] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:503:22
[00:50:27] 
[00:50:27] 
[00:50:27] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:50:27] 
[00:50:27] 
[00:50:27] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:50:27] Build completed unsuccessfully in 0:03:44
[00:50:27] Build completed unsuccessfully in 0:03:44
[00:50:27] Makefile:58: recipe for target 'check' failed
[00:50:27] make: *** [check] Error 1
33452 ./obj/build/x86_64-unknown-linux-gnu/stage0-std
32644 ./src/llvm/test/tools
32464 ./obj/build/x86_64-unknown-linux-gnu/stage0-std/release
32460 ./obj/build/x86_64-unknown-linux-gnu/stage1-std/release
---
travis_time:end:038073ba:start=1541420480738318387,finish=1541420480744657403,duration=6339016
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1eec0dbe
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0cb01970
travis_time:start:0cb01970
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:15532e39
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 6, 2018

⌛ Testing commit b1d39bf26143c15a91811d1978c521621fc39441 with merge 3d39e57933b85fd823de5f16f8c9095e1b6f2949...

@bors
Copy link
Contributor

bors commented Nov 6, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:05:21] [RUSTC-TIMING] rustc_target test:false 13.867
[00:05:22] [RUSTC-TIMING] syntax_pos test:false 6.846
[00:05:22]    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
[00:05:29] [RUSTC-TIMING] rustc_errors test:false 6.952
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 6, 2018
@kennytm
Copy link
Member

kennytm commented Nov 6, 2018

The bors queue has a spurious failure (30 min timeout which is likely related to 9696), but the CI PR reported in #55532 (comment) looks legit, so I'm not going to retry.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2018
@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 7, 2018

That is very goofy. I do not see that test result locally (when testing stage1). Is there any chance that our diagnostic here is behaving differently on different platforms...? (or that the behavior somehow differs between stage1 and stage2 here...?)

  • Update: No, stage2 works fine locally.

@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 7, 2018

(isn't it also weird that the travis result says this:

[00:50:27] failures:
[00:50:27]     [ui] ui/lint/lint-type-overflow2.rs
[00:50:27]     [ui] ui/lint/lint-type-overflow2.rs

Why is that occurring twice?

@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 7, 2018

Oh, the raw log has it only once.

So that's something wrong with some other piece of post-processing, I guess

This test specifically notes that it does not want to invoke the
linker, due to the way it (IMO weakly) exercises the `#[link=...]`
attribute.

In any case, removing the the `#[rustc_error]` here uncovered an
"invalid windows subsystem" error that was previously not included in
the transcript of diagnostic output. So that's a step forward, (right?).
I also added `// skip-codegen` to each one, to address potential concerns
that this change would otherwise slow down our test suite spending time
generating code for files that are really just meant to be checks of
compiler diagnostics.

(However, I will say: My preference is to not use `// skip-codegen` if
one can avoid it. We can use all the testing of how we drive LLVM that
we can get...)

(Updated post rebase.)
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0a662696:start=1541592328806653768,finish=1541592384665233196,duration=55858579428
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:48:48] .................................................................................................... 2600/4997
[00:48:51] .................................................................................................... 2700/4997
[00:48:55] .................................................................................................... 2800/4997
[00:48:57] .................................................................................................... 2900/4997
[00:49:01] ....................................F............................................................... 3000/4997
[00:49:07] ......................................................................................i.i..ii....... 3200/4997
[00:49:11] .................................................................................................... 3300/4997
[00:49:14] .................................................................................................... 3400/4997
[00:49:17] ...........................................................i.ii..................................... 3500/4997
---
[00:49:59] 
[00:49:59] ---- [ui] ui/lint/lint-type-overflow2.rs stdout ----
[00:49:59] diff of stderr:
[00:49:59] 
[00:49:59] 34 LL |     let x =  1.7976931348623159e+308_f64; //~ warn: literal out of range for f64
[00:49:59] 36 
[00:49:59] - warning: attempt to negate with overflow
[00:49:59] + warning: this expression will panic at runtime
[00:49:59] 38   --> $DIR/lint-type-overflow2.rs:19:18
[00:49:59] 38   --> $DIR/lint-type-overflow2.rs:19:18
[00:49:59] 39    |
[00:49:59] 40 LL |     let x2: i8 = --128; //~ warn: literal out of range for i8
[00:49:59] -    |                  ^^^^^
[00:49:59] +    |                  ^^^^^ attempt to negate with overflow
[00:49:59] 42    |
[00:49:59] 43 note: lint level defined here
[00:49:59] 43 note: lint level defined here
[00:49:59] 44   --> $DIR/lint-type-overflow2.rs:13:9
[00:49:59] 
[00:49:59] 45    |
[00:49:59] 46 LL | #![warn(const_err)]
[00:49:59] - 
[00:49:59] - warning: this expression will panic at runtime
[00:49:59] -   --> $DIR/lint-type-overflow2.rs:19:18
[00:49:59] -    |
[00:49:59] -    |
[00:49:59] - LL |     let x2: i8 = --128; //~ warn: literal out of range for i8
[00:49:59] -    |                  ^^^^^ attempt to negate with overflow
[00:49:59] 55 
[00:49:59] 
[00:49:59] 
[00:49:59] The actual stderr differed from the expected stderr.
[00:49:59] The actual stderr differed from the expected stderr.
[00:49:59] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/lint-type-overflow2.stderr
[00:49:59] To update references, rerun the tests and pass the `--bless` flag
[00:49:59] To only update this specific test, also pass `--test-args lint/lint-type-overflow2.rs`
[00:49:59] error: 1 errors occurred comparing output.
[00:49:59] status: exit code: 0
[00:49:59] status: exit code: 0
[00:49:59] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-type-overflow2.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-type-overflow2/auxiliary" "-A" "unused"
[00:49:59] ------------------------------------------
[00:49:59] 
[00:49:59] ------------------------------------------
[00:49:59] stderr:
[00:49:59] stderr:
[00:49:59] ------------------------------------------
[00:49:59] {"message":"literal out of range for i8","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":597,"byte_end":600,"line_start":19,"line_end":19,"column_start":20,"column_end":23,"is_primary":true,"text":[{"text":"    let x2: i8 = --128; //~ warn: literal out of range for i8","highlight_start":20,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":478,"byte_end":498,"line_start":12,"line_end":12,"column_start":9,"column_end":29,"is_primary":true,"text":[{"text":"#![warn(overflowing_literals)]","highlight_start":9,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"warning: literal out of range for i8\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:19:20\n   |\nLL |     let x2: i8 = --128; //~ warn: literal out of range for i8\n   |                    ^^^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:12:9\n   |\nLL | #![warn(overflowing_literals)]\n   |         ^^^^^^^^^^^^^^^^^^^^\n\n"}
[00:49:59] {"message":"literal out of range for f32","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":706,"byte_end":724,"line_start":21,"line_end":21,"column_start":14,"column_end":32,"is_primary":true,"text":[{"text":"    let x = -3.40282357e+38_f32; //~ warn: literal out of range for f32","highlight_start":14,"highlight_end":32}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: literal out of range for f32\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:21:14\n   |\nLL |     let x = -3.40282357e+38_f32; //~ warn: literal out of range for f32\n   |              ^^^^^^^^^^^^^^^^^^\n\n"}
[00:49:59] {"message":"literal out of range for f32","code":{"code":"overflowing_literals","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lint-type-overflow2.rs","byte_start":778,"byte_end":796,"line_start":22,"line_end":22,"column_start":14,"column_end":32,"is_primary":true,"text":[{"text":"    let x =  3.40282357e+38_f32; //~ warn: literal out of range for f32","highlight_start":14,"highlight_end":32}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: literal out of range for f32\n  --> /checkout/src/test/ui/lint/lint-type-overflow2.rs:22:14[00:49:59] thread '[ui] ui/lint/lint-type-overflow2.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3284:9
[00:49:59] 
[00:49:59] 
[00:49:59] failures:
[00:49:59]     [ui] ui/lint/lint-type-overflow2.rs
[00:49:59]     [ui] ui/lint/lint-type-overflow2.rs
[00:49:59] 
[00:49:59] test result: FAILED. 4972 passed; 1 failed; 24 ignored; 0 measured; 0 filtered out
[00:49:59] 
[00:49:59] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:503:22
[00:49:59] 
[00:49:59] 
[00:49:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:49:59] 
[00:49:59] 
[00:49:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:49:59] Build completed unsuccessfully in 0:03:33
[00:49:59] Build completed unsuccessfully in 0:03:33
[00:49:59] make: *** [check] Error 1
[00:49:59] Makefile:58: recipe for target 'check' failed
2344960 ./obj
2344920 ./obj/build
1709152 ./obj/build/x86_64-unknown-linux-gnu
1193884 ./.git
---
143000 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc
137216 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu
137212 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release
134668 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u
134664 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u/s-f6g5uzwb8l-53l2y9-22tmsi8iacpi9
130756 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu
130752 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
123680 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
111080 ./src/llvm/test/CodeGen
---
56044 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/build
55856 ./obj/build/x86_64-unknown-linux-gnu/stage0-sysroot
55852 ./obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib
55848 ./obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib
55844 ./obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-vis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:274fc138
travis_time:start:274fc138
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:084f7dd8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 7, 2018

okay ... at this point I assume this must be some weird artifact of my own environment, maybe some customization in my config.toml. Looking.

@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 7, 2018

(ah it might be due to an optimize-tests = false in my config.toml...

@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 7, 2018

Yes, okay, the presence/absence of -O causes the lint output to differ here.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 7, 2018

I usually add // compile-flags: -O to such tests, so that optimize-tests does not change the behavior`

…rom `rustc -O`.

(The fact that output differs under `opt-level=0` is an instance of rust-lang#55757.)
@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 7, 2018

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Nov 7, 2018

📌 Commit f4da71e has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2018
@bors
Copy link
Contributor

bors commented Nov 8, 2018

⌛ Testing commit f4da71e with merge 653da4f...

bors added a commit that referenced this pull request Nov 8, 2018
@bors
Copy link
Contributor

bors commented Nov 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 653da4f to master...

@bors bors merged commit f4da71e into rust-lang:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants