-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lifetime syntax #5394
Closed
Closed
Lifetime syntax #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otation. rs=delifetiming
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
`cargo dev` has been the replacement for a while, so I think we can remove it now. cc rust-lang#5394
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
Remove util/dev script `cargo dev` has been the replacement for a while, so I think we can remove it now. cc rust-lang#5394 changelog: none
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Stop updating the lint counter with every new lint r? @Manishearth This PR does two things: 1. Clean up the clippy_dev module a bit (first 3 commits; cc rust-lang#5394 ) 2. Make the counter in the README count in steps of 50 lints. Also use a `lazy_static` `Vec` for the lint list, so no counter is required there anymore. changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 28, 2020
Fix cargo dev new_lint for late lint passes Since rust-lang/rust-clippy@30c046e, `LateLintPass` has only one lifetime parameter. I'm not sure how to easily test this, I think adding this kind of tests would be probably part of rust-lang#5394 changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 20, 2020
This replaces the `update-all-references` scripts with a single cargo dev bless command. cc rust-lang#5394
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 20, 2020
Rewrite update-all-references bash scripts in Rust This replaces the `update-all-references` scripts with a single cargo dev bless command. It should behave mostly the same as the bash scripts. The major difference is, that it can be called from the project root and will always update the files in all of the test suites. cc rust-lang#5394 changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 25, 2021
…earth Upgrade compiletest-rs to 0.6 and tester to 0.9 These updates allow us to specify multiple testnames for `TESTNAME` by providing a comma separated list of testnames. The new version of compiletest-rs also includes `bless` support, but is not enabled with this PR. cc rust-lang#5394 changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 1, 2021
…flip1995 Added `cargo dev setup git-hook` and updated `cargo dev setup intellij` including a `remove` command This PR enables our dev tool to install a git hook that formats the code before each commit and also runs `update_lints` to make sure that everything is registered correctly. The script is located at `util/etc/pre-commit.sh`. I found it reasonable to locate it in the `util` folder and decided to add a `etc` in correlation to the main rust repo and to bring a bit of structure into it. * The hook can be installed via: `cargo dev setup git-hook` * And removed via: `cargo dev remove git-hook` cc: rust-lang#5394 The refactoring of `src/ide_setup.rs` to `src/setup/intellij.rs` is an extra commit to simplify the review. --- Changes: * Added `cargo dev setup git-hook` for formatting before every commit * Added `cargo dev remove git-hook` to remove the hook again * Added `cargo dev remove intellij` to remove rustc source path dependencies * Changed `cargo dev ide_setup` to `cargo dev setup intellij` changelog: none This is only an internal change and therefore not worth an entry in the general change log. --- Tested on: * [x] Linux (by `@xFrednet)` * [ ] Windows (All used commands run inside the git bash, so it's very likely to work as well `@xFrednet)` * [ ] macOS
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 1, 2021
…te,flip1995 Added `cargo dev setup vscode-tasks` for simplicity This PR adds a setup command to `clippy dev` that installs tasks into the Clippy vscode workspace. These might be useful as they be used via shortcuts and are accessible over the GUI. The available tasks are: * `cargo check` (standard Linux shortcut `[ctrl] + [shift] + b`) * `cargo dev fmt` * `cargo uitest` (with a comment how to add the `TESTNAME` environment value) * `cargo test` * `cargo dev bless` --- changelog: none only internal changes again. cc rust-lang#5394 r? `@flip1995` This should be pretty much the same as the other `cargo dev setup` commands. Would you mind reviewing this? 🙃
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
Add `cargo dev dogfood` changelog: Add `cargo dev dogfood` Part of rust-lang#5394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis