-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stabilize opt-level={s,z} #50265
stabilize opt-level={s,z} #50265
Conversation
Thanks @japaric! Could I persuade a @rust-lang/compiler member to rfcbot this for merging? |
@rfcbot fcp merge
Lets see if rfcbot control works over mail.
To be honest I'm surprised this is not yet stable.
…On Fri, Apr 27, 2018, 05:38 Alex Crichton ***@***.***> wrote:
Thanks @japaric <https://github.com/japaric>! Could I persuade a
@rust-lang/compiler <https://github.com/orgs/rust-lang/teams/compiler>
member to rfcbot this for merging?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#50265 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AApc0i8ENx79tvfmxoy7cvFSkkm5wenPks5tsoS7gaJpZM4TpRtF>
.
|
Team member @nagisa has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
This also closes #47651. |
Not a real concern, but we might think about giving better name for this option, because |
|
|
@rfcbot reviewed |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. |
@bors: r+ |
📌 Commit 2b09d7c has been approved by |
⌛ Testing commit 2b09d7c with merge 994e55b7c0995f7d91f801247a2a2d14a672ef2a... |
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
⌛ Testing commit 2b09d7c with merge 76a42250fa82a3d963a34ad3caf161ca731e9c86... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
stabilize opt-level={s,z} closes #35784 closes #47651 ### Rationale Since the lastest LLVM upgrade rustc / LLVM does more agressive loop unrolling. This results in increased binary size of embedded / no_std programs: a hundreds of bytes increase, or about a 7x increase, in the case of the smallest Cortex-M binary cf. #49260. As we are shooting for embedded Rust on stable it would be great to also provide a way to optimize for size (which is pretty important for embedded applications that target resource constrained devices) on stable. Also this has been baking in nightly for a long time. r? @alexcrichton which team has to sign off this?
☀️ Test successful - status-appveyor, status-travis |
closes #35784
closes #47651
Rationale
Since the lastest LLVM upgrade rustc / LLVM does more agressive loop unrolling. This results in increased binary size of embedded / no_std programs: a hundreds of bytes increase, or about a 7x increase, in the case of the smallest Cortex-M binary cf. #49260.
As we are shooting for embedded Rust on stable it would be great to also provide a way to optimize for size (which is pretty important for embedded applications that target resource constrained devices) on stable.
Also this has been baking in nightly for a long time.
r? @alexcrichton which team has to sign off this?