rustbuild: Pass ccache to build scripts
#48630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm |
|
📌 Commit 5262be3 has been approved by |
bors
added
the
S-waiting-on-bors
src/ci/run.sh
Outdated
| # server (#48192) which causes Cargo to erroneously think that a build script | ||
| # hasn't finished yet. Try to solve that problem by starting a very long-lived | ||
| # sccache server at the start of the build, but no need to worry if this fails. | ||
| SCCACHE_IDLE_TIMEOUT=7200 sccache --start-server || true |
There was a problem hiding this comment.
This seems insufficient -- 120 minutes is only 2 hours, whereas our builders go up to 3 hours sometimes. Maybe we should lengthen it just to make sure?
This is a re-attempt at rust-lang#48192 hopefully this time with 100% less randomly [blocking builds for 20 minutes][block]. To work around rust-lang#48192 the sccache server is started in the `run.sh` script very early on in the compilation process. [block]: rust-lang#48192
alexcrichton
force-pushed
the
more-sccache
branch
from
5262be3
to
fdef6a8
Compare
|
@bors: r=kennytm |
|
📌 Commit fdef6a8 has been approved by |
|
@bors p=2 prioritizing risky-to-rollup PRs so they get tested first |
|
⌛ Testing commit fdef6a8 with merge 52d1a82644c5d5c8bb0fdc6fc4c393ba594137b8... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 3, 2018
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-attempt at #48192 hopefully this time with 100% less randomly
blocking builds for 20 minutes. To work around #48192 the sccache
server is started in the
run.shscript very early on in the compilationprocess.