Do not require semantic types for all syntactic types when there are errors #44945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochenkov
force-pushed
the
fixtyrec
branch
from
63262b1
to
8037c28
Compare
|
I've tweaked the patch slightly and moved the |
|
@bors r+ |
|
📌 Commit 8037c28 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 1, 2017
Do not require semantic types for all syntactic types when there are errors Fixes #44814 Fixes #44858 Fixes #44946 r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44814
Fixes #44858
Fixes #44946
r? @nikomatsakis