Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Remove specialization_cache in favor of a query #44157

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Aug 29, 2017

This commit removes the specialization_cache field of TyCtxt by moving it to
a dedicated query, which it turned out was already quite easily structured to do
so!

cc #44137

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton changed the title rustc: Remove specailization_cache in favor of a query rustc: Remove specialization_cache in favor of a query Aug 29, 2017
@alexcrichton
Copy link
Member Author

r? @nikomatsakis

@eddyb
Copy link
Member

eddyb commented Aug 29, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Aug 29, 2017

📌 Commit 58a6f51 has been approved by eddyb

This commit removes the `specialization_cache` field of `TyCtxt` by moving it to
a dedicated query, which it turned out was already quite easily structured to do
so!
@alexcrichton
Copy link
Member Author

@bors: r=eddyb

@bors
Copy link
Contributor

bors commented Aug 29, 2017

📌 Commit 27c4ff6 has been approved by eddyb

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 29, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
…r=eddyb

rustc: Remove `specialization_cache` in favor of a query

This commit removes the `specialization_cache` field of `TyCtxt` by moving it to
a dedicated query, which it turned out was already quite easily structured to do
so!

cc rust-lang#44137
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 30, 2017
…r=eddyb

rustc: Remove `specialization_cache` in favor of a query

This commit removes the `specialization_cache` field of `TyCtxt` by moving it to
a dedicated query, which it turned out was already quite easily structured to do
so!

cc rust-lang#44137
bors added a commit that referenced this pull request Aug 31, 2017
Rollup of 8 pull requests

- Successful merges: #44044, #44089, #44116, #44125, #44154, #44157, #44160, #44172
- Failed merges: #44162
@bors bors merged commit 27c4ff6 into rust-lang:master Aug 31, 2017
@alexcrichton alexcrichton deleted the no-specializes-cache branch September 1, 2017 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants