Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter lifetimes from impl trait parent generics #43645

Closed
wants to merge 2 commits into from

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Aug 4, 2017

Also temporarily breaks late-bound lifetimes, since @eddyb wasn't sure what I should do about those.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj
Copy link
Member Author

cramertj commented Aug 4, 2017

r? @nikomatsakis

@pnkfelix is out, I think.

@arielb1 arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2017

cc me

@cramertj cramertj changed the title [WIP] Filter lifetimes from impl trait parent generics Filter lifetimes from impl trait parent generics Aug 12, 2017
@cramertj
Copy link
Member Author

cc @eddyb

@cramertj
Copy link
Member Author

Tests are now passing locally.

@kennytm
Copy link
Member

kennytm commented Aug 12, 2017

Failed to build librustc_data_structures at stage1.

[00:18:48]    Compiling rustc_data_structures v0.0.0 (file:///checkout/src/librustc_data_structures)
[00:18:49] error: internal compiler error: /checkout/src/librustc/ty/subst.rs:411: Region parameter out of range when substituting in region 'a (root type=None) (index=2)
[00:18:49] 
[00:18:49] note: the compiler unexpectedly panicked. this is a bug.
[00:18:49] 
[00:18:49] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:18:49] 
[00:18:49] note: rustc 1.21.0-dev (d09f53bc8 2017-08-12) running on x86_64-unknown-linux-gnu
[00:18:49] 
[00:18:49] thread 'rustc' panicked at 'Box<Any>', /checkout/src/librustc_errors/lib.rs:434:8
[00:18:49] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:18:49] 
[00:18:49] error: Could not compile `rustc_data_structures`.

@cramertj
Copy link
Member Author

Well that's certainly weird... I wonder how I got it to work locally.

@bors
Copy link
Contributor

bors commented Aug 16, 2017

☔ The latest upstream changes (presumably #43710) made this pull request unmergeable. Please resolve the merge conflicts.

@aidanhs
Copy link
Member

aidanhs commented Aug 23, 2017

Hi @cramertj, just a friendly ping to make sure this is still on your radar! I can see there are some merge conflicts.

@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2017

🕸 This PR had been inactive for 2 weeks. Closing it to keep our queue clean. Feel free to reopen. 🕸

@arielb1 arielb1 closed this Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants