Some preparatory refactorings for hash-based DepNodes #42504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n being able to reconstruct obj-file names from one.
This allows for treating global crate metadata the same as regular metadata with regard to incr. comp.
nikomatsakis
reviewed
Jun 7, 2017
src/librustc/dep_graph/dep_node.rs
Outdated
| @@ -56,7 +58,7 @@ pub enum DepNode<D: Clone + Debug> { | |||
|
|
|||
| /// Represents some artifact that we save to disk. Note that these | |||
| /// do not have a def-id as part of their identifier. | |||
| WorkProduct(Arc<WorkProductId>), | |||
| WorkProduct(WorkProductId), | |||
There was a problem hiding this comment.
does this make DepNode be Copy? That would be great!
There was a problem hiding this comment.
(What is Fingerprint anyway?)
There was a problem hiding this comment.
Yes, DepNode will be Copy.
A Fingerprint is a hash value with a "virtual uniqueness" property, i.e. there will be collisions (like with any hash) but the probability is so low that it doesn't matter. Because of this property, a Fingerprint can be used as an identifier. In terms of rustc I now use the type Fingerprint for anything that fulfills this property but sometimes I like to introduce newtypes for it, for example DefPathHash.
nikomatsakis
approved these changes
Jun 7, 2017
|
@bors r+ |
|
📌 Commit 8b36d33 has been approved by |
aidanhs
added
the
S-waiting-on-bors
2 tasks
|
⌛ Testing commit 8b36d33 with merge 19193d6... |
bors
added a commit
that referenced
this pull request
Jun 9, 2017
…tsakis Some preparatory refactorings for hash-based DepNodes This PR collects some changes that turn out to be necessary for implementing `DepNodes` based on stable hashes (see #42294). The commits are self-contained and mostly straightforward. The most interesting change here is the introduction of `DefIndices` for things that are not part of the AST: Some pieces of crate metadata now have a `DefIndex` too. cc @eddyb r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Jun 12, 2017
incr.comp.: Make DepNode `Copy` and valid across compilation sessions This PR moves `DepNode` to a representation that does not need retracing and thus simplifies comparing dep-graphs from different compilation sessions. The code also gets a lot simpler in many places, since we don't need the generic parameter on `DepNode` anymore. See #42294 for details. ~~NOTE: Only the last commit of this is new, the rest is already reviewed in #42504 This PR is almost done but there are some things I still want to do: - [x] Add some module-level documentation to `dep_node.rs`, explaining especially what the `define_dep_nodes!()` macro is about. - [x] Do another pass over the dep-graph loading logic. I suspect that we can get rid of building the `edges` map and also use arrays instead of hash maps in some places. cc @rust-lang/compiler r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects some changes that turn out to be necessary for implementing
DepNodesbased on stable hashes (see #42294). The commits are self-contained and mostly straightforward.The most interesting change here is the introduction of
DefIndicesfor things that are not part of the AST: Some pieces of crate metadata now have aDefIndextoo.cc @eddyb
r? @nikomatsakis