-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression test for #39974 #42217
regression test for #39974 #42217
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/test/compile-fail/issue-39974.rs
Outdated
|
||
struct Thing { | ||
f: [[f64; 2]; LENGTH], | ||
//~^ ERROR expected usize, found f64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need to update this to something like the below:
f: [[f64; 2]; LENGTH],
//~^ ERROR mismatched types
//~| expected usize, found f64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mark-Simulacrum I have updated the patch with your suggestion
@bors r+ (travis failure is spurious) |
📌 Commit c87f6d8 has been approved by |
@bors rollup |
…ulacrum regression test for rust-lang#39974 closes rust-lang#39974 r? @Mark-Simulacrum
…ulacrum regression test for rust-lang#39974 closes rust-lang#39974 r? @Mark-Simulacrum
…ulacrum regression test for rust-lang#39974 closes rust-lang#39974 r? @Mark-Simulacrum
…ulacrum regression test for rust-lang#39974 closes rust-lang#39974 r? @Mark-Simulacrum
…ulacrum regression test for rust-lang#39974 closes rust-lang#39974 r? @Mark-Simulacrum
closes #39974
r? @Mark-Simulacrum