Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize non capturing closure to fn coercion #42162

Closed
wants to merge 1 commit into from
Closed

Stabilize non capturing closure to fn coercion #42162

wants to merge 1 commit into from

Conversation

est31
Copy link
Member

@est31 est31 commented May 23, 2017 •
edited
Loading

Stabilisation PR for non capturing closure to fn coercion.

closes #39817

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented May 23, 2017

☔ The latest upstream changes (presumably #42165) made this pull request unmergeable. Please resolve the merge conflicts.

@arielb1 arielb1 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-lang Relevant to the language team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2017
@bors
Copy link
Contributor

bors commented May 25, 2017

☔ The latest upstream changes (presumably #41145) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik
Copy link
Member

all the other criteria needed for stabilisation are met.

Docs criteria is met.

@est31
Copy link
Member Author

est31 commented May 26, 2017

As agreed to on IRC, asking for early review (before the remaining 7 days of FCP are over) due to the branch date of beta in 7 days, otherwise the feature might not make it into 1.19. We can always back out later.

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned pnkfelix May 26, 2017
@aturon
Copy link
Member

aturon commented May 27, 2017

Let's go ahead and get this into the queue.

@bors: r+

@bors
Copy link
Contributor

bors commented May 27, 2017

📌 Commit 87950b7 has been approved by aturon

@shepmaster shepmaster added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels May 27, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42162 - est31:closure-to-fn-coercion, r=aturon
05d94c8 
Stabilize non capturing closure to fn coercion

Stabilisation PR for non capturing closure to fn coercion.

closes rust-lang#39817
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 27, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42162 - est31:closure-to-fn-coercion, r=aturon
d11e112 
Stabilize non capturing closure to fn coercion

Stabilisation PR for non capturing closure to fn coercion.

closes rust-lang#39817
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 27, 2017
Closed
bors added a commit that referenced this pull request May 27, 2017
@bors
Auto merge of #42258 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
5712e03 
Rollup of 10 pull requests

- Successful merges: #42103, #42137, #42162, #42167, #42175, #42207, #42217, #42246, #42249, #42251
- Failed merges:
@bors
Copy link
Contributor

bors commented May 27, 2017

⌛ Testing commit 87950b7 with merge 5d2512e...

bors added a commit that referenced this pull request May 27, 2017
@bors
Auto merge of #42162 - est31:closure-to-fn-coercion, r=aturon
5d2512e 
Stabilize non capturing closure to fn coercion

Stabilisation PR for non capturing closure to fn coercion.

closes #39817
@bors
Copy link
Contributor

bors commented May 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 5d2512e to master...

@est31
Copy link
Member Author

est31 commented May 28, 2017

It got merged yeey!

I'm not sure though why the PR doesn't get shown as "merged" by this. Github bug?

@est31 est31 closed this May 28, 2017
@Mark-Simulacrum
Copy link
Member

GH seems to recognize that it is merged afterwards though; I can't reopen -- "commits are already merged"

@dwrensha dwrensha mentioned this pull request May 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for RFC 1558: Allow coercing non-capturing closures to function pointers
9 participants
@est31 @rust-highfive @bors @steveklabnik @aturon @Mark-Simulacrum @pnkfelix @shepmaster @arielb1