-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc to accept #
at the start of a markdown file #40560
#40828
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Awesome, I'll try to check this out soon. |
@bors: r+ looks good to me! Some context: this isn't valid markdown. Rustdoc has supported only this for a long time, but as we want to transition the ecosystem to pulldown-cmark, being able to write things with @brson , tagging this relnotes so we can advertise it to start that process. |
📌 Commit 2e14bfe has been approved by |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 2e14bfe has been approved by |
…eklabnik rustdoc to accept `#` at the start of a markdown file rust-lang#40560 This may be a bit odd if `#` and `%` lines are mixed up, but that's not something I've found while doing my search and replace.
This may be a bit odd if
#
and%
lines are mixed up, but that's not something I've found while doing my search and replace.