Implement placement-in protocol for VecDeque
#40389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F001
changed the title
VecDequeVecDeque
|
Looks great to me. |
|
@bors delegate=nagisa |
|
✌️ @nagisa can now approve this pull request |
|
@bors r+ Thanks! |
|
📌 Commit 8062cfb has been approved by |
6 tasks
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 9, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
alexcrichton
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 11, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
bors
added a commit
that referenced
this pull request
Mar 11, 2017
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 11, 2017
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
tikue
reviewed
Mar 11, 2017
| reason = "placement protocol is subject to change", | ||
| issue = "30172")] | ||
| impl<'a, T> Placer<T> for PlaceBack<'a, T> { | ||
| type Place = PlaceBack<'a, T>; |
There was a problem hiding this comment.
Could this be type Place = Self?
There was a problem hiding this comment.
Thanks. It's the same. And I don't bias towards any one.
bors
added a commit
that referenced
this pull request
Mar 11, 2017
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #30172
r? @nagisa